cerc-io/lotus
11
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

exclude reverted events from results returned by eth_getLogs #3

Closed
i-norden wants to merge 2 commits from ian/exclude_reverted_events into master
pull from: ian/exclude_reverted_events
merge into: :master
Conversation 1 Commits 2 Files Changed 3
+624 -3
i-norden commented 2023-10-05 19:03:09 +00:00
Member
Copy Link
Copy Source

In Ethereum it is expected that the eth_getLogs endpoint will only return results for canonical blocks. Non-canonical logs are already being marked in the events.db sqlite database as "reverted", and this adds a missing conditional check on that column when selecting logs from the database.

In Ethereum it is expected that the `eth_getLogs` endpoint will only return results for canonical blocks. Non-canonical logs are already being marked in the events.db sqlite database as "reverted", and this adds a missing conditional check on that column when selecting logs from the database.
i-norden commented 2023-10-09 14:37:36 +00:00
Author
Member
Copy Link
Copy Source

Reopening against upstream

Reopening against upstream

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex cerccicd ericlewis i-norden (Ian Norden) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/lotus#3