add comment about Signal unsoundness

2023-03-31 11:52:24 +02:00
parent 371028a42a
commit 3cfbe3cd3f
1 changed files with 2 additions and 0 deletions
@@ -125,6 +125,8 @@ func (e *executionEnv) putToken(token *executionToken) {
 	e.available++
 	e.reserved += token.reserved

+	// Note: Signal is unsound, because a priority token could wake up a non-priority
+	// goroutnie and lead to deadlock. So Broadcast it must be.
 	e.cond.Broadcast()

 	metricsDown(metrics.VMExecutionRunning, token.lane)