fix: address review
This commit is contained in:
parent
f518e34131
commit
003eae81ce
@ -47,7 +47,7 @@ func newHeightEvents(api EventAPI, obs *observer, gcConfidence abi.ChainEpoch) *
|
|||||||
// specified height+confidence threshold. If the chain is rolled-back under the
|
// specified height+confidence threshold. If the chain is rolled-back under the
|
||||||
// specified height, `RevertHandler` will be called.
|
// specified height, `RevertHandler` will be called.
|
||||||
//
|
//
|
||||||
// ts passed to handlers is the tipset at the specified, or above, if lower tipsets were null
|
// ts passed to handlers is the tipset at the specified epoch, or above if lower tipsets were null.
|
||||||
//
|
//
|
||||||
// The context governs cancellations of this call, it won't cancel the event handler.
|
// The context governs cancellations of this call, it won't cancel the event handler.
|
||||||
func (e *heightEvents) ChainAt(ctx context.Context, hnd HeightHandler, rev RevertHandler, confidence int, h abi.ChainEpoch) error {
|
func (e *heightEvents) ChainAt(ctx context.Context, hnd HeightHandler, rev RevertHandler, confidence int, h abi.ChainEpoch) error {
|
||||||
|
@ -195,7 +195,7 @@ func (ts *apiSuite) testSlowNotify(t *testing.T) {
|
|||||||
|
|
||||||
full.WaitTillChain(ctx, kit.HeightAtLeast(baseHeight+100))
|
full.WaitTillChain(ctx, kit.HeightAtLeast(baseHeight+100))
|
||||||
|
|
||||||
// Make sure they were all closed.
|
// Make sure they were all closed, draining any buffered events first.
|
||||||
for _, ch := range newHeadsChans {
|
for _, ch := range newHeadsChans {
|
||||||
var ok bool
|
var ok bool
|
||||||
for ok {
|
for ok {
|
||||||
|
Loading…
Reference in New Issue
Block a user