From 003eae81ced7bbf78bb9b1d4454962caed099837 Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Fri, 27 Aug 2021 12:12:55 -0700 Subject: [PATCH] fix: address review --- chain/events/events_height.go | 2 +- itests/api_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chain/events/events_height.go b/chain/events/events_height.go index 73df04be6..6734d3ca0 100644 --- a/chain/events/events_height.go +++ b/chain/events/events_height.go @@ -47,7 +47,7 @@ func newHeightEvents(api EventAPI, obs *observer, gcConfidence abi.ChainEpoch) * // specified height+confidence threshold. If the chain is rolled-back under the // specified height, `RevertHandler` will be called. // -// ts passed to handlers is the tipset at the specified, or above, if lower tipsets were null +// ts passed to handlers is the tipset at the specified epoch, or above if lower tipsets were null. // // The context governs cancellations of this call, it won't cancel the event handler. func (e *heightEvents) ChainAt(ctx context.Context, hnd HeightHandler, rev RevertHandler, confidence int, h abi.ChainEpoch) error { diff --git a/itests/api_test.go b/itests/api_test.go index 9a21c9dfc..c380a6ed8 100644 --- a/itests/api_test.go +++ b/itests/api_test.go @@ -195,7 +195,7 @@ func (ts *apiSuite) testSlowNotify(t *testing.T) { full.WaitTillChain(ctx, kit.HeightAtLeast(baseHeight+100)) - // Make sure they were all closed. + // Make sure they were all closed, draining any buffered events first. for _, ch := range newHeadsChans { var ok bool for ok {