lighthouse/beacon_node/beacon_chain
Paul Hauner dd124b2d68 Address observed proposers behaviour (#4192)
## Issue Addressed

NA

## Proposed Changes

Apply two changes to code introduced in #4179:

1. Remove the `ERRO` log for when we error on `proposer_has_been_observed()`. We were seeing a lot of this in our logs for finalized blocks and it's a bit noisy.
1. Use `false` rather than `true` for `proposal_already_known` when there is an error. If a block raises an error in `proposer_has_been_observed()` then the block must be invalid, so we should process (and reject) it now rather than queuing it.

For reference, here is one of the offending `ERRO` logs:

```
ERRO Failed to check observed proposers block_root: 0x5845…878e, source: rpc, error: FinalizedBlock { slot: Slot(5410983), finalized_slot: Slot(5411232) }
```

## Additional Info

NA
2023-04-14 06:37:16 +00:00
..
src Address observed proposers behaviour (#4192) 2023-04-14 06:37:16 +00:00
tests Fork choice modifications and cleanup (#3962) 2023-03-21 07:34:41 +00:00
Cargo.toml Reconstruct Payloads using Payload Bodies Methods (#4028) 2023-03-19 23:15:59 +00:00