lighthouse/beacon_node
Paul Hauner dd124b2d68 Address observed proposers behaviour (#4192)
## Issue Addressed

NA

## Proposed Changes

Apply two changes to code introduced in #4179:

1. Remove the `ERRO` log for when we error on `proposer_has_been_observed()`. We were seeing a lot of this in our logs for finalized blocks and it's a bit noisy.
1. Use `false` rather than `true` for `proposal_already_known` when there is an error. If a block raises an error in `proposer_has_been_observed()` then the block must be invalid, so we should process (and reject) it now rather than queuing it.

For reference, here is one of the offending `ERRO` logs:

```
ERRO Failed to check observed proposers block_root: 0x5845…878e, source: rpc, error: FinalizedBlock { slot: Slot(5410983), finalized_slot: Slot(5411232) }
```

## Additional Info

NA
2023-04-14 06:37:16 +00:00
..
beacon_chain Address observed proposers behaviour (#4192) 2023-04-14 06:37:16 +00:00
builder_client Merge remote-tracking branch 'origin/unstable' into capella 2023-01-12 16:22:00 +11:00
client remove dup log (#4155) 2023-04-03 03:02:58 +00:00
eth1 exchangeCapabilities & Capella Readiness Logging (#3918) 2023-01-31 18:26:23 +01:00
execution_layer Reconstruct Payloads using Payload Bodies Methods (#4028) 2023-03-19 23:15:59 +00:00
genesis Fix the new BLS to execution change test 2023-01-25 15:47:07 +11:00
http_api Make re-org strat more cautious and add more config (#4151) 2023-04-13 07:05:01 +00:00
http_metrics Add content-type header to metrics server response (#3970) 2023-02-28 02:20:50 +00:00
lighthouse_network Add a flag to disable peer scoring (#4135) 2023-04-12 01:48:19 +00:00
network Address observed proposers behaviour (#4192) 2023-04-14 06:37:16 +00:00
operation_pool Use head state for exit verification (#4183) 2023-04-14 01:11:46 +00:00
src Make re-org strat more cautious and add more config (#4151) 2023-04-13 07:05:01 +00:00
store Remove Redundant Trait Bound (#4169) 2023-04-12 01:48:22 +00:00
tests Appease Clippy 1.68 and refactor http_api (#4068) 2023-03-13 01:40:03 +00:00
timer Use async code when interacting with EL (#3244) 2022-07-03 05:36:50 +00:00
Cargo.toml Release v4.0.1 (#4125) 2023-03-26 22:39:28 +00:00