renaming from ethermint to laconic #69

i-norden · 2022-12-14T12:06:19Z

0xmuralik commented

2022-12-14 12:06:19 +00:00

(Migrated from github.com)

Description

Changing variable names, chain id, import names etc from ethermint to laconic/laconicd.

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

## Description Changing variable names, chain id, import names etc from ethermint to laconic/laconicd. ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))

ashwinphatak (Migrated from github.com) reviewed 2022-12-14 12:06:19 +00:00

codecov-commenter commented

2022-12-14 12:17:41 +00:00

(Migrated from github.com)

Codecov Report

Merging #69 (fc60016) into main (75bcf1f) will not change coverage.
The diff coverage is 56.09%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   58.53%   58.53%           
=======================================
  Files         142      142           
  Lines       15615    15615           
=======================================
  Hits         9141     9141           
  Misses       6120     6120           
  Partials      354      354

Impacted Files	Coverage Δ
app/export.go	`12.92% <0.00%> (ø)`
client/config.go	`23.07% <0.00%> (ø)`
client/testnet.go	`0.00% <0.00%> (ø)`
rpc/backend/call_tx.go	`0.00% <0.00%> (ø)`
rpc/backend/chain_info.go	`10.05% <0.00%> (ø)`
rpc/backend/node_info.go	`0.00% <0.00%> (ø)`
rpc/backend/tx_info.go	`0.00% <0.00%> (ø)`
rpc/types/events.go	`71.85% <0.00%> (ø)`
app/app.go	`87.02% <39.13%> (ø)`
x/evm/genesis.go	`53.57% <50.00%> (ø)`
... and 15 more

# [Codecov](https://codecov.io/gh/cerc-io/laconicd/pull/69?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#69](https://codecov.io/gh/cerc-io/laconicd/pull/69?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (fc60016) into [main](https://codecov.io/gh/cerc-io/laconicd/commit/75bcf1f5a53040fffd724935279175f60f93785b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (75bcf1f) will **not change** coverage. > The diff coverage is `56.09%`. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://codecov.io/gh/cerc-io/laconicd/pull/69/graphs/tree.svg?width=650&height=150&src=pr&token=5tWmn7LxfO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/cerc-io/laconicd/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #69 +/- ## ======================================= Coverage 58.53% 58.53% ======================================= Files 142 142 Lines 15615 15615 ======================================= Hits 9141 9141 Misses 6120 6120 Partials 354 354 ``` | [Impacted Files](https://codecov.io/gh/cerc-io/laconicd/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [app/export.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL2V4cG9ydC5nbw==) | `12.92% <0.00%> (ø)` | | | [client/config.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xpZW50L2NvbmZpZy5nbw==) | `23.07% <0.00%> (ø)` | | | [client/testnet.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xpZW50L3Rlc3RuZXQuZ28=) | `0.00% <0.00%> (ø)` | | | [rpc/backend/call\_tx.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvY2FsbF90eC5nbw==) | `0.00% <0.00%> (ø)` | | | [rpc/backend/chain\_info.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvY2hhaW5faW5mby5nbw==) | `10.05% <0.00%> (ø)` | | | [rpc/backend/node\_info.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvbm9kZV9pbmZvLmdv) | `0.00% <0.00%> (ø)` | | | [rpc/backend/tx\_info.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvdHhfaW5mby5nbw==) | `0.00% <0.00%> (ø)` | | | [rpc/types/events.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL3R5cGVzL2V2ZW50cy5nbw==) | `71.85% <0.00%> (ø)` | | | [app/app.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL2FwcC5nbw==) | `87.02% <39.13%> (ø)` | | | [x/evm/genesis.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9ldm0vZ2VuZXNpcy5nbw==) | `53.57% <50.00%> (ø)` | | | ... and [15 more](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | </details>

i-norden reviewed 2022-12-16 17:20:52 +00:00

i-norden left a comment

Hey still seeing a fair number of instances of "ethermint" spread throughout, e.g. https://github.com/cerc-io/laconicd/blob/murali/minor-changes/app/ante/eip712.go#L29, https://github.com/cerc-io/laconicd/blob/main/.github/workflows/lint.yml#L2. I think the only place it makes sense to continue with their naming convention is for the CHANGELOG, the proto/etheremint types and all references to them, or anywhere where we do import a pkg from upstream ethermint (nowhere, currently).

Laconicd has five modules, 3 of those are our own and two are forked from ethermint. Besides the modules, the majority of the files in this repo (and in ethermint's) are the standard boilerplate forked and modified from cosmos-sdk. There is no reason to avoid rebranding those files. Now that we are using a stock version of the SDK (not using our SMT fork any longer), we could potentially use the upstream ethermint x/evm and x/feemarket modules but this requires some further discussion as it is entirely possible we will need to diverge again (and it has both negative and positive ramifications on maintenance).

Hey still seeing a fair number of instances of "ethermint" spread throughout, e.g. https://github.com/cerc-io/laconicd/blob/murali/minor-changes/app/ante/eip712.go#L29, https://github.com/cerc-io/laconicd/blob/main/.github/workflows/lint.yml#L2. I think the only place it makes sense to continue with their naming convention is for the CHANGELOG, the proto/etheremint types and all references to them, or anywhere where we do import a pkg from upstream ethermint (nowhere, currently). Laconicd has five modules, 3 of those are our own and two are forked from ethermint. Besides the modules, the majority of the files in this repo (and in ethermint's) are the standard boilerplate forked and modified from cosmos-sdk. There is no reason to avoid rebranding those files. Now that we are using a stock version of the SDK (not using our SMT fork any longer), we could potentially use the upstream ethermint `x/evm` and `x/feemarket` modules but this requires some further discussion as it is entirely possible we will need to diverge again (and it has both negative and positive ramifications on maintenance).

0xmuralik commented

2023-01-04 07:14:35 +00:00

(Migrated from github.com)

For ease of syncing up with the fork (evmos/ethermint), decided on only changing the chainID. https://github.com/cerc-io/laconicd/pull/73