replace CIDFromJSONBytes #97

Merged
0xmuralik merged 3 commits from murali/CIDFromJSONBytes into main 2023-03-14 05:51:23 +00:00
0xmuralik commented 2023-03-09 11:28:34 +00:00 (Migrated from github.com)

Closes: #83

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> Closes: #83 ## Description <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
ABastionOfSanity (Migrated from github.com) reviewed 2023-03-09 11:28:34 +00:00
codecov-commenter commented 2023-03-09 11:39:28 +00:00 (Migrated from github.com)

Codecov Report

Merging #97 (8932d69) into main (facd64a) will increase coverage by 0.01%.
The diff coverage is 75.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   66.38%   66.39%   +0.01%     
==========================================
  Files         148      148              
  Lines       16054    16051       -3     
==========================================
  Hits        10657    10657              
+ Misses       4920     4918       -2     
+ Partials      477      476       -1     
Impacted Files Coverage Δ
x/auction/keeper/keeper.go 41.32% <0.00%> (ø)
utils/json.go 61.66% <100.00%> (+2.93%) ⬆️
# [Codecov](https://codecov.io/gh/cerc-io/laconicd/pull/97?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#97](https://codecov.io/gh/cerc-io/laconicd/pull/97?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (8932d69) into [main](https://codecov.io/gh/cerc-io/laconicd/commit/facd64a14b60e5b979ade14d1fcac1d3a66646e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (facd64a) will **increase** coverage by `0.01%`. > The diff coverage is `75.00%`. :mega: This organization is not using Codecov’s [GitHub App Integration](https://github.com/apps/codecov). We recommend you install it so Codecov can continue to function properly for your repositories. [Learn more](https://about.codecov.io/blog/codecov-is-updating-its-github-integration/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://codecov.io/gh/cerc-io/laconicd/pull/97/graphs/tree.svg?width=650&height=150&src=pr&token=5tWmn7LxfO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/cerc-io/laconicd/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #97 +/- ## ========================================== + Coverage 66.38% 66.39% +0.01% ========================================== Files 148 148 Lines 16054 16051 -3 ========================================== Hits 10657 10657 + Misses 4920 4918 -2 + Partials 477 476 -1 ``` | [Impacted Files](https://codecov.io/gh/cerc-io/laconicd/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [x/auction/keeper/keeper.go](https://codecov.io/gh/cerc-io/laconicd/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9hdWN0aW9uL2tlZXBlci9rZWVwZXIuZ28=) | `41.32% <0.00%> (ø)` | | | [utils/json.go](https://codecov.io/gh/cerc-io/laconicd/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dXRpbHMvanNvbi5nbw==) | `61.66% <100.00%> (+2.93%)` | :arrow_up: | </details>
i-norden approved these changes 2023-03-09 15:08:28 +00:00
i-norden left a comment
Member

These changes LGTM and should not impact any interface, so should not impact either of laconic-sdk or laconic-registry-cli, so we can go ahead and merge this. Thanks!

These changes LGTM and should not impact any interface, so should not impact either of laconic-sdk or laconic-registry-cli, so we can go ahead and merge this. Thanks!
@ -67,3 +55,3 @@
}
// CIDFromJSONBytesUsingIpldPrime returns CID (dagcbor) for json (as bytes).
// CIDFromJSONBytes returns CID (dagcbor) for json (as bytes).
Member

Maybe we should shorten the name of this to CIDFromJSONBytes now that the name is available.

Maybe we should shorten the name of this to `CIDFromJSONBytes` now that the name is available.
aleem1314 (Migrated from github.com) approved these changes 2023-03-14 04:40:53 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#97
No description provided.