wrap typed data for record attributes #70

i-norden · 2022-12-19T09:44:40Z

0xmuralik commented

2022-12-19 09:44:40 +00:00

(Migrated from github.com)

Fix for https://github.com/cerc-io/laconic-sdk/issues/8

Description

See https://github.com/cerc-io/laconic-sdk/pull/15

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Fix for https://github.com/cerc-io/laconic-sdk/issues/8 ## Description See https://github.com/cerc-io/laconic-sdk/pull/15  ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))

i-norden reviewed 2022-12-19 09:44:40 +00:00

codecov-commenter commented

2022-12-27 07:04:05 +00:00

(Migrated from github.com)

Codecov Report

Merging #70 (6eeed3d) into main (75bcf1f) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   58.53%   58.43%   -0.11%     
==========================================
  Files         142      142              
  Lines       15615    15644      +29     
==========================================
  Hits         9141     9141              
- Misses       6120     6149      +29     
  Partials      354      354

Impacted Files	Coverage Δ
ethereum/eip712/eip712.go	`0.00% <0.00%> (ø)`

# [Codecov](https://codecov.io/gh/cerc-io/laconicd/pull/70?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#70](https://codecov.io/gh/cerc-io/laconicd/pull/70?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (6eeed3d) into [main](https://codecov.io/gh/cerc-io/laconicd/commit/75bcf1f5a53040fffd724935279175f60f93785b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (75bcf1f) will **decrease** coverage by `0.10%`. > The diff coverage is `0.00%`. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://codecov.io/gh/cerc-io/laconicd/pull/70/graphs/tree.svg?width=650&height=150&src=pr&token=5tWmn7LxfO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/cerc-io/laconicd/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #70 +/- ## ========================================== - Coverage 58.53% 58.43% -0.11% ========================================== Files 142 142 Lines 15615 15644 +29 ========================================== Hits 9141 9141 - Misses 6120 6149 +29 Partials 354 354 ``` | [Impacted Files](https://codecov.io/gh/cerc-io/laconicd/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [ethereum/eip712/eip712.go](https://codecov.io/gh/cerc-io/laconicd/pull/70/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vZWlwNzEyL2VpcDcxMi5nbw==) | `0.00% <0.00%> (ø)` | | </details>

0xmuralik commented

2023-01-09 06:48:42 +00:00

(Migrated from github.com)

All sdk tests pass and merging this now.

Sign in to join this conversation.

No reviewers