cerc-io/laconicd-deprecated
13
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

renaming from ethermint to laconic #69

Closed
0xmuralik wants to merge 3 commits from murali/minor-changes into main
pull from: murali/minor-changes
merge into: :main
Conversation 4 Commits 3 Files Changed 88
+323 -323
0xmuralik commented 2022-12-14 12:06:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Description

Changing variable names, chain id, import names etc from ethermint to laconic/laconicd.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
## Description Changing variable names, chain id, import names etc from ethermint to laconic/laconicd. ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
ashwinphatak (Migrated from github.com) reviewed 2022-12-14 12:06:19 +00:00
codecov-commenter commented 2022-12-14 12:17:41 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Codecov Report

Merging #69 (fc60016) into main (75bcf1f) will not change coverage.
The diff coverage is 56.09%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   58.53%   58.53%           
=======================================
  Files         142      142           
  Lines       15615    15615           
=======================================
  Hits         9141     9141           
  Misses       6120     6120           
  Partials      354      354
Impacted Files Coverage Δ
app/export.go 12.92% <0.00%> (ø)
client/config.go 23.07% <0.00%> (ø)
client/testnet.go 0.00% <0.00%> (ø)
rpc/backend/call_tx.go 0.00% <0.00%> (ø)
rpc/backend/chain_info.go 10.05% <0.00%> (ø)
rpc/backend/node_info.go 0.00% <0.00%> (ø)
rpc/backend/tx_info.go 0.00% <0.00%> (ø)
rpc/types/events.go 71.85% <0.00%> (ø)
app/app.go 87.02% <39.13%> (ø)
x/evm/genesis.go 53.57% <50.00%> (ø)
... and 15 more
# [Codecov](https://codecov.io/gh/cerc-io/laconicd/pull/69?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#69](https://codecov.io/gh/cerc-io/laconicd/pull/69?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (fc60016) into [main](https://codecov.io/gh/cerc-io/laconicd/commit/75bcf1f5a53040fffd724935279175f60f93785b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (75bcf1f) will **not change** coverage. > The diff coverage is `56.09%`. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://codecov.io/gh/cerc-io/laconicd/pull/69/graphs/tree.svg?width=650&height=150&src=pr&token=5tWmn7LxfO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/cerc-io/laconicd/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #69 +/- ## ======================================= Coverage 58.53% 58.53% ======================================= Files 142 142 Lines 15615 15615 ======================================= Hits 9141 9141 Misses 6120 6120 Partials 354 354 ``` | [Impacted Files](https://codecov.io/gh/cerc-io/laconicd/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [app/export.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL2V4cG9ydC5nbw==) | `12.92% <0.00%> (ø)` | | | [client/config.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xpZW50L2NvbmZpZy5nbw==) | `23.07% <0.00%> (ø)` | | | [client/testnet.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xpZW50L3Rlc3RuZXQuZ28=) | `0.00% <0.00%> (ø)` | | | [rpc/backend/call\_tx.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvY2FsbF90eC5nbw==) | `0.00% <0.00%> (ø)` | | | [rpc/backend/chain\_info.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvY2hhaW5faW5mby5nbw==) | `10.05% <0.00%> (ø)` | | | [rpc/backend/node\_info.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvbm9kZV9pbmZvLmdv) | `0.00% <0.00%> (ø)` | | | [rpc/backend/tx\_info.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvdHhfaW5mby5nbw==) | `0.00% <0.00%> (ø)` | | | [rpc/types/events.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL3R5cGVzL2V2ZW50cy5nbw==) | `71.85% <0.00%> (ø)` | | | [app/app.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL2FwcC5nbw==) | `87.02% <39.13%> (ø)` | | | [x/evm/genesis.go](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9ldm0vZ2VuZXNpcy5nbw==) | `53.57% <50.00%> (ø)` | | | ... and [15 more](https://codecov.io/gh/cerc-io/laconicd/pull/69/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | </details>
i-norden left a comment
Member
Copy Link
Copy Source

Hey still seeing a fair number of instances of "ethermint" spread throughout, e.g. https://github.com/cerc-io/laconicd/blob/murali/minor-changes/app/ante/eip712.go#L29, https://github.com/cerc-io/laconicd/blob/main/.github/workflows/lint.yml#L2. I think the only place it makes sense to continue with their naming convention is for the CHANGELOG, the proto/etheremint types and all references to them, or anywhere where we do import a pkg from upstream ethermint (nowhere, currently).

Laconicd has five modules, 3 of those are our own and two are forked from ethermint. Besides the modules, the majority of the files in this repo (and in ethermint's) are the standard boilerplate forked and modified from cosmos-sdk. There is no reason to avoid rebranding those files. Now that we are using a stock version of the SDK (not using our SMT fork any longer), we could potentially use the upstream ethermint x/evm and x/feemarket modules but this requires some further discussion as it is entirely possible we will need to diverge again (and it has both negative and positive ramifications on maintenance).

Hey still seeing a fair number of instances of "ethermint" spread throughout, e.g. https://github.com/cerc-io/laconicd/blob/murali/minor-changes/app/ante/eip712.go#L29, https://github.com/cerc-io/laconicd/blob/main/.github/workflows/lint.yml#L2. I think the only place it makes sense to continue with their naming convention is for the CHANGELOG, the proto/etheremint types and all references to them, or anywhere where we do import a pkg from upstream ethermint (nowhere, currently). Laconicd has five modules, 3 of those are our own and two are forked from ethermint. Besides the modules, the majority of the files in this repo (and in ethermint's) are the standard boilerplate forked and modified from cosmos-sdk. There is no reason to avoid rebranding those files. Now that we are using a stock version of the SDK (not using our SMT fork any longer), we could potentially use the upstream ethermint `x/evm` and `x/feemarket` modules but this requires some further discussion as it is entirely possible we will need to diverge again (and it has both negative and positive ramifications on maintenance).
0xmuralik commented 2023-01-04 07:14:35 +00:00 (Migrated from github.com)
Copy Link
Copy Source

For ease of syncing up with the fork (evmos/ethermint), decided on only changing the chainID. https://github.com/cerc-io/laconicd/pull/73

For ease of syncing up with the fork (evmos/ethermint), decided on only changing the chainID. https://github.com/cerc-io/laconicd/pull/73

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
ashwinphatak
Labels
Clear labels
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update Docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 go
Pull requests that update Go code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 high priority
in progress
currently working on
 invalid
This doesn't seem right
 javascript
Pull requests that update Javascript code
 low priority
medium priority
question
Further information is requested
 urgent
Top priority issue
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels C:CLI C:Crypto C:Encoding C:Types Type: Build Type: Tests
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) iskay prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#69