cerc-io/laconicd-deprecated
13
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

update to cerc-io/laconicd #35

Merged
0xmuralik merged 4 commits from murali/#32 into main 2022-09-09 06:27:20 +00:00
Conversation 7 Commits 4 Files Changed 262
+2477 -2451
0xmuralik commented 2022-09-07 07:30:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closes: #32

Description

Update package names, dependencies and docker/ReadMe files to match with cerc-io/laconicd

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
Closes: #32 ## Description Update package names, dependencies and docker/ReadMe files to match with cerc-io/laconicd ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
ashwinphatak (Migrated from github.com) reviewed 2022-09-07 07:30:16 +00:00
anilCSE (Migrated from github.com) reviewed 2022-09-07 07:30:16 +00:00
gsk967 (Migrated from github.com) reviewed 2022-09-07 07:30:16 +00:00
i-norden left a comment
Member
Copy Link
Copy Source

LGTM, thanks for prioritizing this last minute. Looks like linting is still failing but that is being addressed in another PR. Gosec is also failing and I'm not sure if that is some weird non-deterministic finickiness or something else (error seems to be "[gosec] 2022/09/07 11:48:49 strconv.ParseUint: parsing "64-69": invalid syntax"), if you can look into that before merging this that would be great.

And there has been some back-and-forth discussion about what to name this repo but let's stick with laconicd for now and if we need to change it later on we can.

LGTM, thanks for prioritizing this last minute. Looks like linting is still failing but that is being addressed in another PR. Gosec is also failing and I'm not sure if that is some weird non-deterministic finickiness or something else (error seems to be "[gosec] 2022/09/07 11:48:49 strconv.ParseUint: parsing "64-69": invalid syntax"), if you can look into that before merging this that would be great. And there has been some back-and-forth discussion about what to name this repo but let's stick with laconicd for now and if we need to change it later on we can.
0xmuralik (Migrated from github.com) reviewed 2022-09-08 06:25:13 +00:00
rpc/ethereum/backend/backend.go
@@ -133,3 +133,3 @@
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 64)
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 63)
if err != nil {
0xmuralik (Migrated from github.com) commented 2022-09-08 06:25:13 +00:00
Copy Link
Copy Source

See https://github.com/cosmos/gosec/tree/master/rules/sdk#strconv-unsigned-integers-cast-to-signed-integers-overflow

See https://github.com/cosmos/gosec/tree/master/rules/sdk#strconv-unsigned-integers-cast-to-signed-integers-overflow
0xmuralik commented 2022-09-08 06:28:05 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Still Failing after adding the change: https://github.com/cerc-io/laconicd/pull/35/files/9c49c2b934b08ceff409d3dcc08ee13b5606148e..9e014725b8bf486c3ab62e67191c370fc03a1952#diff-7f75fec163267a96892043b684f88d495897981a15943b06e4b11e5458c62b8c

Gosec rule for parsing intergers: https://github.com/cosmos/gosec/tree/master/rules/sdk#strconv-unsigned-integers-cast-to-signed-integers-overflow

Still Failing after adding the change: https://github.com/cerc-io/laconicd/pull/35/files/9c49c2b934b08ceff409d3dcc08ee13b5606148e..9e014725b8bf486c3ab62e67191c370fc03a1952#diff-7f75fec163267a96892043b684f88d495897981a15943b06e4b11e5458c62b8c Gosec rule for parsing intergers: https://github.com/cosmos/gosec/tree/master/rules/sdk#strconv-unsigned-integers-cast-to-signed-integers-overflow
i-norden approved these changes 2022-09-08 20:58:39 +00:00
rpc/ethereum/backend/backend.go
@@ -133,3 +133,3 @@
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 64)
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 63)
if err != nil {
i-norden commented 2022-09-08 20:58:35 +00:00
Member
Copy Link
Copy Source

That's odd, thanks for checking. Let's just take note of this for now and move on.

That's odd, thanks for checking. Let's just take note of this for now and move on.
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
gsk967
ashwinphatak
anilCSE
0xmuralik
Labels
Clear labels
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update Docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 go
Pull requests that update Go code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 high priority
in progress
currently working on
 invalid
This doesn't seem right
 javascript
Pull requests that update Javascript code
 low priority
medium priority
question
Further information is requested
 urgent
Top priority issue
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels C:CLI C:Crypto C:Encoding C:Proto C:Types Type: Build Type: Docs Type: Tests
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) iskay prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#35