cerc-io/laconicd-deprecated
13
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Clean up test suite #134

Merged
ashwin merged 10 commits from deep-stack/laconicd-deprecated:pm-qol-improvements into main 2024-01-22 10:27:09 +00:00
Conversation 5 Commits 10 Files Changed 22
+193 -381
prathamesh commented 2024-01-15 08:39:33 +00:00
Member
Copy Link
Copy Source

This attempts to simplify tests, and make them generally more usable:

  • simplifies CI jobs
  • makefile tweaks, init.sh clean up
  • small dockerfile, compose, etc. improvements
  • removes sdk-tester dockerfile, the sdk repo has it
  • removes redundant test scripts, improve run-tests
  • simplifies and removes redundant logic in test suite. covers ignored errors
  • adds logging context, doc updates
This attempts to simplify tests, and make them generally more usable: - simplifies CI jobs - makefile tweaks, init.sh clean up - small dockerfile, compose, etc. improvements - removes sdk-tester dockerfile, the sdk repo has it - removes redundant test scripts, improve run-tests - simplifies and removes redundant logic in test suite. covers ignored errors - adds logging context, doc updates
prathamesh added 6 commits 2024-01-15 08:39:34 +00:00
test improvements 4c2a0ed144 
handle request errors

rm cruft

test logging

cleanup test script
build cleanup 156b1dce35 
docker ignore

dockerfile cleanup

clean up init script

forward LOGLEVEL
let user build sdk-tester image 3287c5ff9e
dockerfile caching e9d75785c5
tests: use :local image tag f6cbf5cc6b
dockerignore
Build / cleanup-runs (pull_request) Has been cancelled
Details
Build / build (pull_request) Has been cancelled
Details
Pull Request Labeler / triage (pull_request) Has been cancelled
Details
Lint / Run golangci-lint (pull_request) Has been cancelled
Details
Lint / Run flake8 on python integration tests (pull_request) Has been cancelled
Details
CodeQL / Analyze (go) (pull_request) Has been cancelled
Details
Dependency Review / dependency-review (pull_request) Has been cancelled
Details
Deploy Contract / cleanup-runs (pull_request) Has been cancelled
Details
Deploy Contract / deploy (pull_request) Has been cancelled
Details
Protobuf / lint (pull_request) Has been cancelled
Details
Protobuf / break-check (pull_request) Has been cancelled
Details
Run Gosec / Gosec (pull_request) Has been cancelled
Details
Semgrep / Scan (pull_request) Has been cancelled
Details
Tests / cleanup-runs (pull_request) Has been cancelled
Details
Tests / test-unit-cover (pull_request) Has been cancelled
Details
Tests / test-importer (pull_request) Has been cancelled
Details
Tests / test-rpc (pull_request) Has been cancelled
Details
Tests / sdk_tests (pull_request) Has been cancelled
Details
eb2cf63324
prathamesh marked the pull request as work in progress 2024-01-15 08:51:29 +00:00
prathamesh added 1 commit 2024-01-16 09:05:02 +00:00
Fix SDK test CI workflow
Build / cleanup-runs (pull_request) Has been cancelled
Details
Build / build (pull_request) Has been cancelled
Details
Run Gosec / Gosec (pull_request) Has been cancelled
Details
CodeQL / Analyze (go) (pull_request) Has been cancelled
Details
Dependency Review / dependency-review (pull_request) Has been cancelled
Details
Deploy Contract / cleanup-runs (pull_request) Has been cancelled
Details
Deploy Contract / deploy (pull_request) Has been cancelled
Details
Pull Request Labeler / triage (pull_request) Has been cancelled
Details
Lint / Run golangci-lint (pull_request) Has been cancelled
Details
Lint / Run flake8 on python integration tests (pull_request) Has been cancelled
Details
Protobuf / lint (pull_request) Has been cancelled
Details
Protobuf / break-check (pull_request) Has been cancelled
Details
Semgrep / Scan (pull_request) Has been cancelled
Details
Tests / cleanup-runs (pull_request) Has been cancelled
Details
Tests / test-unit-cover (pull_request) Has been cancelled
Details
Tests / test-importer (pull_request) Has been cancelled
Details
Tests / test-rpc (pull_request) Has been cancelled
Details
Tests / sdk_tests (pull_request) Has been cancelled
Details
0619d7e3d3
prathamesh marked the pull request as ready for review 2024-01-16 12:17:30 +00:00
ashwin requested review from telackey 2024-01-16 12:22:22 +00:00
.github/workflows/test.yml Outdated
@@ -60,3 +60,3 @@
make test-import
if: env.GIT_DIFF
telackey commented 2024-01-16 18:19:38 +00:00
Contributor
Copy Link
Copy Source

Since the primary repo is in Gitea, two quick questions:

  1. Are these CI jobs passing under Gitea actions?
  2. If not, what do we need to do to make them pass there as well?
Since the primary repo is in Gitea, two quick questions: 1. Are these CI jobs passing under Gitea actions? 2. If not, what do we need to do to make them pass there as well?
prathamesh commented 2024-01-17 06:15:01 +00:00
Author
Member
Copy Link
Copy Source

Are these CI jobs passing under Gitea actions?

No, these jobs in the CI are coming from upstream repo where they were setup for GitHub.

If not, what do we need to do to make them pass there as well?

Needs more investigation as Gitea CI / actions runner doesn't seem to be compatible with that in GitHub.
But they do run on GitHub post sync after a PR gets merged (to main) as they are configured to run on push to main as well.
The CI has been failing on Gitea for a while.

> Are these CI jobs passing under Gitea actions? No, these jobs in the CI are coming from upstream repo where they were setup for GitHub. > If not, what do we need to do to make them pass there as well? Needs more investigation as Gitea CI / actions runner doesn't seem to be compatible with that in GitHub. But they do run on GitHub post sync after a PR gets merged (to main) as they are configured to run on push to main as well. The CI has been failing on Gitea for a while.
telackey commented 2024-01-18 18:48:31 +00:00
Contributor
Copy Link
Copy Source

We have an issue open here:

cerc-io/laconicd#116

And on the merge previous to the new protobuf changes we had these passing in Gitea:

  • Pull Request Labeler / triage (push) Successful in 6s
  • Run Gosec / Gosec (push) Successful in 23s
  • Lint / Run golangci-lint (push) Successful in 1m32s
  • CodeQL / Analyze (go) (push) Successful in 1m37s
  • Tests / test-unit-cover (push) Successful in 1m43s
  • Tests / test-importer (push) Successful in 1m23s
  • Tests / test-rpc (push) Successful in 1m28s

I think it makes sense, especially as Gitea is our upstream now, that on the way to resolving #116, we at least make sure that was passing continues to pass.

We have an issue open here: https://git.vdb.to/cerc-io/laconicd/issues/116 And on the merge previous to the new protobuf changes we had these passing in Gitea: - Pull Request Labeler / triage (push) Successful in 6s - Run Gosec / Gosec (push) Successful in 23s - Lint / Run golangci-lint (push) Successful in 1m32s - CodeQL / Analyze (go) (push) Successful in 1m37s - Tests / test-unit-cover (push) Successful in 1m43s - Tests / test-importer (push) Successful in 1m23s - Tests / test-rpc (push) Successful in 1m28s I think it makes sense, especially as Gitea is our upstream now, that on the way to resolving #116, we at least make sure that was passing continues to pass.
x/registry/keeper/msg_server.go
@@ -30,3 +28,1 @@
Signer: msg.GetSigner(),
Payload: msg.GetPayload(),
})
record, err := m.Keeper.ProcessSetRecord(ctx, *msg)
telackey commented 2024-01-16 18:17:05 +00:00
Contributor
Copy Link
Copy Source

The changes to this file look fine, but I'm not sure how they are related to test cleanup.

The changes to this file look fine, but I'm not sure how they are related to test cleanup.
prathamesh commented 2024-01-17 06:16:04 +00:00
Author
Member
Copy Link
Copy Source

The changes to this file look fine, but I'm not sure how they are related to test cleanup.

Cleanup change coming from original PR cerc-io/laconicd#111.

> The changes to this file look fine, but I'm not sure how they are related to test cleanup. Cleanup change coming from original PR https://git.vdb.to/cerc-io/laconicd/pulls/111.
telackey commented 2024-01-18 18:43:08 +00:00
Contributor
Copy Link
Copy Source

I think the same question applies, but it may not be worth splitting out into a separate PR.

I think the same question applies, but it may not be worth splitting out into a separate PR.
telackey commented 2024-01-18 18:57:28 +00:00
Contributor
Copy Link
Copy Source

One option (and the same goes for cerc-io/laconic-sdk#53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR.

Sound reasonable?

One option (and the same goes for https://git.vdb.to/cerc-io/laconic-sdk/pulls/53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR. Sound reasonable?
telackey approved these changes 2024-01-18 18:58:33 +00:00
prathamesh added 1 commit 2024-01-19 05:37:23 +00:00
Fix lint errors
Tests / test-unit-cover (pull_request) Has been cancelled
Details
Tests / test-importer (pull_request) Has been cancelled
Details
Tests / test-rpc (pull_request) Has been cancelled
Details
Tests / sdk_tests (pull_request) Has been cancelled
Details
Build / cleanup-runs (pull_request) Has been cancelled
Details
Build / build (pull_request) Has been cancelled
Details
CodeQL / Analyze (go) (pull_request) Has been cancelled
Details
Dependency Review / dependency-review (pull_request) Has been cancelled
Details
Deploy Contract / cleanup-runs (pull_request) Has been cancelled
Details
Deploy Contract / deploy (pull_request) Has been cancelled
Details
Pull Request Labeler / triage (pull_request) Has been cancelled
Details
Lint / Run golangci-lint (pull_request) Has been cancelled
Details
Lint / Run flake8 on python integration tests (pull_request) Has been cancelled
Details
Protobuf / lint (pull_request) Has been cancelled
Details
Protobuf / break-check (pull_request) Has been cancelled
Details
Run Gosec / Gosec (pull_request) Has been cancelled
Details
Semgrep / Scan (pull_request) Has been cancelled
Details
Tests / cleanup-runs (pull_request) Has been cancelled
Details
467be48baf
prathamesh added 1 commit 2024-01-22 04:59:59 +00:00
Add comment to test CI
Build / cleanup-runs (pull_request) Successful in 15s
Details
Build / build (pull_request) Successful in 1m12s
Details
Dependency Review / dependency-review (pull_request) Successful in 1m14s
Details
Deploy Contract / cleanup-runs (pull_request) Successful in 6s
Details
CodeQL / Analyze (go) (pull_request) Successful in 2m57s
Details
Deploy Contract / deploy (pull_request) Failing after 56s
Details
Pull Request Labeler / triage (pull_request) Failing after 19s
Details
Lint / Run golangci-lint (pull_request) Successful in 2m24s
Details
Lint / Run flake8 on python integration tests (pull_request) Failing after 2m23s
Details
Protobuf / lint (pull_request) Successful in 22s
Details
Protobuf / break-check (pull_request) Failing after 31s
Details
Run Gosec / Gosec (pull_request) Successful in 1m12s
Details
Semgrep / Scan (pull_request) Failing after 1m28s
Details
Tests / cleanup-runs (pull_request) Failing after 3s
Details
Tests / test-unit-cover (pull_request) Successful in 1m24s
Details
Tests / test-rpc (pull_request) Successful in 1m29s
Details
Tests / test-importer (pull_request) Successful in 1m33s
Details
Tests / sdk_tests (pull_request) Failing after 13m46s
Details
ab969e20bf
prathamesh commented 2024-01-22 09:08:15 +00:00
Author
Member
Copy Link
Copy Source

One option (and the same goes for cerc-io/laconic-sdk#53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR.

Created an issue to track this: cerc-io/laconic-sdk#54

> One option (and the same goes for cerc-io/laconic-sdk#53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR. Created an issue to track this: https://git.vdb.to/cerc-io/laconic-sdk/issues/54
prathamesh added 1 commit 2024-01-22 09:21:22 +00:00
Remove unnecessary comments
Build / cleanup-runs (pull_request) Successful in 7s
Details
Deploy Contract / cleanup-runs (pull_request) Successful in 6s
Details
Deploy Contract / deploy (pull_request) Failing after 39s
Details
Build / build (pull_request) Successful in 59s
Details
Pull Request Labeler / triage (pull_request) Failing after 15s
Details
CodeQL / Analyze (go) (pull_request) Successful in 1m46s
Details
Protobuf / lint (pull_request) Successful in 46s
Details
Dependency Review / dependency-review (pull_request) Successful in 2m30s
Details
Protobuf / break-check (pull_request) Failing after 22s
Details
Lint / Run golangci-lint (pull_request) Successful in 2m19s
Details
Lint / Run flake8 on python integration tests (pull_request) Failing after 2m15s
Details
Run Gosec / Gosec (pull_request) Successful in 46s
Details
Tests / cleanup-runs (pull_request) Successful in 5s
Details
Semgrep / Scan (pull_request) Failing after 28s
Details
Tests / test-importer (pull_request) Successful in 51s
Details
Tests / test-unit-cover (pull_request) Successful in 1m38s
Details
Tests / test-rpc (pull_request) Successful in 1m36s
Details
Tests / sdk_tests (pull_request) Failing after 11m33s
Details
8b7162b228
ashwin merged commit 055cfb2255 into main 2024-01-22 10:27:09 +00:00
ashwin deleted branch pm-qol-improvements 2024-01-22 10:27:09 +00:00
ashwin referenced this issue from a commit 2024-01-22 10:27:11 +00:00
Clean up test suite (#134)
Dockerfile
@@ -29,2 +28,3 @@
WORKDIR /
# Run laconicd by default
CMD ["laconicd"]
ENTRYPOINT ["laconicd"]
dboreham commented 2024-01-22 13:06:58 +00:00
Contributor
Copy Link
Copy Source

Curious about why this change was needed. It broke stack orchestrator's use of laconicd, for example.

Curious about why this change was needed. It broke stack orchestrator's use of laconicd, for example.
Sign in to join this conversation.
Reviewers
No Reviewers
telackey
dboreham
Labels
Clear labels
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update Docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 go
Pull requests that update Go code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 high priority
in progress
currently working on
 invalid
This doesn't seem right
 javascript
Pull requests that update Javascript code
 low priority
medium priority
question
Further information is requested
 urgent
Top priority issue
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) iskay prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#134