cerc-io/laconicd-deprecated
19
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Remove hard-coded record types #110

Closed
roysc wants to merge 3 commits from roy/rm-hardcoded-records into main
pull from: roy/rm-hardcoded-records
merge into: cerc-io:main
Conversation 2 Commits 3 Files Changed 22 +417 -1916
roysc commented 2023-09-25 12:36:30 +00:00
Owner
Copy Link
  • Refactors the Record.Attributes from Any into a byte string and removes the hard-coded Protobuf record types.
  • Fixes EIP-712 bytes decoding.

Companion SDK PR: cerc-io/laconic-sdk#41

Resolves cerc-io/laconicd#107 and is initial work on cerc-io/laconicd#108

- Refactors the `Record.Attributes` from Any into a byte string and removes the hard-coded Protobuf record types. - Fixes EIP-712 bytes decoding. Companion SDK PR: https://git.vdb.to/cerc-io/laconic-sdk/pulls/41 Resolves https://git.vdb.to/cerc-io/laconicd/issues/107 and is initial work on https://git.vdb.to/cerc-io/laconicd/issues/108
roysc added 1 commit 2023-09-25 12:36:32 +00:00 
rename types for clarity
roysc changed title from remove hard-coded record types, fix EIP-712 decoding to Remove hard-coded record types 2023-09-25 12:37:15 +00:00
roysc requested review from dboreham 2023-09-25 12:37:47 +00:00
roysc added 2 commits 2023-11-28 00:34:40 +00:00 
this matches the change in follow up PR branch `graphql-to-ipld`
rm confusing comments
Some checks failed
Build / cleanup-runs (pull_request) Failing after 2s
Details
Deploy Contract / cleanup-runs (pull_request) Failing after 3s
Details
Dependency Review / dependency-review (pull_request) Successful in 1m1s
Details
Deploy Contract / deploy (pull_request) Failing after 56s
Details
Pull Request Labeler / triage (pull_request) Failing after 3s
Details
Build / build (pull_request) Successful in 1m11s
Details
Lint / Run flake8 on python integration tests (pull_request) Failing after 32s
Details
Protobuf / lint (pull_request) Failing after 28s
Details
Lint / Run golangci-lint (pull_request) Successful in 43s
Details
Semgrep / Scan (pull_request) Failing after 11s
Details
Tests / cleanup-runs (pull_request) Failing after 2s
Details
Protobuf / break-check (pull_request) Failing after 20s
Details
Run Gosec / Gosec (pull_request) Successful in 25s
Details
Tests / test-importer (pull_request) Successful in 1m9s
Details
Tests / test-unit-cover (pull_request) Successful in 1m10s
Details
Tests / test-rpc (pull_request) Successful in 1m12s
Details
CodeQL / Analyze (go) (pull_request) Successful in 3m41s
Details
Tests / sdk_tests (pull_request) Failing after 1m40s
Details
e173f0a321
roysc commented 2023-12-02 13:51:01 +00:00
Author
Owner
Copy Link

Also partial progress on cerc-io/laconicd#108

Also partial progress on https://git.vdb.to/cerc-io/laconicd/issues/108
ashwin commented 2024-01-15 04:21:40 +00:00
Member
Copy Link

Superseded by cerc-io/laconicd#132

Superseded by https://git.vdb.to/cerc-io/laconicd/pulls/132
ashwin closed this pull request 2024-01-15 04:21:41 +00:00
Some checks failed
Build / cleanup-runs (pull_request) Failing after 2s
Details
Deploy Contract / cleanup-runs (pull_request) Failing after 3s
Details
Dependency Review / dependency-review (pull_request) Successful in 1m1s
Details
Deploy Contract / deploy (pull_request) Failing after 56s
Details
Pull Request Labeler / triage (pull_request) Failing after 3s
Details
Build / build (pull_request) Successful in 1m11s
Details
Lint / Run flake8 on python integration tests (pull_request) Failing after 32s
Details
Protobuf / lint (pull_request) Failing after 28s
Details
Lint / Run golangci-lint (pull_request) Successful in 43s
Details
Semgrep / Scan (pull_request) Failing after 11s
Details
Tests / cleanup-runs (pull_request) Failing after 2s
Details
Protobuf / break-check (pull_request) Failing after 20s
Details
Run Gosec / Gosec (pull_request) Successful in 25s
Details
Tests / test-importer (pull_request) Successful in 1m9s
Details
Tests / test-unit-cover (pull_request) Successful in 1m10s
Details
Tests / test-rpc (pull_request) Successful in 1m12s
Details
CodeQL / Analyze (go) (pull_request) Successful in 3m41s
Details
Tests / sdk_tests (pull_request) Failing after 1m40s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
dboreham
Labels
Clear labels   
bug

Something isn't working

  
C:CLI

   
C:Crypto

   
C:Encoding

   
C:Proto

   
C:Types

   
dependencies

Pull requests that update a dependency file

  
docker

Pull requests that update Docker code

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
go

Pull requests that update Go code

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
high priority

   
in progress

currently working on

  
invalid

This doesn't seem right

  
javascript

Pull requests that update Javascript code

  
low priority

   
medium priority

   
question

Further information is requested

  
Status: Stale

   
Type: ADR

   
Type: Build

   
Type: CI

   
Type: Docs

   
Type: Tests

   
urgent

Top priority issue

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
dependencies
docker
documentation
duplicate
enhancement
go
good first issue
help wanted
high priority
in progress
invalid
javascript
low priority
medium priority
question
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
urgent
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#110
No description provided.
Delete Branch "roy/rm-hardcoded-records"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?