cerc-io/laconicd-deprecated
13
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

upgrade IPLD prime #102

Merged
0xmuralik merged 7 commits from murali/ipld-prime into main 2023-03-22 13:43:52 +00:00
Conversation 8 Commits 7 Files Changed 3
+10 -7
0xmuralik commented 2023-03-15 10:24:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closes: #96

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> Closes: #96 ## Description <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
ABastionOfSanity (Migrated from github.com) reviewed 2023-03-15 10:24:01 +00:00
aleem1314 (Migrated from github.com) reviewed 2023-03-15 10:24:01 +00:00
i-norden approved these changes 2023-03-17 17:36:31 +00:00
i-norden left a comment
Member
Copy Link
Copy Source

This LGTM but want @zramsay's final approval.

This LGTM but want @zramsay's final approval.
.semgrepignore
@@ -20,2 +20,4 @@
*_test.go
# false positive; TODO: https://github.com/cerc-io/laconicd/issues/104
testutil/network/network.go
zramsay commented 2023-03-17 17:42:59 +00:00
Member
Copy Link
Copy Source

Can you provide context for this? AFAICT tests were passing in the previous commit
I'd prefer to not ignore tests.

Can you provide context for this? AFAICT tests were passing in the previous commit I'd prefer to not ignore tests.
0xmuralik (Migrated from github.com) reviewed 2023-03-17 19:15:29 +00:00
.semgrepignore
@@ -20,2 +20,4 @@
*_test.go
# false positive; TODO: https://github.com/cerc-io/laconicd/issues/104
testutil/network/network.go
0xmuralik (Migrated from github.com) commented 2023-03-17 19:15:29 +00:00
Copy Link
Copy Source

https://github.com/cerc-io/laconicd/runs/12015779774
Weirdly, this check fails only sometimes.

https://github.com/cerc-io/laconicd/runs/12015779774 Weirdly, this check fails only sometimes.
.semgrepignore
@@ -20,2 +20,4 @@
*_test.go
# false positive; TODO: https://github.com/cerc-io/laconicd/issues/104
testutil/network/network.go
zramsay commented 2023-03-18 00:00:14 +00:00
Member
Copy Link
Copy Source

#104
please change line 22 to # false positive; TODO: https://github.com/cerc-io/laconicd/issues/104
then feel free to merge

#104 please change line 22 to `# false positive; TODO: https://github.com/cerc-io/laconicd/issues/104` then feel free to merge
zramsay approved these changes 2023-03-18 00:00:26 +00:00
0xmuralik commented 2023-03-20 10:19:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@zramsay any thoughts on the failing check?

@zramsay any thoughts on the failing check?
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
zramsay
ABastionOfSanity
aleem1314
0xmuralik
Labels
Clear labels
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update Docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 go
Pull requests that update Go code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 high priority
in progress
currently working on
 invalid
This doesn't seem right
 javascript
Pull requests that update Javascript code
 low priority
medium priority
question
Further information is requested
 urgent
Top priority issue
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) iskay prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#102