chore: fix lint errors #100

Closed
aleem1314 wants to merge 4 commits from aleem/fix-lint-errors into main
aleem1314 commented 2023-03-14 05:35:55 +00:00 (Migrated from github.com)

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> Closes: #XXX ## Description <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
codecov-commenter commented 2023-03-14 05:48:00 +00:00 (Migrated from github.com)

Codecov Report

Merging #100 (ddd01cc) into main (facd64a) will increase coverage by 0.01%.
The diff coverage is 9.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   66.38%   66.39%   +0.01%     
==========================================
  Files         148      148              
  Lines       16054    16051       -3     
==========================================
  Hits        10657    10657              
+ Misses       4920     4918       -2     
+ Partials      477      476       -1     
Impacted Files Coverage Δ
x/auction/keeper/keeper.go 41.32% <0.00%> (ø)
x/bond/keeper/keeper.go 44.54% <0.00%> (ø)
x/registry/keeper/keeper.go 48.92% <0.00%> (ø)
x/registry/keeper/naming_keeper.go 13.80% <0.00%> (ø)
x/registry/keeper/record_keeper.go 11.05% <0.00%> (ø)
x/registry/keeper/grpc_query.go 52.77% <25.00%> (ø)
x/auction/keeper/grpc_query.go 94.00% <83.33%> (ø)
x/bond/keeper/grpc_query.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

## [Codecov](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#100](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (ddd01cc) into [main](https://codecov.io/gh/cerc-io/laconicd/commit/facd64a14b60e5b979ade14d1fcac1d3a66646e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (facd64a) will **increase** coverage by `0.01%`. > The diff coverage is `9.87%`. :mega: This organization is not using Codecov’s [GitHub App Integration](https://github.com/apps/codecov). We recommend you install it so Codecov can continue to function properly for your repositories. [Learn more](https://about.codecov.io/blog/codecov-is-updating-its-github-integration/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://codecov.io/gh/cerc-io/laconicd/pull/100/graphs/tree.svg?width=650&height=150&src=pr&token=5tWmn7LxfO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #100 +/- ## ========================================== + Coverage 66.38% 66.39% +0.01% ========================================== Files 148 148 Lines 16054 16051 -3 ========================================== Hits 10657 10657 + Misses 4920 4918 -2 + Partials 477 476 -1 ``` | [Impacted Files](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [x/auction/keeper/keeper.go](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9hdWN0aW9uL2tlZXBlci9rZWVwZXIuZ28=) | `41.32% <0.00%> (ø)` | | | [x/bond/keeper/keeper.go](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9ib25kL2tlZXBlci9rZWVwZXIuZ28=) | `44.54% <0.00%> (ø)` | | | [x/registry/keeper/keeper.go](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9yZWdpc3RyeS9rZWVwZXIva2VlcGVyLmdv) | `48.92% <0.00%> (ø)` | | | [x/registry/keeper/naming\_keeper.go](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9yZWdpc3RyeS9rZWVwZXIvbmFtaW5nX2tlZXBlci5nbw==) | `13.80% <0.00%> (ø)` | | | [x/registry/keeper/record\_keeper.go](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9yZWdpc3RyeS9rZWVwZXIvcmVjb3JkX2tlZXBlci5nbw==) | `11.05% <0.00%> (ø)` | | | [x/registry/keeper/grpc\_query.go](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9yZWdpc3RyeS9rZWVwZXIvZ3JwY19xdWVyeS5nbw==) | `52.77% <25.00%> (ø)` | | | [x/auction/keeper/grpc\_query.go](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9hdWN0aW9uL2tlZXBlci9ncnBjX3F1ZXJ5Lmdv) | `94.00% <83.33%> (ø)` | | | [x/bond/keeper/grpc\_query.go](https://codecov.io/gh/cerc-io/laconicd/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9ib25kL2tlZXBlci9ncnBjX3F1ZXJ5Lmdv) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/cerc-io/laconicd/pull/100/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) </details>

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#100
No description provided.