update to cerc-io/laconicd #35
No reviewers
Labels
No Label
bug
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
dependencies
docker
documentation
duplicate
enhancement
go
good first issue
help wanted
high priority
in progress
invalid
javascript
low priority
medium priority
question
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
urgent
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/laconicd-deprecated#35
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "murali/#32"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes: #32
Description
Update package names, dependencies and docker/ReadMe files to match with cerc-io/laconicd
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)LGTM, thanks for prioritizing this last minute. Looks like linting is still failing but that is being addressed in another PR. Gosec is also failing and I'm not sure if that is some weird non-deterministic finickiness or something else (error seems to be "[gosec] 2022/09/07 11:48:49 strconv.ParseUint: parsing "64-69": invalid syntax"), if you can look into that before merging this that would be great.
And there has been some back-and-forth discussion about what to name this repo but let's stick with laconicd for now and if we need to change it later on we can.
@ -133,3 +133,3 @@
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 64)
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 63)
if err != nil {
See https://github.com/cosmos/gosec/tree/master/rules/sdk#strconv-unsigned-integers-cast-to-signed-integers-overflow
Still Failing after adding the change:
9c49c2b934..9e014725b8 (diff-7f75fec163267a96892043b684f88d495897981a15943b06e4b11e5458c62b8c)
Gosec rule for parsing intergers: https://github.com/cosmos/gosec/tree/master/rules/sdk#strconv-unsigned-integers-cast-to-signed-integers-overflow
@ -133,3 +133,3 @@
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 64)
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 63)
if err != nil {
That's odd, thanks for checking. Let's just take note of this for now and move on.