update to cerc-io/laconicd #35

Merged
0xmuralik merged 4 commits from murali/#32 into main 2022-09-09 06:27:20 +00:00
0xmuralik commented 2022-09-07 07:30:16 +00:00 (Migrated from github.com)

Closes: #32

Description

Update package names, dependencies and docker/ReadMe files to match with cerc-io/laconicd


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
Closes: #32 ## Description Update package names, dependencies and docker/ReadMe files to match with cerc-io/laconicd ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
ashwinphatak (Migrated from github.com) reviewed 2022-09-07 07:30:16 +00:00
anilCSE (Migrated from github.com) reviewed 2022-09-07 07:30:16 +00:00
gsk967 (Migrated from github.com) reviewed 2022-09-07 07:30:16 +00:00
i-norden reviewed 2022-09-07 17:50:40 +00:00
i-norden left a comment
Member

LGTM, thanks for prioritizing this last minute. Looks like linting is still failing but that is being addressed in another PR. Gosec is also failing and I'm not sure if that is some weird non-deterministic finickiness or something else (error seems to be "[gosec] 2022/09/07 11:48:49 strconv.ParseUint: parsing "64-69": invalid syntax"), if you can look into that before merging this that would be great.

And there has been some back-and-forth discussion about what to name this repo but let's stick with laconicd for now and if we need to change it later on we can.

LGTM, thanks for prioritizing this last minute. Looks like linting is still failing but that is being addressed in another PR. Gosec is also failing and I'm not sure if that is some weird non-deterministic finickiness or something else (error seems to be "[gosec] 2022/09/07 11:48:49 strconv.ParseUint: parsing "64-69": invalid syntax"), if you can look into that before merging this that would be great. And there has been some back-and-forth discussion about what to name this repo but let's stick with laconicd for now and if we need to change it later on we can.
0xmuralik (Migrated from github.com) reviewed 2022-09-08 06:25:13 +00:00
@ -133,3 +133,3 @@
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 64)
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 63)
if err != nil {
0xmuralik (Migrated from github.com) commented 2022-09-08 06:25:13 +00:00
See https://github.com/cosmos/gosec/tree/master/rules/sdk#strconv-unsigned-integers-cast-to-signed-integers-overflow
0xmuralik commented 2022-09-08 06:28:05 +00:00 (Migrated from github.com)
Still Failing after adding the change: https://github.com/cerc-io/laconicd/pull/35/files/9c49c2b934b08ceff409d3dcc08ee13b5606148e..9e014725b8bf486c3ab62e67191c370fc03a1952#diff-7f75fec163267a96892043b684f88d495897981a15943b06e4b11e5458c62b8c Gosec rule for parsing intergers: https://github.com/cosmos/gosec/tree/master/rules/sdk#strconv-unsigned-integers-cast-to-signed-integers-overflow
i-norden approved these changes 2022-09-08 20:58:39 +00:00
@ -133,3 +133,3 @@
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 64)
height, err := strconv.ParseUint(blockHeightHeader[0], 10, 63)
if err != nil {
Member

That's odd, thanks for checking. Let's just take note of this for now and move on.

That's odd, thanks for checking. Let's just take note of this for now and move on.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#35
No description provided.