Clean up test suite #134

Merged
ashwin merged 10 commits from deep-stack/laconicd-deprecated:pm-qol-improvements into main 2024-01-22 10:27:09 +00:00
Member

This attempts to simplify tests, and make them generally more usable:

  • simplifies CI jobs
  • makefile tweaks, init.sh clean up
  • small dockerfile, compose, etc. improvements
  • removes sdk-tester dockerfile, the sdk repo has it
  • removes redundant test scripts, improve run-tests
  • simplifies and removes redundant logic in test suite. covers ignored errors
  • adds logging context, doc updates
This attempts to simplify tests, and make them generally more usable: - simplifies CI jobs - makefile tweaks, init.sh clean up - small dockerfile, compose, etc. improvements - removes sdk-tester dockerfile, the sdk repo has it - removes redundant test scripts, improve run-tests - simplifies and removes redundant logic in test suite. covers ignored errors - adds logging context, doc updates
prathamesh added 6 commits 2024-01-15 08:39:34 +00:00
handle request errors

rm cruft

test logging

cleanup test script
docker ignore

dockerfile cleanup

clean up init script

forward LOGLEVEL
dockerignore
Some checks failed
Build / cleanup-runs (pull_request) Has been cancelled
Build / build (pull_request) Has been cancelled
Pull Request Labeler / triage (pull_request) Has been cancelled
Lint / Run golangci-lint (pull_request) Has been cancelled
Lint / Run flake8 on python integration tests (pull_request) Has been cancelled
CodeQL / Analyze (go) (pull_request) Has been cancelled
Dependency Review / dependency-review (pull_request) Has been cancelled
Deploy Contract / cleanup-runs (pull_request) Has been cancelled
Deploy Contract / deploy (pull_request) Has been cancelled
Protobuf / lint (pull_request) Has been cancelled
Protobuf / break-check (pull_request) Has been cancelled
Run Gosec / Gosec (pull_request) Has been cancelled
Semgrep / Scan (pull_request) Has been cancelled
Tests / cleanup-runs (pull_request) Has been cancelled
Tests / test-unit-cover (pull_request) Has been cancelled
Tests / test-importer (pull_request) Has been cancelled
Tests / test-rpc (pull_request) Has been cancelled
Tests / sdk_tests (pull_request) Has been cancelled
eb2cf63324
prathamesh changed title from Clean up test suite to [WIP] Clean up test suite 2024-01-15 08:51:29 +00:00
prathamesh added 1 commit 2024-01-16 09:05:02 +00:00
Fix SDK test CI workflow
Some checks failed
Build / cleanup-runs (pull_request) Has been cancelled
Build / build (pull_request) Has been cancelled
Run Gosec / Gosec (pull_request) Has been cancelled
CodeQL / Analyze (go) (pull_request) Has been cancelled
Dependency Review / dependency-review (pull_request) Has been cancelled
Deploy Contract / cleanup-runs (pull_request) Has been cancelled
Deploy Contract / deploy (pull_request) Has been cancelled
Pull Request Labeler / triage (pull_request) Has been cancelled
Lint / Run golangci-lint (pull_request) Has been cancelled
Lint / Run flake8 on python integration tests (pull_request) Has been cancelled
Protobuf / lint (pull_request) Has been cancelled
Protobuf / break-check (pull_request) Has been cancelled
Semgrep / Scan (pull_request) Has been cancelled
Tests / cleanup-runs (pull_request) Has been cancelled
Tests / test-unit-cover (pull_request) Has been cancelled
Tests / test-importer (pull_request) Has been cancelled
Tests / test-rpc (pull_request) Has been cancelled
Tests / sdk_tests (pull_request) Has been cancelled
0619d7e3d3
prathamesh changed title from [WIP] Clean up test suite to Clean up test suite 2024-01-16 12:17:30 +00:00
ashwin requested review from telackey 2024-01-16 12:22:22 +00:00
telackey reviewed 2024-01-16 18:19:46 +00:00
@ -60,3 +60,3 @@
make test-import
if: env.GIT_DIFF
Member

Since the primary repo is in Gitea, two quick questions:

  1. Are these CI jobs passing under Gitea actions?
  2. If not, what do we need to do to make them pass there as well?
Since the primary repo is in Gitea, two quick questions: 1. Are these CI jobs passing under Gitea actions? 2. If not, what do we need to do to make them pass there as well?
Author
Member

Are these CI jobs passing under Gitea actions?

No, these jobs in the CI are coming from upstream repo where they were setup for GitHub.

If not, what do we need to do to make them pass there as well?

Needs more investigation as Gitea CI / actions runner doesn't seem to be compatible with that in GitHub.
But they do run on GitHub post sync after a PR gets merged (to main) as they are configured to run on push to main as well.
The CI has been failing on Gitea for a while.

> Are these CI jobs passing under Gitea actions? No, these jobs in the CI are coming from upstream repo where they were setup for GitHub. > If not, what do we need to do to make them pass there as well? Needs more investigation as Gitea CI / actions runner doesn't seem to be compatible with that in GitHub. But they do run on GitHub post sync after a PR gets merged (to main) as they are configured to run on push to main as well. The CI has been failing on Gitea for a while.
Member

We have an issue open here:

cerc-io/laconicd#116

And on the merge previous to the new protobuf changes we had these passing in Gitea:

  • Pull Request Labeler / triage (push) Successful in 6s
  • Run Gosec / Gosec (push) Successful in 23s
  • Lint / Run golangci-lint (push) Successful in 1m32s
  • CodeQL / Analyze (go) (push) Successful in 1m37s
  • Tests / test-unit-cover (push) Successful in 1m43s
  • Tests / test-importer (push) Successful in 1m23s
  • Tests / test-rpc (push) Successful in 1m28s

I think it makes sense, especially as Gitea is our upstream now, that on the way to resolving #116, we at least make sure that was passing continues to pass.

We have an issue open here: https://git.vdb.to/cerc-io/laconicd/issues/116 And on the merge previous to the new protobuf changes we had these passing in Gitea: - Pull Request Labeler / triage (push) Successful in 6s - Run Gosec / Gosec (push) Successful in 23s - Lint / Run golangci-lint (push) Successful in 1m32s - CodeQL / Analyze (go) (push) Successful in 1m37s - Tests / test-unit-cover (push) Successful in 1m43s - Tests / test-importer (push) Successful in 1m23s - Tests / test-rpc (push) Successful in 1m28s I think it makes sense, especially as Gitea is our upstream now, that on the way to resolving #116, we at least make sure that was passing continues to pass.
@ -30,3 +28,1 @@
Signer: msg.GetSigner(),
Payload: msg.GetPayload(),
})
record, err := m.Keeper.ProcessSetRecord(ctx, *msg)
Member

The changes to this file look fine, but I'm not sure how they are related to test cleanup.

The changes to this file look fine, but I'm not sure how they are related to test cleanup.
Author
Member

The changes to this file look fine, but I'm not sure how they are related to test cleanup.

Cleanup change coming from original PR cerc-io/laconicd#111.

> The changes to this file look fine, but I'm not sure how they are related to test cleanup. Cleanup change coming from original PR https://git.vdb.to/cerc-io/laconicd/pulls/111.
Member

I think the same question applies, but it may not be worth splitting out into a separate PR.

I think the same question applies, but it may not be worth splitting out into a separate PR.
Member

One option (and the same goes for cerc-io/laconic-sdk#53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR.

Sound reasonable?

One option (and the same goes for https://git.vdb.to/cerc-io/laconic-sdk/pulls/53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR. Sound reasonable?
telackey approved these changes 2024-01-18 18:58:33 +00:00
prathamesh added 1 commit 2024-01-19 05:37:23 +00:00
Fix lint errors
Some checks failed
Tests / test-unit-cover (pull_request) Has been cancelled
Tests / test-importer (pull_request) Has been cancelled
Tests / test-rpc (pull_request) Has been cancelled
Tests / sdk_tests (pull_request) Has been cancelled
Build / cleanup-runs (pull_request) Has been cancelled
Build / build (pull_request) Has been cancelled
CodeQL / Analyze (go) (pull_request) Has been cancelled
Dependency Review / dependency-review (pull_request) Has been cancelled
Deploy Contract / cleanup-runs (pull_request) Has been cancelled
Deploy Contract / deploy (pull_request) Has been cancelled
Pull Request Labeler / triage (pull_request) Has been cancelled
Lint / Run golangci-lint (pull_request) Has been cancelled
Lint / Run flake8 on python integration tests (pull_request) Has been cancelled
Protobuf / lint (pull_request) Has been cancelled
Protobuf / break-check (pull_request) Has been cancelled
Run Gosec / Gosec (pull_request) Has been cancelled
Semgrep / Scan (pull_request) Has been cancelled
Tests / cleanup-runs (pull_request) Has been cancelled
467be48baf
prathamesh added 1 commit 2024-01-22 04:59:59 +00:00
Add comment to test CI
Some checks failed
Build / cleanup-runs (pull_request) Successful in 15s
Build / build (pull_request) Successful in 1m12s
Dependency Review / dependency-review (pull_request) Successful in 1m14s
Deploy Contract / cleanup-runs (pull_request) Successful in 6s
CodeQL / Analyze (go) (pull_request) Successful in 2m57s
Deploy Contract / deploy (pull_request) Failing after 56s
Pull Request Labeler / triage (pull_request) Failing after 19s
Lint / Run golangci-lint (pull_request) Successful in 2m24s
Lint / Run flake8 on python integration tests (pull_request) Failing after 2m23s
Protobuf / lint (pull_request) Successful in 22s
Protobuf / break-check (pull_request) Failing after 31s
Run Gosec / Gosec (pull_request) Successful in 1m12s
Semgrep / Scan (pull_request) Failing after 1m28s
Tests / cleanup-runs (pull_request) Failing after 3s
Tests / test-unit-cover (pull_request) Successful in 1m24s
Tests / test-rpc (pull_request) Successful in 1m29s
Tests / test-importer (pull_request) Successful in 1m33s
Tests / sdk_tests (pull_request) Failing after 13m46s
ab969e20bf
Author
Member

One option (and the same goes for cerc-io/laconic-sdk#53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR.

Created an issue to track this: cerc-io/laconic-sdk#54

> One option (and the same goes for cerc-io/laconic-sdk#53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR. Created an issue to track this: https://git.vdb.to/cerc-io/laconic-sdk/issues/54
prathamesh added 1 commit 2024-01-22 09:21:22 +00:00
Remove unnecessary comments
Some checks failed
Build / cleanup-runs (pull_request) Successful in 7s
Deploy Contract / cleanup-runs (pull_request) Successful in 6s
Deploy Contract / deploy (pull_request) Failing after 39s
Build / build (pull_request) Successful in 59s
Pull Request Labeler / triage (pull_request) Failing after 15s
CodeQL / Analyze (go) (pull_request) Successful in 1m46s
Protobuf / lint (pull_request) Successful in 46s
Dependency Review / dependency-review (pull_request) Successful in 2m30s
Protobuf / break-check (pull_request) Failing after 22s
Lint / Run golangci-lint (pull_request) Successful in 2m19s
Lint / Run flake8 on python integration tests (pull_request) Failing after 2m15s
Run Gosec / Gosec (pull_request) Successful in 46s
Tests / cleanup-runs (pull_request) Successful in 5s
Semgrep / Scan (pull_request) Failing after 28s
Tests / test-importer (pull_request) Successful in 51s
Tests / test-unit-cover (pull_request) Successful in 1m38s
Tests / test-rpc (pull_request) Successful in 1m36s
Tests / sdk_tests (pull_request) Failing after 11m33s
8b7162b228
ashwin merged commit 055cfb2255 into main 2024-01-22 10:27:09 +00:00
ashwin deleted branch pm-qol-improvements 2024-01-22 10:27:09 +00:00
ashwin referenced this issue from a commit 2024-01-22 10:27:11 +00:00
dboreham reviewed 2024-01-22 13:06:58 +00:00
@ -29,2 +28,3 @@
WORKDIR /
# Run laconicd by default
CMD ["laconicd"]
ENTRYPOINT ["laconicd"]
Owner

Curious about why this change was needed. It broke stack orchestrator's use of laconicd, for example.

Curious about why this change was needed. It broke stack orchestrator's use of laconicd, for example.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#134
No description provided.