Clean up test suite #134
No reviewers
Labels
No Label
bug
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
dependencies
docker
documentation
duplicate
enhancement
go
good first issue
help wanted
high priority
in progress
invalid
javascript
low priority
medium priority
question
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
urgent
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/laconicd-deprecated#134
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "deep-stack/laconicd-deprecated:pm-qol-improvements"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This attempts to simplify tests, and make them generally more usable:
Clean up test suiteto [WIP] Clean up test suite[WIP] Clean up test suiteto Clean up test suite@ -60,3 +60,3 @@
make test-import
if: env.GIT_DIFF
Since the primary repo is in Gitea, two quick questions:
No, these jobs in the CI are coming from upstream repo where they were setup for GitHub.
Needs more investigation as Gitea CI / actions runner doesn't seem to be compatible with that in GitHub.
But they do run on GitHub post sync after a PR gets merged (to main) as they are configured to run on push to main as well.
The CI has been failing on Gitea for a while.
We have an issue open here:
cerc-io/laconicd#116
And on the merge previous to the new protobuf changes we had these passing in Gitea:
I think it makes sense, especially as Gitea is our upstream now, that on the way to resolving #116, we at least make sure that was passing continues to pass.
@ -30,3 +28,1 @@
Signer: msg.GetSigner(),
Payload: msg.GetPayload(),
})
record, err := m.Keeper.ProcessSetRecord(ctx, *msg)
The changes to this file look fine, but I'm not sure how they are related to test cleanup.
Cleanup change coming from original PR cerc-io/laconicd#111.
I think the same question applies, but it may not be worth splitting out into a separate PR.
One option (and the same goes for cerc-io/laconic-sdk#53) is that if everything is passing for you locally, to go ahead and merge, but open an issue with all the details of the failures, and we will fix the CI as a separate task/PR.
Sound reasonable?
Created an issue to track this: cerc-io/laconic-sdk#54
@ -29,2 +28,3 @@
WORKDIR /
# Run laconicd by default
CMD ["laconicd"]
ENTRYPOINT ["laconicd"]
Curious about why this change was needed. It broke stack orchestrator's use of laconicd, for example.