Remove hard-coded record types #132
No reviewers
Labels
No Label
bug
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
dependencies
docker
documentation
duplicate
enhancement
go
good first issue
help wanted
high priority
in progress
invalid
javascript
low priority
medium priority
question
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
urgent
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/laconicd-deprecated#132
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "deep-stack/laconicd-deprecated:ng-rm-record-types"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Record.Attributes
from Any into a byte string and removes the hard-coded Protobuf record types.I built and deployed laconicd, built the new laconic-sdk, and then built the CLI to use the new SDK.
After all that, I am getting some errors:
What might I be doing wrong?
I deleted the existing registry data and recreated it from scratch, and I was able to get working responses. So apparently this is a completely breaking change for existing deployments. That's probably OK, just good to note.
I did see something quirky though. I am not sure if the is a CLI or server issue, but
laconic cns record list
now shows all records even when--all
is not specified if no other filters are included.If any filter is included, it reverts to the old behavior and only shows results with names, unless
--all
is set explicitly. This is rather confusing, but also comparatively minor.Other than the "all" issue mentioned above, LGTM, and I am fine if we just open an issue for that to be fixed later.
Since this is a breaking change, we probably want to merge it and the SDK PR and create new releases sooner rather than later, so that I can re-create the production registry deployment before it contains any valuable data.
On checking locally, I see that command
laconic cns record list
without the--all
flag returns all records even with previous laconicd and laconic-sdk versions (laconicd -9c240f1a0c152d74a4bea57bfd6af7f323d44b5c
, laconic-registry-cli -6814707752c445ae9cfec9fd282a4f88adac08f8
)