upgrade IPLD prime #102

Merged
0xmuralik merged 7 commits from murali/ipld-prime into main 2023-03-22 13:43:52 +00:00
0xmuralik commented 2023-03-15 10:24:01 +00:00 (Migrated from github.com)

Closes: #96

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> Closes: #96 ## Description <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
ABastionOfSanity (Migrated from github.com) reviewed 2023-03-15 10:24:01 +00:00
aleem1314 (Migrated from github.com) reviewed 2023-03-15 10:24:01 +00:00
i-norden approved these changes 2023-03-17 17:36:31 +00:00
i-norden left a comment
Member

This LGTM but want @zramsay's final approval.

This LGTM but want @zramsay's final approval.
zramsay requested changes 2023-03-17 17:43:15 +00:00
@ -20,2 +20,4 @@
*_test.go
# false positive; TODO: https://github.com/cerc-io/laconicd/issues/104
testutil/network/network.go
Member

Can you provide context for this? AFAICT tests were passing in the previous commit
I'd prefer to not ignore tests.

Can you provide context for this? AFAICT tests were passing in the previous commit I'd prefer to not ignore tests.
0xmuralik (Migrated from github.com) reviewed 2023-03-17 19:15:29 +00:00
@ -20,2 +20,4 @@
*_test.go
# false positive; TODO: https://github.com/cerc-io/laconicd/issues/104
testutil/network/network.go
0xmuralik (Migrated from github.com) commented 2023-03-17 19:15:29 +00:00

https://github.com/cerc-io/laconicd/runs/12015779774
Weirdly, this check fails only sometimes.

https://github.com/cerc-io/laconicd/runs/12015779774 Weirdly, this check fails only sometimes.
zramsay reviewed 2023-03-18 00:00:14 +00:00
@ -20,2 +20,4 @@
*_test.go
# false positive; TODO: https://github.com/cerc-io/laconicd/issues/104
testutil/network/network.go
Member

#104
please change line 22 to # false positive; TODO: https://github.com/cerc-io/laconicd/issues/104
then feel free to merge

#104 please change line 22 to `# false positive; TODO: https://github.com/cerc-io/laconicd/issues/104` then feel free to merge
zramsay approved these changes 2023-03-18 00:00:26 +00:00
0xmuralik commented 2023-03-20 10:19:45 +00:00 (Migrated from github.com)

@zramsay any thoughts on the failing check?

@zramsay any thoughts on the failing check?
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#102
No description provided.