cerc-io/laconicd-deprecated
19
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Restore CMD rather than ENTRYPOINT (#136)
Some checks failed
Pull Request Labeler / triage (push) Successful in 5s
Details
Lint / Run golangci-lint (push) Successful in 29s
Details
CodeQL / Analyze (go) (push) Has been cancelled
Details
Lint / Run flake8 on python integration tests (push) Has been cancelled
Details
Run Gosec / Gosec (push) Has been cancelled
Details
Tests / cleanup-runs (push) Has been skipped
Details
Tests / test-importer (push) Has been cancelled
Details
Tests / test-rpc (push) Has been cancelled
Details
Tests / sdk_tests (push) Has been cancelled
Details
Tests / test-unit-cover (push) Has been cancelled
Details

Browse Source 
Switching to ENTRYPOINT broke the SO fixturenet stack.

I think there are arguments both ways as to whether ENTRYPOINT or CMD is more appropriate in this case, but in general I lean towards not breaking something that was working without a strong reason.

Reviewed-on: cerc-io/laconicd#136
Co-authored-by: Thomas E Lackey <telackey@bozemanpass.com>
Co-committed-by: Thomas E Lackey <telackey@bozemanpass.com>
This commit is contained in:
Thomas E Lackey 2024-01-22 23:19:08 +00:00 committed by Thomas E Lackey
parent 28b9207bbe
commit e7bab9b971
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Dockerfile
View File

@ -27,4 +27,4 @@ COPY --from=build-env /go/src/github.com/cerc-io/laconicd/build/laconicd /usr/bi
WORKDIR / WORKDIR /
# Run laconicd by default # Run laconicd by default
ENTRYPOINT ["laconicd"] CMD ["laconicd"]