Restore CMD rather than ENTRYPOINT #136

Merged
telackey merged 1 commits from telackey/cmd into main 2024-01-22 23:19:11 +00:00
Member

Switching to ENTRYPOINT broke the SO fixturenet stack.

I think there are arguments both ways as to whether ENTRYPOINT or CMD is more appropriate in this case, but in general I lean towards not breaking something that was working without a strong reason.

Switching to ENTRYPOINT broke the SO fixturenet stack. I think there are arguments both ways as to whether ENTRYPOINT or CMD is more appropriate in this case, but in general I lean towards not breaking something that was working without a strong reason.
telackey added 1 commit 2024-01-22 22:26:56 +00:00
Restore CMD rather than ENTRYPOINT
Some checks failed
Run Gosec / Gosec (pull_request) Failing after 54s
Build / cleanup-runs (pull_request) Successful in 10s
Build / build (pull_request) Failing after 1m10s
Dependency Review / dependency-review (pull_request) Failing after 1m8s
Deploy Contract / cleanup-runs (pull_request) Successful in 6s
Pull Request Labeler / triage (pull_request) Failing after 7s
Deploy Contract / deploy (pull_request) Failing after 39s
CodeQL / Analyze (go) (pull_request) Failing after 3m8s
Lint / Run golangci-lint (pull_request) Failing after 56s
Semgrep / Scan (pull_request) Failing after 27s
Tests / cleanup-runs (pull_request) Successful in 9s
Lint / Run flake8 on python integration tests (pull_request) Failing after 1m39s
Tests / test-rpc (pull_request) Failing after 33s
Tests / test-importer (pull_request) Failing after 1m9s
Tests / test-unit-cover (pull_request) Failing after 1m16s
Tests / sdk_tests (pull_request) Failing after 16m55s
ca305d2642
telackey requested review from dboreham 2024-01-22 22:27:15 +00:00
telackey merged commit e7bab9b971 into main 2024-01-22 23:19:11 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#136
No description provided.