cerc-io/laconic-sdk
13
0 Fork 1
Code Issues 3 Pull Requests Actions Packages Projects Releases 17 Wiki Activity

Handle record attributes with null values #56

Merged
ashwin merged 2 commits from deep-stack/laconic-sdk:pm-handle-null into main 2024-02-08 05:39:32 +00:00
Conversation 1 Commits 2 Files Changed 2
+2 -2
prathamesh commented 2024-02-08 05:16:20 +00:00
Member
Copy link
Copy source

Part of cerc-io/laconicd#144

Part of https://git.vdb.to/cerc-io/laconicd/issues/144
prathamesh added 2 commits 2024-02-08 05:16:20 +00:00
Handle record attributes with null values 43a7061ffe
Update package version
Tests / sdk_tests (pull_request) Successful in 19m50s
Details
28823c64cb
prathamesh commented 2024-02-08 05:36:47 +00:00
Author
Member
Copy link
Copy source

Console output after publishing a malformed record (cerc-io/laconicd#144 (comment)):

Before these changes:
Screenshot from 2024-02-08 09-25-45

After these changes:
Screenshot from 2024-02-08 10-57-59

Similarly for laconic-registry-cli:

Before these changes:

➜  laconic-registry-cli git:(c3f8d53) ✗ laconic cns record list
laconic cns record list

List records.

Options:
      --version   Show version number                                  [boolean]
...

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at Util.fromGQLValue (/home/prathamesh/.config/yarn/global/node_modules/@cerc-io/laconic-registry-cli/node_modules/@cerc-io/laconic-sdk/dist/util.js:116:32)
    at /home/prathamesh/.config/yarn/global/node_modules/@cerc-io/laconic-registry-cli/node_modules/@cerc-io/laconic-sdk/dist/util.js:110:34
...

After these changes:

➜  laconic-registry-cli git:(c3f8d53) ✗ ./bin/laconic cns record list
[
  {
    "id": "bafyreidst46ge7swsb3uh5k75qpfrqz7v2wryuvvozv26pijjlr4nyefdm",
    "names": null,
    "owners": [
      "35357FBEBF6BAC5BFB8F7C7224BED9E07FA51E0A"
    ],
    "bondId": "fc0b4d901c612995dafc824417dbf1c4dcbefd1d6ee2fa167b899fd409021cd5",
    "createTime": "2024-02-08T03:48:20Z",
    "expiryTime": "2025-02-07T03:48:20Z",
    "attributes": {
      "build_artifact_cid": "QmP8jTG1m9GSDJLCbeWhVSVgEzCPPwXRdCRuJtQ5Tz9Kc9",
      "repo_registration_record_cid": "QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D",
      "tls_cert_cid": "QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR",
      "type": "WebsiteRegistrationRecord",
      "url": "https://cerc.io",
      "version": "1.0.35"
    }
  },
  {
    "id": "bafyreie6kxqoptpjf5535zzeu3fcknd7a4lizdjuezbtr44rxg3sgxlpxu",
    "names": null,
    "owners": [
      "35357FBEBF6BAC5BFB8F7C7224BED9E07FA51E0A"
    ],
    "bondId": "fc0b4d901c612995dafc824417dbf1c4dcbefd1d6ee2fa167b899fd409021cd5",
    "createTime": "2024-02-08T03:50:21Z",
    "expiryTime": "2025-02-07T03:50:21Z",
    "attributes": {
      "category": "birbit",
      "meta": null,
      "name": "image-registration-record",
      "tags": [
        "golden",
        "pheasant",
        "trespassing"
      ],
      "type": "GeneralRecord",
      "value": "cute-rare-animal",
      "version": "0.0.2"
    }
  }
]
Console output after publishing a malformed record (https://git.vdb.to/cerc-io/laconicd/issues/144#issuecomment-5189): Before these changes: ![Screenshot from 2024-02-08 09-25-45](/attachments/8c22b9c4-24f4-493f-b12d-0472edd30ffe) After these changes: ![Screenshot from 2024-02-08 10-57-59](/attachments/11d37f50-efa4-4786-af31-8931ef337c75) Similarly for `laconic-registry-cli`: Before these changes: ```bash ➜ laconic-registry-cli git:(c3f8d53) ✗ laconic cns record list laconic cns record list List records. Options: --version Show version number [boolean] ... TypeError: Cannot convert undefined or null to object at Function.keys (<anonymous>) at Util.fromGQLValue (/home/prathamesh/.config/yarn/global/node_modules/@cerc-io/laconic-registry-cli/node_modules/@cerc-io/laconic-sdk/dist/util.js:116:32) at /home/prathamesh/.config/yarn/global/node_modules/@cerc-io/laconic-registry-cli/node_modules/@cerc-io/laconic-sdk/dist/util.js:110:34 ... ``` After these changes: ```bash ➜ laconic-registry-cli git:(c3f8d53) ✗ ./bin/laconic cns record list [ { "id": "bafyreidst46ge7swsb3uh5k75qpfrqz7v2wryuvvozv26pijjlr4nyefdm", "names": null, "owners": [ "35357FBEBF6BAC5BFB8F7C7224BED9E07FA51E0A" ], "bondId": "fc0b4d901c612995dafc824417dbf1c4dcbefd1d6ee2fa167b899fd409021cd5", "createTime": "2024-02-08T03:48:20Z", "expiryTime": "2025-02-07T03:48:20Z", "attributes": { "build_artifact_cid": "QmP8jTG1m9GSDJLCbeWhVSVgEzCPPwXRdCRuJtQ5Tz9Kc9", "repo_registration_record_cid": "QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D", "tls_cert_cid": "QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR", "type": "WebsiteRegistrationRecord", "url": "https://cerc.io", "version": "1.0.35" } }, { "id": "bafyreie6kxqoptpjf5535zzeu3fcknd7a4lizdjuezbtr44rxg3sgxlpxu", "names": null, "owners": [ "35357FBEBF6BAC5BFB8F7C7224BED9E07FA51E0A" ], "bondId": "fc0b4d901c612995dafc824417dbf1c4dcbefd1d6ee2fa167b899fd409021cd5", "createTime": "2024-02-08T03:50:21Z", "expiryTime": "2025-02-07T03:50:21Z", "attributes": { "category": "birbit", "meta": null, "name": "image-registration-record", "tags": [ "golden", "pheasant", "trespassing" ], "type": "GeneralRecord", "value": "cute-rare-animal", "version": "0.0.2" } } ] ```
Screenshot from 2024-02-08 09-25-45.png
71 KiB
Screenshot from 2024-02-08 10-57-59.png
89 KiB
prathamesh marked the pull request as ready for review 2024-02-08 05:38:12 +00:00
ashwin merged commit 73bef00dd3 into main 2024-02-08 05:39:32 +00:00
ashwin deleted branch pm-handle-null 2024-02-08 05:39:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 in progress
invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) iskay prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/laconic-sdk#56