bug from writing records #144

New Issue

zramsay · 2024-02-02T19:13:28Z

zramsay commented

2024-02-02 19:13:28 +00:00

i get this error in the console, and no ability to view published records, after doing something funky (i think trying to publish an app deployment request without having published an app record)

Screenshot 2024-02-02 at 12.34.51.png

30 KiB

ashwin commented

2024-02-07 03:10:16 +00:00

Are you able to reproduce this error (if so, can you include the steps here)?

zramsay commented

2024-02-08 00:38:46 +00:00

to reproduce: publish a record that is valid yaml but an "invalid" record, e.g., the following records has a meta field with no attributes:

  type: GeneralRecord
  name: image-registration-record
  version: 0.0.2
  value: "cute-rare-animal"
  category: birbit
  tags:
    - golden
    - pheasant
    - trespassing
  meta:

then, the console will not work by throwing the previously uploaded screenshot error. At least, the console should ignore the malformed record rather than not display any of them. Ideally, laconicd would reject publication of a malformed record (which it definitely does not doo, but bad YAML will not get published)

to reproduce: publish a record that is valid yaml but an "invalid" record, e.g., the following records has a meta field with no attributes: ``` type: GeneralRecord name: image-registration-record version: 0.0.2 value: "cute-rare-animal" category: birbit tags: - golden - pheasant - trespassing meta: ``` then, the console will not work by throwing the previously uploaded screenshot error. At least, the console should ignore the malformed record rather than not display any of them. Ideally, laconicd would reject publication of a malformed record (which it definitely does not doo, but bad YAML will not get published)

prathamesh referenced this issue from cerc-io/laconic-sdk

2024-02-08 05:16:20 +00:00

Handle record attributes with null values #56

prathamesh referenced this issue from cerc-io/laconic-sdk

2024-02-08 05:36:47 +00:00

Handle record attributes with null values #56

ashwin referenced this issue from a commit

2024-02-08 05:39:34 +00:00

Handle record attributes with null values (#56)

prathamesh referenced this issue from cerc-io/laconic-registry-cli

2024-02-08 06:07:22 +00:00

Upgrade SDK version #55

prathamesh referenced this issue from cerc-io/laconic-console

2024-02-08 06:16:24 +00:00

Upgrade SDK version #46

ashwin referenced this issue from a commit

2024-02-08 06:17:59 +00:00

Upgrade SDK version (#46)

ashwin referenced this issue from a commit

2024-02-08 06:27:14 +00:00

Upgrade SDK version (#55)

prathamesh commented

2024-02-08 06:59:41 +00:00

This has been handled now.

Have tested the changes with fixturenet-laconic-loaded stack (steps) with an additional step to publish the malformed record and checking it in console

@zramsay can you see if it works for you?

This has been handled now. - Relevant PRs: * https://git.vdb.to/cerc-io/laconic-sdk/pulls/56 * https://git.vdb.to/cerc-io/laconic-registry-cli/pulls/55 * https://git.vdb.to/cerc-io/laconic-console/pulls/46 - Releases: * https://git.vdb.to/cerc-io/laconic-sdk/releases/tag/v0.1.15 * https://git.vdb.to/cerc-io/laconic-registry-cli/releases/tag/v0.1.10 * https://git.vdb.to/cerc-io/laconic-console/releases/tag/v1.3.8 Have tested the changes with [fixturenet-laconic-loaded](https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/stack_orchestrator/data/stacks/fixturenet-laconic-loaded) stack ([steps](https://github.com/cerc-io/stack-orchestrator/blob/main/docs/laconicd-with-console.md)) with an additional step to publish the malformed record and checking it in console @zramsay can you see if it works for you?

zramsay commented

2024-04-03 11:53:07 +00:00

yes

zramsay closed this issue

2024-04-03 11:53:07 +00:00

Sign in to join this conversation.