Add a config option and arg to set gas price for auto fees calculation #81

Merged

nabarun merged 9 commits from deep-stack/laconic-registry-cli:pm-support-auto-gas into main 2024-09-06 09:44:48 +00:00

Conversation 0 Commits 9 Files Changed 40

+347 -110

prathamesh commented 2024-08-26 12:15:31 +00:00

Member

Copy Link

Copy Source

Part of Create a public laconicd testnet
Requires cerc-io/registry-sdk#22

Behaviour in different configuration scenarios:

• Gas set, fees set to Xalnt:

  # Example
  gas: 500000
  fees: 500000alnt
  gasPrice:
  

  • gasPrice config ignored
  • tx rejected if given fees < gas * min-gas-price set by the node
  • tx fails mid-execution if it runs out of given gas

• Fees not set, gas price set to Xalnt:

  # Example
  gas:
  fees:
  gasPrice: 1alnt
  

  • gas config ignored
  • uses auto fee calculation using gas estimation with default multiplier (2) value from registry-sdk
  • tx rejected if given gasPrice < min-gas-price set by the node
  • tx fails mid-execution if it runs out of calculated gas

• Fees set to a X (without alnt suffix), gas price set to Yalnt:

  # Example
  gas:
  fees: 1.8
  gasPrice: 1alnt
  

  • gas config ignored
  • uses auto fee calculation using gas estimation with fees as the multiplier
  • tx rejected if given gasPrice < min-gas-price set by the node
  • tx fails mid-execution if it runs out of calculated gas, can be retried with a higher gas estimation multiplier (fees)

• Fees and gas price both not set:

  # Example
  gas:
  fees:
  gasPrice:
  

  • gas config ignored
  • uses auto fee calculation using gas estimation
  • throws error:

    Gas price must be set in the client options when auto gas is used.
    

The provided config can be overridden with CLI args if required.

Part of [Create a public laconicd testnet](https://www.notion.so/Create-a-public-laconicd-testnet-896a11bdd8094eff8f1b49c0be0ca3b8) Requires https://git.vdb.to/cerc-io/registry-sdk/pulls/22 Behaviour in different configuration scenarios: - Gas set, fees set to `Xalnt`: ```bash # Example gas: 500000 fees: 500000alnt gasPrice: ``` - `gasPrice` config ignored - tx rejected if given `fees` < `gas` * `min-gas-price` set by the node - tx fails mid-execution if it runs out of given `gas` - Fees not set, gas price set to `Xalnt`: ```bash # Example gas: fees: gasPrice: 1alnt ``` - `gas` config ignored - uses `auto` fee calculation using gas estimation with [default multiplier](https://git.vdb.to/cerc-io/registry-sdk/src/branch/main/src/constants.ts) (`2`) value from `registry-sdk` - tx rejected if given `gasPrice` < `min-gas-price` set by the node - tx fails mid-execution if it runs out of calculated gas - Fees set to a `X` (without `alnt` suffix), gas price set to `Yalnt`: ```bash # Example gas: fees: 1.8 gasPrice: 1alnt ``` - `gas` config ignored - uses `auto` fee calculation using gas estimation with `fees` as the multiplier - tx rejected if given `gasPrice` < `min-gas-price` set by the node - tx fails mid-execution if it runs out of calculated gas, can be retried with a higher gas estimation multiplier (`fees`) - Fees and gas price both not set: ```bash # Example gas: fees: gasPrice: ``` - `gas` config ignored - uses `auto` fee calculation using gas estimation - throws error: ```bash Gas price must be set in the client options when auto gas is used. ``` The provided config can be overridden with CLI args if required.

prathamesh added 2 commits 2024-08-26 12:15:32 +00:00

Add config option and arg to set gas price 02057d891a

Update all CLI commands f99f222162

prathamesh changed title from [WIP] Add a config option and arg to set gas price for auto gas estimation to [WIP] Add a config option and arg to set gas price for auto fees calculation 2024-08-27 11:00:30 +00:00

prathamesh changed title from [WIP] Add a config option and arg to set gas price for auto fees calculation to [WIP] Add a config option and arg to set gas price for `auto` fees calculation 2024-08-27 11:02:10 +00:00

prathamesh added 1 commit 2024-08-27 11:15:32 +00:00

Add explanation for with examples for gas and fees config 426515a9a1

prathamesh added 1 commit 2024-08-27 11:46:11 +00:00

Add short help alias 705bf0257a

prathamesh added 1 commit 2024-08-27 12:32:19 +00:00

Update bond list CLI for owner filter 743f5ebc3c

prathamesh added 1 commit 2024-08-30 09:24:40 +00:00

Add tests for gas and fees config combinations d441c04443

prathamesh added 1 commit 2024-09-05 06:13:55 +00:00

Update fees parsing 8d49de05f2

Ghost added 1 commit 2024-09-05 11:59:16 +00:00

Update readme instructions 2775bf7bb0

prathamesh force-pushed pm-support-auto-gas from 2775bf7bb0 to 60b29e047d 2024-09-06 08:37:29 +00:00 Compare

prathamesh added 1 commit 2024-09-06 09:11:51 +00:00

Increment package version b50c59c99f

prathamesh marked the pull request as ready for review 2024-09-06 09:20:42 +00:00

nabarun merged commit 86259b35a6 into main 2024-09-06 09:44:48 +00:00

nabarun deleted branch pm-support-auto-gas 2024-09-06 09:44:49 +00:00

nabarun referenced this issue from a commit 2024-09-06 09:44:49 +00:00

Add a config option and arg to set gas price for `auto` fees calculation (#81)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

in progress

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

Copied from Github

An issue or PR manually copied from GitHub.

Kind/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) iskay prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconic-registry-cli#81

Allow edits from maintainers