cerc-io/laconic-registry-cli
19
0
Fork 1
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

Update README.md to fix null auction #24

Merged
0xmuralik merged 1 commits from 0xmuralik-patch-2 into main 2023-03-06 22:50:56 +00:00
Conversation 3 Commits 1 Files Changed 1 +8
0xmuralik commented 2023-03-01 09:23:01 +00:00 (Migrated from github.com)
Copy Link

Closes: #18
Update README.md to use TEST_AUCTION_ENABLED=true ./init.sh

Closes: #18 Update README.md to use TEST_AUCTION_ENABLED=true ./init.sh
ABastionOfSanity (Migrated from github.com) reviewed 2023-03-01 09:23:01 +00:00
aleem1314 (Migrated from github.com) reviewed 2023-03-01 09:23:01 +00:00
i-norden commented 2023-03-01 15:11:50 +00:00
Member
Copy Link

Updating the README is good but I'm not sure I follow how doing so closes #18.

Updating the README is good but I'm not sure I follow how doing so closes #18.
0xmuralik commented 2023-03-01 15:37:08 +00:00 (Migrated from github.com)
Copy Link

Updating the README is good but I'm not sure I follow how doing so closes #18.

https://github.com/cerc-io/laconic-registry-cli/issues/18#issuecomment-1449658445

> Updating the README is good but I'm not sure I follow how doing so closes #18. https://github.com/cerc-io/laconic-registry-cli/issues/18#issuecomment-1449658445
i-norden commented 2023-03-01 17:15:51 +00:00
Member
Copy Link

Thanks @0xmuralik that makes sense! I commented on the wrong PR, could you provide some additional commentary on https://github.com/cerc-io/laconic-registry-cli/pull/23 explaining how this fixes #17?

Thanks @0xmuralik that makes sense! I commented on the wrong PR, could you provide some additional commentary on https://github.com/cerc-io/laconic-registry-cli/pull/23 explaining how this fixes #17?
i-norden approved these changes 2023-03-01 17:18:11 +00:00
zramsay approved these changes 2023-03-06 22:50:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
i-norden
zramsay
ABastionOfSanity
aleem1314
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in progress

   
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
in progress
invalid
question
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconic-registry-cli#24
No description provided.
Delete Branch "0xmuralik-patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?