Match up js-yaml version with peer dependency expectations #2

dboreham · 2022-09-28T19:43:47Z

dboreham commented

2022-09-28 19:43:47 +00:00

yarn produced this warning:

warning "laconic-client > node-yaml@4.0.1" has incorrect peer dependency "js-yaml@^3.13.x".

Updated package.json to specify js-yaml version that doesn't produce the warning.

Note: need to check that our use of the js-yaml library (here: https://github.com/cerc-io/laconic-sdk/blob/main/src/util/config.ts#L1 and here: https://github.com/cerc-io/laconic-sdk/blob/main/src/cmds/cns-cmds/record-cmds/publish.ts#L4) is ok with the older version. If not we will need to figure out how to have two versions of a peer dependency.

yarn produced this warning: ``` warning "laconic-client > node-yaml@4.0.1" has incorrect peer dependency "js-yaml@^3.13.x". ``` Updated `package.json` to specify js-yaml version that doesn't produce the warning. Note: need to check that our use of the js-yaml library (here: https://github.com/cerc-io/laconic-sdk/blob/main/src/util/config.ts#L1 and here: https://github.com/cerc-io/laconic-sdk/blob/main/src/cmds/cns-cmds/record-cmds/publish.ts#L4) is ok with the older version. If not we will need to figure out how to have two versions of a peer dependency.

nikugogoi (Migrated from github.com) reviewed 2022-09-28 19:43:47 +00:00

Sign in to join this conversation.

No reviewers

nikugogoi

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconic-registry-cli#2