Merge pull request #77 from cerc-io/ian/v5_dev

fix: err overshadowing in defers

pkg/snapshot/pg/publisher.go

@@ -110,6 +110,7 @@ func (p *publisher) PublishHeader(header *types.Header) (err error) {
 		return err
 	}
 	tx := pubTx{snapTx, nil}
+	// we must avoid overshadowing the `err`
 	defer func() {
 		err = snapt.CommitOrRollback(tx, err)
 		if err != nil {
@@ -117,7 +118,7 @@ func (p *publisher) PublishHeader(header *types.Header) (err error) {
 		}
 	}()
 
-	if err := tx.publishIPLD(headerNode.Cid(), headerNode.RawData(), header.Number); err != nil {
+	if err = tx.publishIPLD(headerNode.Cid(), headerNode.RawData(), header.Number); err != nil {
 		return err
 	}
 

pkg/snapshot/service.go

@@ -200,8 +200,12 @@ func (s *Service) createSnapshot(ctx context.Context, it trie.NodeIterator, head
 	if err != nil {
 		return err
 	}
+	// we must avoid overshadowing the `err`
 	defer func() {
 		err = CommitOrRollback(tx, err)
+		if err != nil {
+			log.Errorf("CommitOrRollback failed: %s", err)
+		}
 	}()
 
 	// path (from recovery dump) to be seeked on recovery