Use groupcache pool for state db access #91

i-norden · 2021-08-13T12:56:01Z

ashwinphatak commented

2021-08-13 12:56:01 +00:00

(Migrated from github.com)

Part of https://github.com/vulcanize/ops/issues/63

i-norden approved these changes 2021-09-03 15:05:43 +00:00

i-norden left a comment

LGTM, couldn't find anything to comment on

pkg/eth/backend.go

i-norden commented

2021-09-03 14:53:21 +00:00

I can't find anything useful to comment on, but we could clean up some of the imports here and elsewhere so that it remains three sections for these three types

standard lib

external deps

internal deps

I can't find anything useful to comment on, but we could clean up some of the imports here and elsewhere so that it remains three sections for these three types > standard lib > external deps > internal deps

i-norden commented

2021-09-03 15:41:51 +00:00

looks like build is failing due to using local replace of the ipld-eth-indexer dependency, which we are moving away from in https://github.com/vulcanize/ipld-eth-server/pull/92

Also need to cut a new release of ipfs-ethdb with the groupcache stuff in it, as you know.

looks like build is failing due to using local replace of the ipld-eth-indexer dependency, which we are moving away from in https://github.com/vulcanize/ipld-eth-server/pull/92 Also need to cut a new release of ipfs-ethdb with the groupcache stuff in it, as you know.

arijitAD (Migrated from github.com) reviewed 2021-09-21 08:29:30 +00:00

pkg/eth/backend.go

arijitAD (Migrated from github.com) commented

2021-09-21 08:29:30 +00:00

Done

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#91