GQL API for getStorageAt and getLogs #77

i-norden · 2021-06-29T07:02:27Z

ashwinphatak commented

2021-06-29 07:02:27 +00:00

(Migrated from github.com)

Part of https://github.com/vulcanize/ipld-eth-server/issues/68. Supersedes https://github.com/vulcanize/ipld-eth-server/pull/69

i-norden approved these changes 2021-07-04 16:20:25 +00:00

i-norden left a comment

LGTM. Only issue is in regards to handling the decoding of 2718 typed transactions, which could perhaps be handled as part of https://github.com/vulcanize/ipld-eth-server/issues/78 instead of here.

pkg/graphql/graphql.go

i-norden commented

2021-07-04 16:02:37 +00:00

For compatibility with EIP-2718 enveloped transactions and receipts (EIP-2930 access list and EIP-1559 dynamic fee) we can no longer use RLP encoding/decoding, we instead need to use the MarshalBinary and UnmarshalBinary methods for receipts and transactions.

Related issue and more info here: https://github.com/vulcanize/ipld-eth-server/issues/78#issuecomment-873616604.

For compatibility with EIP-2718 enveloped transactions and receipts (EIP-2930 access list and EIP-1559 dynamic fee) we can no longer use RLP encoding/decoding, we instead need to use the `MarshalBinary` and `UnmarshalBinary` methods for receipts and transactions. Related issue and more info here: https://github.com/vulcanize/ipld-eth-server/issues/78#issuecomment-873616604.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#77