cerc-io/ipld-eth-server
12
0 Fork 1
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 37 Wiki Activity

251: Remove uses of canonical_header_hash() and get_storage_at() fns in light of v5 schema updates. #253

Merged
telackey merged 3 commits from telackey/251 into v5 2023-08-03 19:44:58 +00:00
Conversation 2 Commits 3 Files Changed 1
+187 -119
telackey commented 2023-07-31 23:34:51 +00:00
Contributor
Copy link
Copy source

This refactors a number of queries in light of v5 schema updates. In particular it removes all uses of the canonical_header_hash() and get_storage_at() functions.

I have EXPLAIN ANALYZED all the new queries, and they seem reasonably efficient with no major red flags, though undoubtedly efficiency can be improved with more analysis.

This refactors a number of queries in light of v5 schema updates. In particular it removes all uses of the canonical_header_hash() and get_storage_at() functions. I have `EXPLAIN ANALYZED` all the new queries, and they seem reasonably efficient with no major red flags, though undoubtedly efficiency can be improved with more analysis.
i-norden approved these changes 2023-08-03 12:45:22 +00:00
i-norden left a comment
Member
Copy link
Copy source

LGTM, thanks!

LGTM, thanks!
dboreham approved these changes 2023-08-03 13:30:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
dboreham
Labels
Clear labels
Epic
Integration tests
bug
Something isn't working
 critical
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 v5
wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#253