[v4] update to v1.11.5 #236

2023-03-31T14:33:01Z

i-norden commented

2023-03-31 14:33:01 +00:00

and use internal concurrent iterator pkg
and do Support effectiveGasPrice on dynamicFee receipts (#79)

* and use internal concurrent iterator pkg * and do #79

i-norden commented

2023-04-01 17:07:52 +00:00

Unit tests were failing for two reasons:

This repo was still using an outdated custom running environment with go 1.18 (thanks to @roysc for identifying this)
After that was resolved, an error remained due to the need to replace new(trie.Trie) with trie.NewEmpty(nil) in v1.11+ version of geth

Integration tests are still failing, looking into it

Unit tests were failing for two reasons: 1. This repo was still using an outdated custom running environment with go 1.18 (thanks to @roysc for identifying this) 2. After that was resolved, an error remained due to the need to replace `new(trie.Trie)` with `trie.NewEmpty(nil)` in v1.11+ version of geth Integration tests are still failing, looking into it

i-norden commented

2023-04-01 17:49:46 +00:00

For the integration test, the issues were:

need to use e62830c982d4dfc5f3c1c2b12c1754a7e9b538f1 of mshaw_hack stack-orchestrator repo (this hack needs to be replaced and imo should never have existed, the real stack-orchestrator should be fixed and used instead of kicking the can down the road and causing obscure errors as a result)
need to use 6c00c38cc4e1db6f7c4cecbb62fdfd540fba50d6 of ipld-eth-db to have access to get_storage_at_by_hash stored procedure
now need effectiveGatPrice in receipts returned by GetTransactionReceipt https://github.com/cerc-io/ipld-eth-server/issues/79

For the integration test, the issues were: 1. need to use e62830c982d4dfc5f3c1c2b12c1754a7e9b538f1 of mshaw_hack stack-orchestrator repo (this hack needs to be replaced and imo should never have existed, the real stack-orchestrator should be fixed and used instead of kicking the can down the road and causing obscure errors as a result) 2. need to use 6c00c38cc4e1db6f7c4cecbb62fdfd540fba50d6 of ipld-eth-db to have access to `get_storage_at_by_hash` stored procedure 3. now need effectiveGatPrice in receipts returned by `GetTransactionReceipt` https://github.com/cerc-io/ipld-eth-server/issues/79

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#236