cerc-io/ipld-eth-server
12
0
Fork 1
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 37 Wiki Activity

upgrade ipld-eth-indexer from v0.2.0-alpha to v0.5.0-alpha #16

Merged
ramilexe merged 5 commits from update_deps into master 2020-10-20 18:58:40 +00:00
Conversation 7 Commits 5 Files Changed 13
+736 -61
ramilexe commented 2020-10-20 15:49:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Updated ipld-eth-indexer dependency.

All tests passed:

/srv/vdb/ipld-eth-server/bin/ginkgo -r --skipPackage=integration_tests,integration
Running Suite: eth ipld server eth suite test
=============================================
Random Seed: 1603208860
Will run 22 of 22 specs

••••••••••••••••••••••
Ran 22 of 22 Specs in 0.555 seconds
SUCCESS! -- 22 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 3.205441886s
Test Suite Passed
Updated `ipld-eth-indexer` dependency. All tests passed: ``` /srv/vdb/ipld-eth-server/bin/ginkgo -r --skipPackage=integration_tests,integration Running Suite: eth ipld server eth suite test ============================================= Random Seed: 1603208860 Will run 22 of 22 specs •••••••••••••••••••••• Ran 22 of 22 Specs in 0.555 seconds SUCCESS! -- 22 Passed | 0 Failed | 0 Pending | 0 Skipped PASS Ginkgo ran 1 suite in 3.205441886s Test Suite Passed ```
db/migrations/00002_create_nodes_table.sql
i-norden commented 2020-10-20 15:57:21 +00:00
Member
Copy Link
Copy Source

chain_id needs to be added as a separate migration so that we can apply it on the current database schema e.g. https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql

chain_id needs to be added as a separate migration so that we can apply it on the current database schema e.g. https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql
ramilexe (Migrated from github.com) reviewed 2020-10-20 16:00:39 +00:00
db/migrations/00002_create_nodes_table.sql
ramilexe (Migrated from github.com) commented 2020-10-20 16:00:39 +00:00
Copy Link
Copy Source

good point, will do. But here https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L14 I think it should be "ADD COLUMN" not "DROP"?

good point, will do. But here https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L14 I think it should be "ADD COLUMN" not "DROP"?
db/migrations/00002_create_nodes_table.sql
i-norden commented 2020-10-20 16:01:48 +00:00
Member
Copy Link
Copy Source

No the DROP is correct, those is the down migrations which are reversing the up

No the DROP is correct, those is the `down` migrations which are reversing the `up`
db/migrations/00002_create_nodes_table.sql
i-norden commented 2020-10-20 16:02:08 +00:00
Member
Copy Link
Copy Source

It's reversing https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L9

It's reversing https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L9
ramilexe (Migrated from github.com) reviewed 2020-10-20 17:51:40 +00:00
db/migrations/00002_create_nodes_table.sql
ramilexe (Migrated from github.com) commented 2020-10-20 17:51:40 +00:00
Copy Link
Copy Source

@i-norden fixed it

@i-norden fixed it
i-norden approved these changes 2020-10-20 17:53:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
ramilexe
Labels
Clear labels
Epic
Integration tests
bug
Something isn't working
 critical
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 v5
wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#16