Update to geth 1.11.5-statediff-v5 #238

roysc · 2023-04-12T14:28:58Z

roysc commented

2023-04-12 14:28:58 +00:00

An extensive refactor to update Geth interfaces and update for compatibility with the v5 schema.

Depends on:

https://github.com/cerc-io/ipld-eth-db/pull/134
https://github.com/cerc-io/ipld-eth-statedb/pull/18
https://github.com/cerc-io/eth-ipfs-state-validator/pull/72
gap-filler - ~~we need to confirm if we can deprecate and remove it (https://github.com/vulcanize/gap-filler/issues/11) or bring into cerc (in which case I will wait until that's done to open a PR)~~ removed
https://github.com/cerc-io/ipld-eth-statedb/pull/19
https://github.com/cerc-io/eth-ipfs-state-validator/pull/73
- which depends on https://github.com/cerc-io/go-ethereum/pull/383

An extensive refactor to update Geth interfaces and update for compatibility with the v5 schema. Depends on: - https://github.com/cerc-io/ipld-eth-db/pull/134 - https://github.com/cerc-io/ipld-eth-statedb/pull/18 - https://github.com/cerc-io/eth-ipfs-state-validator/pull/72 - `gap-filler` - <strike>we need to confirm if we can deprecate and remove it (https://github.com/vulcanize/gap-filler/issues/11) or bring into cerc (in which case I will wait until that's done to open a PR)</strike> removed - https://github.com/cerc-io/ipld-eth-statedb/pull/19 - https://github.com/cerc-io/eth-ipfs-state-validator/pull/73 - which depends on https://github.com/cerc-io/go-ethereum/pull/383

i-norden reviewed 2023-04-12 14:28:58 +00:00

i-norden reviewed 2023-04-25 00:54:33 +00:00

i-norden left a comment

Looking good, I reviewed the other two PRs. As for the gap-filler, we can 100% sunset that repo. The used functionality has since been embedded here, and all of that is eventually to be deprecated by https://github.com/cerc-io/issue_tracking/issues/11.

i-norden approved these changes 2023-05-26 17:26:06 +00:00

i-norden left a comment

Looks great, this represents a tremendous amount of work. I've reviewed this line for line and haven't caught anything to fix. In the future we can consider if it is possible to break these major upgrades up into smaller pieces of work for PRs, but I am doubtful it is feasible to do so in such a way where the intermediate states have passing tests..

i-norden commented

2023-05-26 18:26:50 +00:00

Actually just a few nitpicks:

Lets remove https://github.com/cerc-io/ipld-eth-server/blob/roy/v5-dev/environments/subscribeExample.toml
And let's add back in the spacing here or create a bullet point list for the endpoints: https://github.com/cerc-io/ipld-eth-server/pull/238/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 they are all clumped onto one line now.

Actually just a few nitpicks: Lets remove https://github.com/cerc-io/ipld-eth-server/blob/roy/v5-dev/environments/subscribeExample.toml And let's add back in the spacing here or create a bullet point list for the endpoints: https://github.com/cerc-io/ipld-eth-server/pull/238/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 they are all clumped onto one line now.

👍 1

i-norden reviewed 2023-05-26 18:31:00 +00:00

version/version.go

i-norden commented

2023-05-26 18:30:59 +00:00

Let's start at 5.0.0

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#238