cerc-io/ipld-eth-server
12
0
Fork 1
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 37 Wiki Activity

Update to geth 1.11.5-statediff-v5 #238

Merged
telackey merged 40 commits from roy/v5-dev into v5 2023-06-01 13:53:57 +00:00
Conversation 5 Commits 40 Files Changed 103
+6793 -22545
roysc commented 2023-04-12 14:28:58 +00:00
Owner
Copy Link
Copy Source

An extensive refactor to update Geth interfaces and update for compatibility with the v5 schema.

Depends on:

An extensive refactor to update Geth interfaces and update for compatibility with the v5 schema. Depends on: - https://github.com/cerc-io/ipld-eth-db/pull/134 - https://github.com/cerc-io/ipld-eth-statedb/pull/18 - https://github.com/cerc-io/eth-ipfs-state-validator/pull/72 - `gap-filler` - <strike>we need to confirm if we can deprecate and remove it (https://github.com/vulcanize/gap-filler/issues/11) or bring into cerc (in which case I will wait until that's done to open a PR)</strike> removed - https://github.com/cerc-io/ipld-eth-statedb/pull/19 - https://github.com/cerc-io/eth-ipfs-state-validator/pull/73 - which depends on https://github.com/cerc-io/go-ethereum/pull/383
i-norden left a comment
Member
Copy Link
Copy Source

Looking good, I reviewed the other two PRs. As for the gap-filler, we can 100% sunset that repo. The used functionality has since been embedded here, and all of that is eventually to be deprecated by https://github.com/cerc-io/issue_tracking/issues/11.

Looking good, I reviewed the other two PRs. As for the gap-filler, we can 100% sunset that repo. The used functionality has since been embedded here, and all of that is eventually to be deprecated by https://github.com/cerc-io/issue_tracking/issues/11.
i-norden approved these changes 2023-05-26 17:26:06 +00:00
i-norden left a comment
Member
Copy Link
Copy Source

Looks great, this represents a tremendous amount of work. I've reviewed this line for line and haven't caught anything to fix. In the future we can consider if it is possible to break these major upgrades up into smaller pieces of work for PRs, but I am doubtful it is feasible to do so in such a way where the intermediate states have passing tests..

Looks great, this represents a tremendous amount of work. I've reviewed this line for line and haven't caught anything to fix. In the future we can consider if it is possible to break these major upgrades up into smaller pieces of work for PRs, but I am doubtful it is feasible to do so in such a way where the intermediate states have passing tests..
i-norden commented 2023-05-26 18:26:50 +00:00
Member
Copy Link
Copy Source

Actually just a few nitpicks:

Lets remove https://github.com/cerc-io/ipld-eth-server/blob/roy/v5-dev/environments/subscribeExample.toml
And let's add back in the spacing here or create a bullet point list for the endpoints: https://github.com/cerc-io/ipld-eth-server/pull/238/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 they are all clumped onto one line now.

Actually just a few nitpicks: Lets remove https://github.com/cerc-io/ipld-eth-server/blob/roy/v5-dev/environments/subscribeExample.toml And let's add back in the spacing here or create a bullet point list for the endpoints: https://github.com/cerc-io/ipld-eth-server/pull/238/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 they are all clumped onto one line now.
👍 1
version/version.go
i-norden commented 2023-05-26 18:30:59 +00:00
Member
Copy Link
Copy Source

Let's start at 5.0.0

Let's start at 5.0.0
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
Labels
Clear labels
Epic
Integration tests
bug
Something isn't working
 critical
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 v5
wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#238