upgrade ipld-eth-indexer from v0.2.0-alpha to v0.5.0-alpha #16
No reviewers
Labels
No Label
bug
critical
documentation
duplicate
enhancement
Epic
good first issue
help wanted
Integration tests
invalid
question
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/ipld-eth-server#16
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "update_deps"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Updated
ipld-eth-indexer
dependency.All tests passed:
chain_id needs to be added as a separate migration so that we can apply it on the current database schema e.g. https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql
good point, will do. But here https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L14 I think it should be "ADD COLUMN" not "DROP"?
No the DROP is correct, those is the
down
migrations which are reversing theup
It's reversing https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L9
@i-norden fixed it
LGTM