upgrade ipld-eth-indexer from v0.2.0-alpha to v0.5.0-alpha #16

Merged
ramilexe merged 5 commits from update_deps into master 2020-10-20 18:58:40 +00:00
ramilexe commented 2020-10-20 15:49:08 +00:00 (Migrated from github.com)

Updated ipld-eth-indexer dependency.

All tests passed:

/srv/vdb/ipld-eth-server/bin/ginkgo -r --skipPackage=integration_tests,integration
Running Suite: eth ipld server eth suite test
=============================================
Random Seed: 1603208860
Will run 22 of 22 specs

••••••••••••••••••••••
Ran 22 of 22 Specs in 0.555 seconds
SUCCESS! -- 22 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 3.205441886s
Test Suite Passed
Updated `ipld-eth-indexer` dependency. All tests passed: ``` /srv/vdb/ipld-eth-server/bin/ginkgo -r --skipPackage=integration_tests,integration Running Suite: eth ipld server eth suite test ============================================= Random Seed: 1603208860 Will run 22 of 22 specs •••••••••••••••••••••• Ran 22 of 22 Specs in 0.555 seconds SUCCESS! -- 22 Passed | 0 Failed | 0 Pending | 0 Skipped PASS Ginkgo ran 1 suite in 3.205441886s Test Suite Passed ```
i-norden requested changes 2020-10-20 15:57:49 +00:00
Member

chain_id needs to be added as a separate migration so that we can apply it on the current database schema e.g. https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql

chain_id needs to be added as a separate migration so that we can apply it on the current database schema e.g. https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql
ramilexe (Migrated from github.com) reviewed 2020-10-20 16:00:39 +00:00
ramilexe (Migrated from github.com) commented 2020-10-20 16:00:39 +00:00

good point, will do. But here https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L14 I think it should be "ADD COLUMN" not "DROP"?

good point, will do. But here https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L14 I think it should be "ADD COLUMN" not "DROP"?
i-norden reviewed 2020-10-20 16:01:48 +00:00
Member

No the DROP is correct, those is the down migrations which are reversing the up

No the DROP is correct, those is the `down` migrations which are reversing the `up`
i-norden reviewed 2020-10-20 16:02:09 +00:00
Member
It's reversing https://github.com/vulcanize/ipld-eth-indexer/blob/master/db/migrations/00012_add_chain_id_to_nodes.sql#L9
ramilexe (Migrated from github.com) reviewed 2020-10-20 17:51:40 +00:00
ramilexe (Migrated from github.com) commented 2020-10-20 17:51:40 +00:00

@i-norden fixed it

@i-norden fixed it
i-norden reviewed 2020-10-20 17:53:27 +00:00
i-norden approved these changes 2020-10-20 17:53:48 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#16
No description provided.