Use prefix comparison for account selective statediffing #247

i-norden · 2022-06-22T11:00:39Z

prathamesh0 commented

2022-06-22 11:00:39 +00:00

(Migrated from github.com)

Part of https://github.com/vulcanize/go-ethereum/issues/29

Include intermediate nodes when having watched addresses
Check (intermediate | leaf) node paths as prefix to paths of watched addresses to filter out unwanted nodes

Part of https://github.com/vulcanize/go-ethereum/issues/29 - Include intermediate nodes when having watched addresses - Check (intermediate | leaf) node paths as prefix to paths of watched addresses to filter out unwanted nodes

❤️ 1

ashwinphatak (Migrated from github.com) approved these changes 2022-06-27 13:21:01 +00:00

i-norden approved these changes 2022-06-28 02:25:52 +00:00

i-norden left a comment

This LGTM! I reviewed the difference iterator a bit and it appears it would be a bit tricky to get it to respect the "descend" flag. Pruning away subtries is much less pertinent for a difference trie than it is when doing a complete trie snapshot but I think it is worth investigating further as a separate issue.

prathamesh0 (Migrated from github.com) reviewed 2022-06-28 05:02:41 +00:00

prathamesh0 commented

2022-06-28 06:20:16 +00:00

(Migrated from github.com)

This LGTM! I reviewed the difference iterator a bit and it appears it would be a bit tricky to get it to respect the "descend" flag. Pruning away subtries is much less pertinent for a difference trie than it is when doing a complete trie snapshot but I think it is worth investigating further as a separate issue.

Created https://github.com/vulcanize/go-ethereum/issues/252

> This LGTM! I reviewed the difference iterator a bit and it appears it would be a bit tricky to get it to respect the "descend" flag. Pruning away subtries is much less pertinent for a difference trie than it is when doing a complete trie snapshot but I think it is worth investigating further as a separate issue. Created https://github.com/vulcanize/go-ethereum/issues/252

❤️ 1

Sign in to join this conversation.

No reviewers

ashwinphatak

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#247