Add Foundry for Manual Integration Testing #208

2022-03-14T19:19:51Z

abdulrabbani00 commented

2022-03-14 19:19:51 +00:00

(Migrated from github.com)

This PR imbeds foundry into vulcanize-geth. Currently there is only one project under the foundry/projects directory. In the future, developers can add smart contract testing using foundry. Or they can simply leverage the local network created using the current project.

This PR imbeds foundry into `vulcanize-geth`. Currently there is only one project under the `foundry/projects` directory. In the future, developers can add smart contract testing using foundry. Or they can simply leverage the local network created using the current project.

i-norden reviewed

2022-03-15 20:08:39 +00:00

i-norden left a comment

This is great! Directions were easy to follow, and based on my limited test run it feels a lot faster than dapptools.

If you can go ahead and fix that linting error, which is left over from me, that'd be nice. Just need to remove makeLightNode func in cmd/geth/config.go.

Also we should target this PR to this branch: https://github.com/vulcanize/go-ethereum/tree/v1.10.16-statediff-v3

General workflow for merges and releases goes:

Feature/dev branch =PR=> Root versioned branch (e.g. 1.10.16-statediff-v2 or 1.10.16-statediff-v3)
Root versioned branch =Checkout=> Release branch (e.g. 1.10.16-statediff-2.0.1 or 1.10.16-statediff-3.0.3)
Cut release off Release branch
Root versioned branch =PR=> Root branch (aka statediff)
Which root versioned branch we maintain parity with on statediff is whatever major version we consider canonical at the time.

This is great! Directions were easy to follow, and based on my limited test run it feels a lot faster than dapptools. If you can go ahead and fix that linting error, which is left over from me, that'd be nice. Just need to remove `makeLightNode` func in cmd/geth/config.go. Also we should target this PR to this branch: https://github.com/vulcanize/go-ethereum/tree/v1.10.16-statediff-v3 General workflow for merges and releases goes: * Feature/dev branch =PR=> Root versioned branch (e.g. 1.10.16-statediff-v2 or 1.10.16-statediff-v3) * Root versioned branch =Checkout=> Release branch (e.g. 1.10.16-statediff-2.0.1 or 1.10.16-statediff-3.0.3) * Cut release off Release branch * Root versioned branch =PR=> Root branch (aka `statediff`) Which root versioned branch we maintain parity with on `statediff` is whatever major version we consider canonical at the time.

abdulrabbani00 commented

2022-03-15 20:21:09 +00:00

(Migrated from github.com)

@i-norden - Thanks for the insight, I made the updates. Going to let CI/CD run and then hopefully we can merge :D

abdulrabbani00 commented

2022-03-15 20:45:49 +00:00

(Migrated from github.com)

@i-norden - Can I get a final sign off please

i-norden approved these changes

2022-03-16 12:02:57 +00:00

i-norden left a comment

LGTM, thanks!

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#208