Statediff API to change addresses watched in direct indexing mode #194

i-norden · 2022-01-20T10:17:52Z

prathamesh0 commented

2022-01-20 10:17:52 +00:00

(Migrated from github.com)

Part of https://github.com/vulcanize/go-ethereum/issues/127

An API to perform following operations on the list of addresses to which the direct indexing is restricted:
- Add addresses
- Remove addresses
- Set the watched addresses
- Clear the watched addresses
Unit tests for the API
Make corresponding changes to watched_addresses table in the db
Load watched addresses from the db on startup
Add a fix and tests in builder for a non-watched address being removed

Part of https://github.com/vulcanize/go-ethereum/issues/127 - An API to perform following operations on the list of addresses to which the direct indexing is restricted: - Add addresses - Remove addresses - Set the watched addresses - Clear the watched addresses - Unit tests for the API - Make corresponding changes to watched_addresses table in the db - Load watched addresses from the db on startup - Add a fix and tests in builder for a non-watched address being removed

i-norden reviewed 2022-03-07 18:01:09 +00:00

i-norden left a comment

Looking great, a few comments mostly just things I need some clarification on. Thanks!

nikugogoi (Migrated from github.com) reviewed 2022-03-09 12:38:58 +00:00

nikugogoi (Migrated from github.com) reviewed 2022-03-09 12:44:25 +00:00

nikugogoi (Migrated from github.com) reviewed 2022-03-09 12:48:57 +00:00

nikugogoi (Migrated from github.com) reviewed 2022-03-09 12:59:04 +00:00

nikugogoi (Migrated from github.com) reviewed 2022-03-10 13:29:55 +00:00

nikugogoi (Migrated from github.com) reviewed 2022-03-10 13:30:12 +00:00

i-norden reviewed 2022-03-22 00:17:17 +00:00

i-norden approved these changes 2022-03-30 23:21:25 +00:00

i-norden left a comment

LGTM! It's unlikely we'll release any more off of the v2 version but we should go ahead and merge this if it doesn't require anything else. The last failing CI is an artifact.

prathamesh0 commented

2022-03-31 11:02:57 +00:00

(Migrated from github.com)

LGTM! It's unlikely we'll release any more off of the v2 version but we should go ahead and merge this if it doesn't require anything else. The last failing CI is an artifact.

Before merging this PR, we need a v2 ipld-eth-db release with the schema changes. There is an open PR for the same.

> LGTM! It's unlikely we'll release any more off of the v2 version but we should go ahead and merge this if it doesn't require anything else. The last failing CI is an artifact. Before merging this PR, we need a v2 `ipld-eth-db` release with the schema changes. There is an open [PR](https://github.com/vulcanize/ipld-eth-db/pull/44) for the same.

i-norden commented

2022-03-31 18:04:55 +00:00

@prathamesh0 thanks for the reminder! That's here: https://github.com/vulcanize/ipld-eth-db/releases/tag/v2.1.1

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#194