cerc-io/go-ethereum
18
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

README updates #186

Closed
justindotpub wants to merge 9 commits from jj-docs into statediff
pull from: jj-docs
merge into: cerc-io:statediff
Conversation 1 Commits 9 Files Changed 140 +15698 -274
justindotpub commented 2022-01-08 11:16:53 +00:00 (Migrated from github.com)
Copy Link
  • Remove references to --statediff.db.init option
  • Wrap --statediff.db option value in quotes
  • Point to vulcanize/statediff-migrations instead of no longer existing statediff/db directory
  • Bullets for options so they don't all appear on one line
- Remove references to `--statediff.db.init` option - Wrap `--statediff.db` option value in quotes - Point to vulcanize/statediff-migrations instead of no longer existing `statediff/db` directory - Bullets for options so they don't all appear on one line
i-norden commented 2022-01-08 18:50:01 +00:00
Member
Copy Link

Hi @justincjohnson thanks for spotting these issues!

A little bit of clarification, and this should be added the README as well to prevent confusion in the future- apologies for that. We are currently maintaining two branches, one for our v0.2.x version of the DB (v1.10.14-statediff-0.0.29) schema and one for our v0.3.x version of the DB (v1.10.11-statediff-0.1.0). This base "statediff" branch is meant to contain the current latest stable release, but since we are maintaining two stable releases until our v2 => v3 db merge is complete this branch has grown stale.

So a few of these issue are already resolved on v1.10.14-statediff-0.0.29 and v1.10.11-statediff-0.1.0. I'll go ahead and rebase statediff to v1.10.14-statediff-0.0.29, and have it continue to track the 0.0.x version until we can move everything over to 0.1.x. If you can move this PR to be against v1.10.14-statediff that would be appreciated, we don't merge into this branch except to update it to a new tagged release version.

Thanks and again sorry for the confusion. Will work on #188 to try and make it easier to orient oneself in this repo in the future.

Hi @justincjohnson thanks for spotting these issues! A little bit of clarification, and this should be added the README as well to prevent confusion in the future- apologies for that. We are currently maintaining two branches, one for our [v0.2.x](https://github.com/vulcanize/ipld-eth-db/releases/tag/v0.2.1) version of the DB (v1.10.14-statediff-0.0.29) schema and one for our [v0.3.x](https://github.com/vulcanize/ipld-eth-db/releases/tag/v0.3.3) version of the DB (v1.10.11-statediff-0.1.0). This base "statediff" branch is meant to contain the current latest stable release, but since we are maintaining two stable releases until our v2 => v3 db merge is complete this branch has grown stale. So a few of these issue are already resolved on v1.10.14-statediff-0.0.29 and v1.10.11-statediff-0.1.0. I'll go ahead and rebase `statediff` to v1.10.14-statediff-0.0.29, and have it continue to track the 0.0.x version until we can move everything over to 0.1.x. If you can move this PR to be against `v1.10.14-statediff` that would be appreciated, we don't merge into this branch except to update it to a new tagged release version. Thanks and again sorry for the confusion. Will work on #188 to try and make it easier to orient oneself in this repo in the future.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
critical

   
duplicate

   
enhancement

   
epic

   
help wanted

   
in progress

   
invalid

   
low priority

   
question

   
rebase

   
v1

   
v5

   
wontfix
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#186
No description provided.
Delete Branch "jj-docs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?