cerc-io/go-ethereum
13
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

Add Foundry for Manual Integration Testing #208

Merged
abdulrabbani00 merged 4 commits from feature/gh-208-add-foundry into v1.10.16-statediff-v3 2022-03-16 12:04:02 +00:00
Conversation 2 Commits 4 Files Changed 14 +445 -14
abdulrabbani00 commented 2022-03-14 19:19:51 +00:00 (Migrated from github.com)
Copy Link

This PR imbeds foundry into vulcanize-geth. Currently there is only one project under the foundry/projects directory. In the future, developers can add smart contract testing using foundry. Or they can simply leverage the local network created using the current project.

This PR imbeds foundry into `vulcanize-geth`. Currently there is only one project under the `foundry/projects` directory. In the future, developers can add smart contract testing using foundry. Or they can simply leverage the local network created using the current project.
i-norden reviewed 2022-03-15 20:08:39 +00:00
i-norden left a comment
Member
Copy Link

This is great! Directions were easy to follow, and based on my limited test run it feels a lot faster than dapptools.

If you can go ahead and fix that linting error, which is left over from me, that'd be nice. Just need to remove makeLightNode func in cmd/geth/config.go.

Also we should target this PR to this branch: https://github.com/vulcanize/go-ethereum/tree/v1.10.16-statediff-v3

General workflow for merges and releases goes:

  • Feature/dev branch =PR=> Root versioned branch (e.g. 1.10.16-statediff-v2 or 1.10.16-statediff-v3)
  • Root versioned branch =Checkout=> Release branch (e.g. 1.10.16-statediff-2.0.1 or 1.10.16-statediff-3.0.3)
  • Cut release off Release branch
  • Root versioned branch =PR=> Root branch (aka statediff)
    Which root versioned branch we maintain parity with on statediff is whatever major version we consider canonical at the time.
This is great! Directions were easy to follow, and based on my limited test run it feels a lot faster than dapptools. If you can go ahead and fix that linting error, which is left over from me, that'd be nice. Just need to remove `makeLightNode` func in cmd/geth/config.go. Also we should target this PR to this branch: https://github.com/vulcanize/go-ethereum/tree/v1.10.16-statediff-v3 General workflow for merges and releases goes: * Feature/dev branch =PR=> Root versioned branch (e.g. 1.10.16-statediff-v2 or 1.10.16-statediff-v3) * Root versioned branch =Checkout=> Release branch (e.g. 1.10.16-statediff-2.0.1 or 1.10.16-statediff-3.0.3) * Cut release off Release branch * Root versioned branch =PR=> Root branch (aka `statediff`) Which root versioned branch we maintain parity with on `statediff` is whatever major version we consider canonical at the time.
abdulrabbani00 commented 2022-03-15 20:21:09 +00:00 (Migrated from github.com)
Copy Link

@i-norden - Thanks for the insight, I made the updates. Going to let CI/CD run and then hopefully we can merge :D

@i-norden - Thanks for the insight, I made the updates. Going to let CI/CD run and then hopefully we can merge :D
abdulrabbani00 commented 2022-03-15 20:45:49 +00:00 (Migrated from github.com)
Copy Link

@i-norden - Can I get a final sign off please

@i-norden - Can I get a final sign off please
i-norden approved these changes 2022-03-16 12:02:57 +00:00
i-norden left a comment
Member
Copy Link

LGTM, thanks!

LGTM, thanks!
Sign in to join this conversation.
Reviewers
No reviewers
i-norden
Labels
Clear labels   
bug

   
critical

   
duplicate

   
enhancement

   
epic

   
help wanted

   
in progress

   
invalid

   
low priority

   
question

   
rebase

   
v1

   
v5

   
wontfix
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#208
No description provided.
Delete Branch "feature/gh-208-add-foundry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?