README updates #186

2022-01-08T11:16:53Z

justindotpub commented

2022-01-08 11:16:53 +00:00

(Migrated from github.com)

Remove references to --statediff.db.init option
Wrap --statediff.db option value in quotes
Point to vulcanize/statediff-migrations instead of no longer existing statediff/db directory
Bullets for options so they don't all appear on one line

- Remove references to `--statediff.db.init` option - Wrap `--statediff.db` option value in quotes - Point to vulcanize/statediff-migrations instead of no longer existing `statediff/db` directory - Bullets for options so they don't all appear on one line

i-norden commented

2022-01-08 18:50:01 +00:00

Hi @justincjohnson thanks for spotting these issues!

A little bit of clarification, and this should be added the README as well to prevent confusion in the future- apologies for that. We are currently maintaining two branches, one for our v0.2.x version of the DB (v1.10.14-statediff-0.0.29) schema and one for our v0.3.x version of the DB (v1.10.11-statediff-0.1.0). This base "statediff" branch is meant to contain the current latest stable release, but since we are maintaining two stable releases until our v2 => v3 db merge is complete this branch has grown stale.

So a few of these issue are already resolved on v1.10.14-statediff-0.0.29 and v1.10.11-statediff-0.1.0. I'll go ahead and rebase statediff to v1.10.14-statediff-0.0.29, and have it continue to track the 0.0.x version until we can move everything over to 0.1.x. If you can move this PR to be against v1.10.14-statediff that would be appreciated, we don't merge into this branch except to update it to a new tagged release version.

Thanks and again sorry for the confusion. Will work on #188 to try and make it easier to orient oneself in this repo in the future.

Hi @justincjohnson thanks for spotting these issues! A little bit of clarification, and this should be added the README as well to prevent confusion in the future- apologies for that. We are currently maintaining two branches, one for our [v0.2.x](https://github.com/vulcanize/ipld-eth-db/releases/tag/v0.2.1) version of the DB (v1.10.14-statediff-0.0.29) schema and one for our [v0.3.x](https://github.com/vulcanize/ipld-eth-db/releases/tag/v0.3.3) version of the DB (v1.10.11-statediff-0.1.0). This base "statediff" branch is meant to contain the current latest stable release, but since we are maintaining two stable releases until our v2 => v3 db merge is complete this branch has grown stale. So a few of these issue are already resolved on v1.10.14-statediff-0.0.29 and v1.10.11-statediff-0.1.0. I'll go ahead and rebase `statediff` to v1.10.14-statediff-0.0.29, and have it continue to track the 0.0.x version until we can move everything over to 0.1.x. If you can move this PR to be against `v1.10.14-statediff` that would be appreciated, we don't merge into this branch except to update it to a new tagged release version. Thanks and again sorry for the confusion. Will work on #188 to try and make it easier to orient oneself in this repo in the future.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#186