cerc-io/fixturenet-laconicd-stack
17
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Use a tag for laconicd repository #9

Open
prathamesh wants to merge 1 commits from pm-use-tag into main
pull from: pm-use-tag
merge into: cerc-io:main
Conversation 0 Commits 1 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
stack-orchestrator/stacks/fixturenet-laconicd/stack.yml
View File

@ -2,7 +2,7 @@ version: "1.0"
name: fixturenet-laconicd name: fixturenet-laconicd
description: "A laconicd fixturenet" description: "A laconicd fixturenet"
repos: repos:
- git.vdb.to/cerc-io/laconicd - git.vdb.to/cerc-io/laconicd@v0.1.5
dboreham commented 2024-08-05 12:49:08 +00:00
Review
Copy Link

Please consider not doing this. The ref for any stack repo can be passed on the stack orchestrator command line like: --branches <repo>@<ref>, see: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/stack_orchestrator/repos/setup_repositories.py#L187
This allows the stack to define only the repositories and removes the need for the stack file to be constantly maintained (or conversely ossify referring to a stale version).

Please consider not doing this. The ref for any stack repo can be passed on the stack orchestrator command line like: `--branches <repo>@<ref>`, see: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/stack_orchestrator/repos/setup_repositories.py#L187 This allows the stack to define only the repositories and removes the need for the stack file to be constantly maintained (or conversely ossify referring to a stale version).
containers: containers:
- cerc/laconicd - cerc/laconicd
pods: pods: