cerc-io/fixturenet-laconicd-stack
11
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Use a tag for laconicd repository #9

Open
prathamesh wants to merge 1 commits from pm-use-tag into main
pull from: pm-use-tag
merge into: :main
Conversation 1 Commits 1 Files Changed 1
+1 -1
prathamesh commented 2024-08-05 12:44:10 +00:00
Member
Copy Link
Copy Source

Part of laconicd testnet validator enrollment

Part of [laconicd testnet validator enrollment](https://www.notion.so/laconicd-testnet-validator-enrollment-6fc1d3cafcc64fef8c5ed3affa27c675)
prathamesh added 1 commit 2024-08-05 12:44:11 +00:00
Use a tag for laconicd repository ecbbb4e559
stack-orchestrator/stacks/fixturenet-laconicd/stack.yml
@@ -3,3 +3,3 @@
description: "A laconicd fixturenet"
repos:
- git.vdb.to/cerc-io/laconicd
- git.vdb.to/cerc-io/laconicd@v0.1.5
dboreham commented 2024-08-05 12:49:08 +00:00
First-time contributor
Copy Link
Copy Source

Please consider not doing this. The ref for any stack repo can be passed on the stack orchestrator command line like: --branches <repo>@<ref>, see: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/stack_orchestrator/repos/setup_repositories.py#L187
This allows the stack to define only the repositories and removes the need for the stack file to be constantly maintained (or conversely ossify referring to a stale version).

Please consider not doing this. The ref for any stack repo can be passed on the stack orchestrator command line like: `--branches <repo>@<ref>`, see: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/stack_orchestrator/repos/setup_repositories.py#L187 This allows the stack to define only the repositories and removes the need for the stack file to be constantly maintained (or conversely ossify referring to a stale version).
This pull request has changes conflicting with the target branch.
  • stack-orchestrator/stacks/fixturenet-laconicd/stack.yml
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin pm-use-tag:pm-use-tag
git checkout pm-use-tag
Sign in to join this conversation.
Reviewers
No Reviewers
dboreham
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/fixturenet-laconicd-stack#9