Use a tag for laconicd repository #9

prathamesh · 2024-08-05T12:44:10Z

prathamesh commented

2024-08-05 12:44:10 +00:00

Part of laconicd testnet validator enrollment

Part of [laconicd testnet validator enrollment](https://www.notion.so/laconicd-testnet-validator-enrollment-6fc1d3cafcc64fef8c5ed3affa27c675)

prathamesh added 1 commit 2024-08-05 12:44:11 +00:00

Use a tag for laconicd repository ecbbb4e559

dboreham reviewed 2024-08-05 12:49:08 +00:00

stack-orchestrator/stacks/fixturenet-laconicd/stack.yml

						
				@ -3,3 +3,3 @@

				description: "A laconicd fixturenet"

				repos:

				  - git.vdb.to/cerc-io/laconicd

				  - git.vdb.to/cerc-io/laconicd@v0.1.5

dboreham commented

2024-08-05 12:49:08 +00:00

Please consider not doing this. The ref for any stack repo can be passed on the stack orchestrator command line like: --branches <repo>@<ref>, see: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/stack_orchestrator/repos/setup_repositories.py#L187
This allows the stack to define only the repositories and removes the need for the stack file to be constantly maintained (or conversely ossify referring to a stale version).

Please consider not doing this. The ref for any stack repo can be passed on the stack orchestrator command line like: `--branches <repo>@<ref>`, see: https://git.vdb.to/cerc-io/stack-orchestrator/src/branch/main/stack_orchestrator/repos/setup_repositories.py#L187 This allows the stack to define only the repositories and removes the need for the stack file to be constantly maintained (or conversely ossify referring to a stale version).

This pull request has changes conflicting with the target branch.