cerc-io/eth-statediff-service
11
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor to use plugeth-statediff #1

Merged
roysc merged 19 commits from refactor-use-plugin into v5 2023-09-28 04:04:01 +00:00
Conversation 5 Commits 19 Files Changed 52
+726 -3880
roysc commented 2023-08-25 14:23:08 +00:00
Owner
Copy Link
Copy Source
  • Updates to the v5 schema, by linking the statediff plugin (as of this branch cerc-io/plugeth-statediff#15). This replaces the existing builder code.
  • Adds basic CI workflows
  • Updates Docker config and docs, cleans up some things
* Updates to the v5 schema, by linking the statediff plugin (as of this branch https://git.vdb.to/cerc-io/plugeth-statediff/pulls/15). This replaces the existing builder code. * Adds basic CI workflows * Updates Docker config and docs, cleans up some things
roysc added 6 commits 2023-08-25 14:23:09 +00:00
swap geth-statediff for plugeth-statediff f6fa9ad72b
refactor & use plugin builder b9cba4c605 
- removes StateTrieAt, we can no longer return a full trie without inner nodes
replace prerun options with run command e49839f859
update docs & config 1003fe4eea
docker updates 2708518798 
rm makefile
[wip] update mods 7b47871269
roysc marked the pull request as work in progress 2023-08-25 14:42:02 +00:00
roysc marked the pull request as ready for review 2023-08-29 13:08:35 +00:00
roysc marked the pull request as work in progress 2023-08-29 13:48:40 +00:00
roysc commented 2023-08-29 13:49:33 +00:00
Author
Owner
Copy Link
Copy Source

Marking this WIP again, as the CI workflows need to be migrated.

Marking this WIP again, as the CI workflows need to be migrated.
roysc commented 2023-08-29 14:01:44 +00:00
Author
Owner
Copy Link
Copy Source

I've realized this should have been built on v4 instead of master. Let me rebase it as well.

I've realized this should have been built on `v4` instead of `master`. Let me rebase it as well.
roysc force-pushed refactor-use-plugin from 7b47871269 to b91e854974 2023-09-01 20:30:41 +00:00 Compare
roysc marked the pull request as ready for review 2023-09-01 20:46:47 +00:00
roysc added 1 commit 2023-09-02 11:46:28 +00:00
nit to trigger CI
Tests / Run integration tests (pull_request) Failing after 3h8m50s
Details
e00045cd70
roysc added 1 commit 2023-09-03 05:18:45 +00:00
time out tests
Tests / Run integration tests (pull_request) Has been cancelled
Details
247a081994
roysc added 1 commit 2023-09-03 08:09:42 +00:00
run server in same step
Tests / Run integration tests (pull_request) Failing after 3m35s
Details
9be7a19e4e
roysc added 1 commit 2023-09-03 08:52:51 +00:00
wait before req
Tests / Run integration tests (pull_request) Successful in 3m46s
Details
02f5301729
roysc added 1 commit 2023-09-03 09:00:31 +00:00
cleanup
Tests / Run integration tests (pull_request) Successful in 3m47s
Details
fdf1e6c031
roysc requested review from i-norden 2023-09-03 09:43:09 +00:00
roysc requested review from telackey 2023-09-07 02:52:42 +00:00
telackey approved these changes 2023-09-07 03:07:52 +00:00
telackey left a comment
Contributor
Copy Link
Copy Source

I know this is a big one, but LGTM.

I know this is a big one, but LGTM.
telackey commented 2023-09-25 22:53:19 +00:00
Contributor
Copy Link
Copy Source

Any reason not to merge this?

Any reason not to merge this?
roysc was assigned by telackey 2023-09-25 22:53:33 +00:00
roysc commented 2023-09-26 10:21:03 +00:00
Author
Owner
Copy Link
Copy Source

@telackey yeah, need to update go.mod after cerc-io/plugeth-statediff#15 is merged

@telackey yeah, need to update go.mod after https://git.vdb.to/cerc-io/plugeth-statediff/pulls/15 is merged
roysc added 4 commits 2023-09-27 13:57:14 +00:00
move this to plugin utils 06fb10e209
cleanup e16e587d2b
update deps bd8de5a7d3
update plugin
Tests / Run integration tests (pull_request) Successful in 4m46s
Details
c80cb409ad
roysc added 1 commit 2023-09-27 15:00:30 +00:00
note
Tests / Run integration tests (pull_request) Successful in 3m39s
Details
4b04e07d1d
roysc added 1 commit 2023-09-28 03:57:27 +00:00
update plugin
Tests / Run integration tests (pull_request) Successful in 4m28s
Details
cc34027b9b
roysc merged commit a5125c706c into v5 2023-09-28 04:04:01 +00:00
roysc deleted branch refactor-use-plugin 2023-09-28 04:04:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
telackey
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex cerccicd ericlewis i-norden (Ian Norden) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees roysc
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/eth-statediff-service#1