cerc-io/eth-statediff-compliance
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add script for updating go.mod to use local plugeth-statediff #3

Merged
roysc merged 5 commits from telackey/ci into main 2023-09-27 07:48:33 +00:00
Conversation 1 Commits 5 Files Changed 4
+41 -16
telackey commented 2023-09-27 01:13:07 +00:00
Contributor
Copy Link
Copy Source
❯ scripts/update-mod.sh ../plugeth-statediff dumpdiff-geth/
github.com/cerc-io/eth-testing=git.vdb.to/cerc-io/eth-testing@v0.3.1

❯ scripts/update-mod.sh ../plugeth-statediff dumpdiff-plugeth
github.com/cerc-io/plugeth-statediff=/home/telackey/cerc/plugeth-statediff
github.com/cerc-io/eth-iterator-utils=git.vdb.to/cerc-io/eth-iterator-utils@v0.1.2
github.com/cerc-io/eth-testing=git.vdb.to/cerc-io/eth-testing@v0.3.1
github.com/ethereum/go-ethereum=git.vdb.to/cerc-io/plugeth@v0.0.0-20230808125822-691dc334fab1
github.com/openrelayxyz/plugeth-utils=git.vdb.to/cerc-io/plugeth-utils@v0.0.0-20230706160122-cd41de354c46

❯ scripts/update-mod.sh ../plugeth-statediff dumpdiff-plugeth-parallel/
github.com/cerc-io/plugeth-statediff=/home/telackey/cerc/plugeth-statediff
github.com/cerc-io/eth-iterator-utils=git.vdb.to/cerc-io/eth-iterator-utils@v0.1.2
github.com/cerc-io/eth-testing=git.vdb.to/cerc-io/eth-testing@v0.3.1
github.com/ethereum/go-ethereum=git.vdb.to/cerc-io/plugeth@v0.0.0-20230808125822-691dc334fab1
github.com/openrelayxyz/plugeth-utils=git.vdb.to/cerc-io/plugeth-utils@v0.0.0-20230706160122-cd41de354c46
``` ❯ scripts/update-mod.sh ../plugeth-statediff dumpdiff-geth/ github.com/cerc-io/eth-testing=git.vdb.to/cerc-io/eth-testing@v0.3.1 ❯ scripts/update-mod.sh ../plugeth-statediff dumpdiff-plugeth github.com/cerc-io/plugeth-statediff=/home/telackey/cerc/plugeth-statediff github.com/cerc-io/eth-iterator-utils=git.vdb.to/cerc-io/eth-iterator-utils@v0.1.2 github.com/cerc-io/eth-testing=git.vdb.to/cerc-io/eth-testing@v0.3.1 github.com/ethereum/go-ethereum=git.vdb.to/cerc-io/plugeth@v0.0.0-20230808125822-691dc334fab1 github.com/openrelayxyz/plugeth-utils=git.vdb.to/cerc-io/plugeth-utils@v0.0.0-20230706160122-cd41de354c46 ❯ scripts/update-mod.sh ../plugeth-statediff dumpdiff-plugeth-parallel/ github.com/cerc-io/plugeth-statediff=/home/telackey/cerc/plugeth-statediff github.com/cerc-io/eth-iterator-utils=git.vdb.to/cerc-io/eth-iterator-utils@v0.1.2 github.com/cerc-io/eth-testing=git.vdb.to/cerc-io/eth-testing@v0.3.1 github.com/ethereum/go-ethereum=git.vdb.to/cerc-io/plugeth@v0.0.0-20230808125822-691dc334fab1 github.com/openrelayxyz/plugeth-utils=git.vdb.to/cerc-io/plugeth-utils@v0.0.0-20230706160122-cd41de354c46 ```
telackey added 2 commits 2023-09-27 01:13:11 +00:00
Add script for using local plugeth-statediff. b5d3ceba22
Add clean
Test / Run unit tests (pull_request) Successful in 12m48s
Details
62e44d36dd
telackey requested review from roysc 2023-09-27 01:13:19 +00:00
telackey self-assigned this 2023-09-27 01:13:26 +00:00
telackey added 1 commit 2023-09-27 01:28:26 +00:00
More verbose output
Test / Run unit tests (pull_request) Successful in 12m49s
Details
43a2245b65
telackey added 1 commit 2023-09-27 02:22:07 +00:00
Extra check.
Test / Run unit tests (pull_request) Successful in 12m30s
Details
e70cbb0f26
telackey changed title from Add script for using local plugeth-statediff to Add script for updating go.mod to use local plugeth-statediff 2023-09-27 02:25:00 +00:00
roysc approved these changes 2023-09-27 07:28:47 +00:00
roysc left a comment
Owner
Copy Link
Copy Source

LGTM, but I'll add a few tweaks before merging.

LGTM, but I'll add a few tweaks before merging.
scripts/update-mod.sh
@@ -0,0 +1,31 @@
#!/bin/sh
PLUGETH_STATEDIFF_DIR=`echo "$(cd "$(dirname "$1")"; pwd)/$(basename "$1")"`
roysc commented 2023-09-27 04:34:54 +00:00
Owner
Copy Link
Copy Source

What does cd dir; pwd do here (vs. just dir)?

What does `cd dir; pwd` do here (vs. just `dir`)?
scripts/update-mod.sh
@@ -0,0 +28,4 @@
go mod edit --replace "$r"
done
go mod tidy -e 2>/dev/null
roysc commented 2023-09-27 07:28:16 +00:00
Owner
Copy Link
Copy Source

So that's how you do that!

So that's how you do that!
roysc added 1 commit 2023-09-27 07:32:26 +00:00
tweaks
Test / Run unit tests (pull_request) Successful in 12m45s
Details
59444de62d
roysc merged commit 353b68c395 into main 2023-09-27 07:48:33 +00:00
roysc deleted branch telackey/ci 2023-09-27 07:48:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
roysc
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex cerccicd ericlewis i-norden (Ian Norden) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees telackey
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/eth-statediff-compliance#3