Update to plugeth-statediff 0.1.4 #2

Merged
roysc merged 6 commits from telackey/014 into v5 2023-09-30 05:50:07 +00:00
Member
No description provided.
telackey added 1 commit 2023-09-29 20:33:38 +00:00
telackey requested review from roysc 2023-09-29 20:33:46 +00:00
telackey self-assigned this 2023-09-29 20:34:00 +00:00
telackey added 1 commit 2023-09-29 20:50:12 +00:00
telackey added 1 commit 2023-09-29 20:55:07 +00:00
telackey reviewed 2023-09-29 20:58:12 +00:00
pkg/validator.go Outdated
@ -223,3 +223,2 @@
ctx, cancelCtx := context.WithCancel(context.Background())
ctx, _ := context.WithCancel(context.Background())
tracker := tracker.New(recoveryFile, iterCount)
tracker.CaptureSignal(cancelCtx)
Author
Member

What's the replacement scheme for CaptureSignal()?

What's the replacement scheme for CaptureSignal()?
Member

it was such a simple function, I just removed it from the package.

	signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM)
	go func() {
		sig := <-sigChan
		log.Errorf("Signal received (%v), stopping", sig)
		cancel()
	}()
it was such a simple function, I just removed it from the package. ```go signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM) go func() { sig := <-sigChan log.Errorf("Signal received (%v), stopping", sig) cancel() }() ```
Member

But the context doesn't really do anything here (and never did), we need to add a bit more plumbing.

But the context doesn't really do anything here (and never did), we need to add a bit more plumbing.
Author
Member

So is the "fix" of just dropping the line appropriate at the moment?

So is the "fix" of just dropping the line appropriate at the moment?
Member

Yes, it can wait

Yes, it can wait
Member

I made a follow up PR. Also need to fix it for snapshots cerc-io/ipld-eth-state-snapshot#2

I made a follow up PR. Also need to fix it for snapshots https://git.vdb.to/cerc-io/ipld-eth-state-snapshot/issues/2
telackey added 1 commit 2023-09-29 21:35:17 +00:00
telackey added 1 commit 2023-09-29 21:56:31 +00:00
telackey added 1 commit 2023-09-29 22:04:20 +00:00
roysc approved these changes 2023-09-30 05:48:28 +00:00
roysc merged commit e1ab6a17b8 into v5 2023-09-30 05:50:07 +00:00
roysc deleted branch telackey/014 2023-09-30 05:50:08 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/eth-ipfs-state-validator#2
No description provided.