Update to plugeth-statediff 0.1.4 #2
No reviewers
Labels
No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/eth-ipfs-state-validator#2
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "telackey/014"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -223,3 +223,2 @@
ctx, cancelCtx := context.WithCancel(context.Background())
ctx, _ := context.WithCancel(context.Background())
tracker := tracker.New(recoveryFile, iterCount)
tracker.CaptureSignal(cancelCtx)
What's the replacement scheme for CaptureSignal()?
it was such a simple function, I just removed it from the package.
But the context doesn't really do anything here (and never did), we need to add a bit more plumbing.
So is the "fix" of just dropping the line appropriate at the moment?
Yes, it can wait
I made a follow up PR. Also need to fix it for snapshots cerc-io/ipld-eth-state-snapshot#2