Update to plugeth-statediff 0.1.4 #2

telackey · 2023-09-29T20:33:36Z

telackey commented

2023-09-29 20:33:36 +00:00

No description provided.

telackey added 1 commit 2023-09-29 20:33:38 +00:00

Update to plugeth-statediff 0.1.4 7568f10569

telackey requested review from roysc 2023-09-29 20:33:46 +00:00

telackey self-assigned this 2023-09-29 20:34:00 +00:00

telackey added 1 commit 2023-09-29 20:50:12 +00:00

Update to 0.1.4 18f376fb6e

telackey added 1 commit 2023-09-29 20:55:07 +00:00

Signature changes. c7ccdf3b3d

telackey reviewed 2023-09-29 20:58:12 +00:00

pkg/validator.go Outdated

						
				@ -223,3 +223,2 @@

					ctx, cancelCtx := context.WithCancel(context.Background())

					ctx, _ := context.WithCancel(context.Background())

					tracker := tracker.New(recoveryFile, iterCount)

					tracker.CaptureSignal(cancelCtx)

telackey commented

2023-09-29 20:58:12 +00:00

What's the replacement scheme for CaptureSignal()?

roysc commented

2023-09-30 03:19:52 +00:00

it was such a simple function, I just removed it from the package.

	signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM)
	go func() {
		sig := <-sigChan
		log.Errorf("Signal received (%v), stopping", sig)
		cancel()
	}()

it was such a simple function, I just removed it from the package. ```go signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM) go func() { sig := <-sigChan log.Errorf("Signal received (%v), stopping", sig) cancel() }() ```

roysc commented

2023-09-30 03:29:05 +00:00

But the context doesn't really do anything here (and never did), we need to add a bit more plumbing.

telackey commented

2023-09-30 03:46:41 +00:00

So is the "fix" of just dropping the line appropriate at the moment?

roysc commented

2023-09-30 05:48:23 +00:00

Yes, it can wait

roysc commented

2023-09-30 05:56:58 +00:00

I made a follow up PR. Also need to fix it for snapshots cerc-io/ipld-eth-state-snapshot#2