Update README.md #23

zramsay · 2023-03-01T06:19:55Z

0xmuralik commented

2023-03-01 06:19:55 +00:00

(Migrated from github.com)

Closes: #17
Update readme to use new record type

Closes: #17 Update readme to use new record type

ABastionOfSanity (Migrated from github.com) reviewed 2023-03-01 06:19:55 +00:00

aleem1314 (Migrated from github.com) reviewed 2023-03-01 06:19:55 +00:00

0xmuralik commented

2023-03-02 05:29:35 +00:00

(Migrated from github.com)

https://github.com/cerc-io/laconic-registry-cli/issues/17#issuecomment-1449424486

zramsay approved these changes 2023-03-06 22:49:49 +00:00

i-norden approved these changes 2023-03-07 01:57:58 +00:00

i-norden left a comment

LGTM! For posterity: this updates the docs to reflect the types currently on laconicd main, not the pending changes in https://github.com/cerc-io/laconicd/pull/79 and https://github.com/cerc-io/laconic-sdk/pull/27

LGTM! For posterity: this updates the docs to reflect the types [currently on laconicd main](https://github.com/cerc-io/laconicd/blob/main/proto/vulcanize/registry/v1beta1/attributes.proto#L25), not the pending changes in https://github.com/cerc-io/laconicd/pull/79 and https://github.com/cerc-io/laconic-sdk/pull/27

zramsay commented

2023-03-07 02:10:02 +00:00

Adding this caveat: if having already run the laconic-sdk tests then trying the README instructions will lead to https://github.com/cerc-io/laconic-registry-cli/issues/28 for reasons im still figuring out

Adding this caveat: if having already run the `laconic-sdk` tests then trying the README instructions will lead to https://github.com/cerc-io/laconic-registry-cli/issues/28 for reasons im still figuring out

Sign in to join this conversation.

No reviewers

aleem1314

ABastionOfSanity

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/delete-me#23