chore(trading): bring back governance tests

README.md

@@ -136,7 +136,7 @@ The [`docker`](./docker) subfolder has some docker configurations for easily set
 Using multistage dockerfile dist is compiled using [node](https://hub.docker.com/_/node) image and later packed to nginx as in [dist build](#dist-build). The multistage builds ensures consistent CPU architecture and build toolchains are used so that the result will be identical.
 
 ```bash
-docker build --build-arg APP=[YOUR APP] --build-arg NODE_VERSION=20.11 --build-arg ENV_NAME=mainnet -t [TAG] -f docker/node-inside-docker.Dockerfile .
+docker build --build-arg APP=[YOUR APP] --build-arg NODE_VERSION=20.9.1 --build-arg ENV_NAME=mainnet -t [TAG] -f docker/node-inside-docker.Dockerfile .
 ```
 
 ### Computing ipfs-hash of the build

apps/governance-e2e/src/integration/flow/proposal-flow.cy.ts

@@ -21,6 +21,7 @@ import {
   navigation,
   closeDialog,
   turnTelemetryOff,
+  setRiskAccepted,
 } from '../../support/common.functions';
 import {
   clickOnValidatorFromList,
@@ -82,6 +83,7 @@ context(
     beforeEach('visit governance tab', function () {
       cy.clearLocalStorage();
       turnTelemetryOff();
+      setRiskAccepted();
       cy.reload();
       cy.mockChainId();
       waitForSpinner();
@@ -92,7 +94,7 @@ context(
     });
 
     // Test can only pass if run before other proposal tests.
-    it.skip('Should be able to see that no proposals exist', function () {
+    it('Should be able to see that no proposals exist', function () {
       // 3001-VOTE-003
       cy.getByTestId(noOpenProposals)
         .should('be.visible')

apps/governance-e2e/src/integration/flow/proposal-forms.cy.ts

@@ -3,6 +3,7 @@ import {
   dissociateFromSecondWalletKey,
   navigateTo,
   navigation,
+  setRiskAccepted,
   turnTelemetryOff,
   waitForSpinner,
 } from '../../support/common.functions';
@@ -74,6 +75,7 @@ context(
     beforeEach('visit governance tab', function () {
       cy.clearLocalStorage();
       turnTelemetryOff();
+      setRiskAccepted();
       cy.mockChainId();
       cy.reload();
       waitForSpinner();
@@ -215,7 +217,7 @@ context(
     });
 
     // 3003-PMAN-001
-    it.skip(
+    it(
       'Able to submit valid new market proposal',
       // @ts-ignore clash between jest and cypress
       { tags: '@smoke' },
@@ -299,7 +301,7 @@ context(
 
     // Will fail if run after 'Able to submit update market proposal and vote for proposal'
     // 3002-PROP-022
-    it.skip('Unable to submit update market proposal without equity-like share in the market', function () {
+    it('Unable to submit update market proposal without equity-like share in the market', function () {
       switchVegaWalletPubKey();
       stakingPageAssociateTokens('1');
       goToMakeNewProposal(governanceProposalType.UPDATE_MARKET);

apps/governance-e2e/src/integration/flow/staking-flow.cy.ts

@@ -238,7 +238,7 @@ context(
       });
 
       // 1002-STKE-041 1002-STKE-053
-      it.skip(
+      it(
         'Able to remove part of a stake against a validator',
         // @ts-ignore clash between jest and cypress
         { tags: '@smoke' },
@@ -428,7 +428,7 @@ context(
         validateValidatorListTotalStakeAndShare('0', '3,002.00', '50.02%');
       });
 
-      it.skip('Associating wallet tokens - when some already staked - auto stakes tokens to staked validator', function () {
+      it('Associating wallet tokens - when some already staked - auto stakes tokens to staked validator', function () {
         // 1002-STKE-004
         stakingPageAssociateTokens('3');
         verifyUnstakedBalance(3.0);
@@ -442,7 +442,7 @@ context(
         verifyStakedBalance(7.0);
       });
 
-      it.skip('Associating vesting contract tokens - when some already staked - auto stakes tokens to staked validator', function () {
+      it('Associating vesting contract tokens - when some already staked - auto stakes tokens to staked validator', function () {
         // 1002-STKE-004
         stakingPageAssociateTokens('3', { type: 'contract' });
         verifyUnstakedBalance(3.0);
@@ -456,7 +456,7 @@ context(
         verifyStakedBalance(7.0);
       });
 
-      it.skip('Associating vesting contract tokens - when wallet tokens already staked - auto stakes tokens to staked validator', function () {
+      it('Associating vesting contract tokens - when wallet tokens already staked - auto stakes tokens to staked validator', function () {
         // 1002-STKE-004
         stakingPageAssociateTokens('3', { type: 'wallet' });
         verifyUnstakedBalance(3.0);
@@ -470,7 +470,7 @@ context(
         verifyStakedBalance(7.0);
       });
 
-      it.skip('Associating tokens - with multiple validators already staked - auto stakes to staked validators - abiding by existing stake ratio', function () {
+      it('Associating tokens - with multiple validators already staked - auto stakes to staked validators - abiding by existing stake ratio', function () {
         // 1002-STKE-004
         stakingPageAssociateTokens('6');
         verifyUnstakedBalance(6.0);

apps/governance-e2e/src/integration/flow/withdrawal-flow.cy.ts

@@ -100,7 +100,7 @@ context(
     });
 
     // eslint-disable-next-line
-    it.skip(
+    it(
       'Able to withdraw asset: -eth wallet connected -withdraw funds button',
       // @ts-ignore clash between jest and cypress
       { tags: '@smoke' },
@@ -284,7 +284,7 @@ context(
     });
 
     // Skipping test due to bug #3882
-    it.skip('Unable to withdraw asset on pub key view', function () {
+    it('Unable to withdraw asset on pub key view', function () {
       const vegaWalletPubKey = Cypress.env('vegaWalletPublicKey');
       const expectedErrorTxt = `You are connected in a view only state for public key: ${vegaWalletPubKey}. In order to send transactions you must connect to a real wallet.`;
 

apps/governance-e2e/src/integration/view/home.cy.ts

@@ -27,7 +27,7 @@ context('Home Page - verify elements on page', { tags: '@smoke' }, function () {
       cy.getByTestId('app-announcement').should('not.exist');
     });
 
-    it.skip('should show open or enacted proposals without proposal summary', function () {
+    it('should show open or enacted proposals without proposal summary', function () {
       cy.get('body').then(($body) => {
         if (!$body.find('[data-testid="proposals-list-item"]').length) {
           cy.createMarket();
@@ -189,7 +189,7 @@ context('Home Page - verify elements on page', { tags: '@smoke' }, function () {
       cy.viewport('iphone-xr');
     });
 
-    it.skip('should have burger button', () => {
+    it('should have burger button', () => {
       cy.getByTestId('button-menu-drawer').should('be.visible').click();
       cy.getByTestId('menu-drawer').should('be.visible');
     });

apps/governance-e2e/src/integration/view/proposal.cy.ts

@@ -255,7 +255,7 @@ context(
     });
 
     // 3009-NTWU-001 3009-NTWU-002 3009-NTWU-006 3009-NTWU-009
-    it.skip('should display network upgrade banner with estimate', function () {
+    it('should display network upgrade banner with estimate', function () {
       mockNetworkUpgradeProposal();
       cy.visit('/');
       cy.getByTestId('banners').within(() => {

apps/governance-e2e/src/integration/view/pubkey-view.cy.ts

@@ -34,14 +34,14 @@ context('View functionality with public key', { tags: '@smoke' }, function () {
     cy.connectPublicKey(vegaWalletPubKey);
   });
 
-  it.skip('Able to connect public key via wallet and view assets in wallet', function () {
+  it('Able to connect public key via wallet and view assets in wallet', function () {
     verifyConnectedToPubKey();
-    cy.getByTestId('currency-title', { timeout: 10000 })
+    cy.getByTestId('currency-title', { timeout: 80000 })
       .should('have.length.at.least', 2)
       .and('contain.text', 'USDC (fake)');
   });
 
-  it.skip('Unable to submit proposal with public key', function () {
+  it('Unable to submit proposal with public key', function () {
     const expectedErrorTxt = `You are connected in a view only state for public key: ${vegaWalletPubKey}. In order to send transactions you must connect to a real wallet.`;
 
     goToMakeNewProposal(governanceProposalType.RAW);

apps/governance-e2e/src/integration/view/rewards.cy.ts

@@ -40,7 +40,7 @@ context(
       });
 
       // Skipping due to bug #3471 causing flaky failuress
-      it.skip('should have option to view go to next and previous page', function () {
+      it('should have option to view go to next and previous page', function () {
         waitForBeginningOfEpoch();
         cy.getByTestId('page-info')
           .should('contain.text', 'Page ')
@@ -63,7 +63,7 @@ context(
           });
       });
 
-      it('should have option to go to last and newest page', function () {
+      it.only('should have option to go to last and newest page', function () {
         cy.getByTestId('goto-last-page').click();
         cy.getByTestId('epoch-total-rewards-table')
           .last()
@@ -71,7 +71,9 @@ context(
           .first()
           .should('have.text', 'EPOCH 1');
         cy.getByTestId('goto-first-page').click();
-        cy.get('h2').should('not.contain.text', 'EPOCH 1');
+        cy.getByTestId('epoch-total-rewards-table')
+          .get('h2')
+          .should('not.contain.text', 'EPOCH 1');
       });
     });
   }

docker/node-inside-docker.Dockerfile

@@ -1,15 +1,14 @@
 # Build container
 ARG NODE_VERSION
-FROM --platform=amd64 node:${NODE_VERSION}-alpine3.18 as build
+FROM --platform=amd64 node:${NODE_VERSION}-alpine3.16 as build
 WORKDIR /app
 # Argument to allow building of different apps
 ARG APP
 ARG ENV_NAME=""
 RUN apk add --update --no-cache \
-  git \
-  make==4.4.1-r1 \
-  gcc==12.2.1_git20220924-r10 \
-  g++==12.2.1_git20220924-r10
+  make==4.3-r0 \
+  gcc==11.2.1_git20220219-r2 \
+  g++==11.2.1_git20220219-r2
 COPY . ./
 RUN yarn --pure-lockfile
 # work around for different build process in trading

libs/types/project.json

@@ -34,21 +34,6 @@
       "options": {
         "jestConfig": "libs/types/jest.config.ts"
       }
-    },
-    "generate": {
-      "executor": "nx:run-commands",
-      "options": {
-        "commands": ["npx graphql-codegen --config=libs/types/codegen.yml"],
-        "parallel": false
-      }
-    },
-    "local-registry": {
-      "executor": "@nx/js:verdaccio",
-      "options": {
-        "port": 4873,
-        "config": ".verdaccio/config.yml",
-        "storage": "tmp/local-registry/storage"
-      }
     }
   },
   "tags": []

libs/utils/project.json

@@ -35,14 +35,6 @@
       "options": {
         "jestConfig": "libs/utils/jest.config.ts"
       }
-    },
-    "local-registry": {
-      "executor": "@nx/js:verdaccio",
-      "options": {
-        "port": 4873,
-        "config": ".verdaccio/config.yml",
-        "storage": "tmp/local-registry/storage"
-      }
     }
   },
   "tags": []

libs/wallet/project.json

@@ -35,14 +35,6 @@
       "options": {
         "jestConfig": "libs/wallet/jest.config.ts"
       }
-    },
-    "local-registry": {
-      "executor": "@nx/js:verdaccio",
-      "options": {
-        "port": 4873,
-        "config": ".verdaccio/config.yml",
-        "storage": "tmp/local-registry/storage"
-      }
     }
   },
   "tags": []

package.json

@@ -241,5 +241,8 @@
     "graphql": "15.8.0",
     "//": "workaround storybook issue: https://github.com/storybookjs/storybook/issues/21642",
     "@storybook/react-docgen-typescript-plugin": "1.0.6--canary.9.cd77847.0"
+  },
+  "nx": {
+    "includedScripts": []
   }
 }

project.json

@@ -0,0 +1,14 @@
+{
+  "name": "nx-monorepo",
+  "$schema": "node_modules/nx/schemas/project-schema.json",
+  "targets": {
+    "local-registry": {
+      "executor": "@nx/js:verdaccio",
+      "options": {
+        "port": 4873,
+        "config": ".verdaccio/config.yml",
+        "storage": "tmp/local-registry/storage"
+      }
+    }
+  }
+}