chore: adjust codeowners to require reviews from both teams

CODEOWNERS

@@ -1,3 +1,2 @@
-* @vegaprotocol/frontend
-* @vegaprotocol/frontend-qa
+* @vegaprotocol/frontend @vegaprotocol/frontend-qa
 *.graphql @vegaprotocol/core

apps/governance/src/i18n/translations/dev.json

@@ -718,6 +718,8 @@
   "UpdateAssetProposal": "Update asset proposal",
   "NewFreeformProposal": "New freeform proposal",
   "NewRawProposal": "New proposal",
+  "NewTransferProposal": "New transfer proposal",
+  "CancelTransferProposal": "Cancel transfer proposal",
   "MARKET_STATE_UPDATE_TYPE_RESUME": "Resume market",
   "MARKET_STATE_UPDATE_TYPE_SUSPEND": "Suspend market",
   "MARKET_STATE_UPDATE_TYPE_TERMINATE": "Terminate market",
@@ -738,6 +740,8 @@
   "UpdateVolumeDiscountProgram": "Update volume discount program",
   "NewAsset": "New asset",
   "UpdateAsset": "Update asset",
+  "NewTransfer": "New transfer",
+  "CancelTransfer": "Cancel transfer",
   "AssetID": "Asset ID",
   "Freeform": "Freeform",
   "RawProposal": "Let me choose (raw proposal)",
@@ -914,5 +918,31 @@
   "EndOfProgramTimestamp": "End of program",
   "EndOfProgramTimestampDescription": "Time after which when the current epoch ends, the programs will end and benefits will be disabled.",
   "BenefitTierVolumeDiscountFactor": "Volume discount factor",
-  "BenefitTierVolumeDiscountFactorDescription": "Discount given to those in this benefit tier"
+  "BenefitTierVolumeDiscountFactorDescription": "Discount given to those in this benefit tier",
+  "ACCOUNT_TYPE_INSURANCE": "Insurance account",
+  "ACCOUNT_TYPE_GLOBAL_INSURANCE": "Global insurance account",
+  "ACCOUNT_TYPE_SETTLEMENT": "Settlement account",
+  "ACCOUNT_TYPE_MARGIN": "Margin account ",
+  "ACCOUNT_TYPE_GENERAL": "General account",
+  "ACCOUNT_TYPE_FEES_INFRASTRUCTURE": "Infrastructure fees account",
+  "ACCOUNT_TYPE_FEES_LIQUIDITY": "Liquidity fees account",
+  "ACCOUNT_TYPE_FEES_MAKER": "Maker fees account",
+  "ACCOUNT_TYPE_BOND": "Bond account",
+  "ACCOUNT_TYPE_EXTERNAL": "External account",
+  "ACCOUNT_TYPE_GLOBAL_REWARD": "Global reward account",
+  "ACCOUNT_TYPE_PENDING_TRANSFERS": "Pending transfers account",
+  "ACCOUNT_TYPE_REWARD_MAKER_PAID_FEES": "Maker paid fees reward account",
+  "ACCOUNT_TYPE_REWARD_MAKER_RECEIVED_FEES": "Maker received fees reward account",
+  "ACCOUNT_TYPE_REWARD_LP_RECEIVED_FEES": "Liquidity provider received fees reward account",
+  "ACCOUNT_TYPE_REWARD_MARKET_PROPOSERS": "Market proposers reward account",
+  "ACCOUNT_TYPE_HOLDING": "Holding account",
+  "ACCOUNT_TYPE_LP_LIQUIDITY_FEES": "Liquidity provider fees account",
+  "ACCOUNT_TYPE_NETWORK_TREASURY": "Network treasury account",
+  "ACCOUNT_TYPE_VESTING_REWARDS": "Vesting rewards account",
+  "ACCOUNT_TYPE_VESTED_REWARDS": "Vested rewards account",
+  "ACCOUNT_TYPE_REWARD_AVERAGE_POSITION": "Average position reward account",
+  "ACCOUNT_TYPE_REWARD_RELATIVE_RETURN": "Relative return reward account",
+  "ACCOUNT_TYPE_REWARD_RETURN_VOLATILITY": "Return volatility reward account",
+  "ACCOUNT_TYPE_REWARD_VALIDATOR_RANKING": "Validator ranking reward account",
+  "ACCOUNT_TYPE_PENDING_FEE_REFERRAL_REWARD": "Pending fee referral reward account"
 }

apps/governance/src/routes/proposals/components/proposal-detail-header/proposal-header.tsx

@@ -263,7 +263,10 @@ const NewTransferSummary = ({ proposalId }: { proposalId?: string | null }) => {
   return (
     <span>
       {GovernanceTransferKindMapping[details.kind.__typename]}{' '}
-      {t('transfer from')} <Lozenge>{truncateMiddle(details.source)}</Lozenge>{' '}
+      {t('transfer from')}{' '}
+      <Lozenge>
+        {truncateMiddle(details.source) || t(details.sourceType)}
+      </Lozenge>{' '}
       {t('to')} <Lozenge>{truncateMiddle(details.destination)}</Lozenge>
     </span>
   );

apps/governance/src/routes/proposals/hooks/use-proposal-network-params.ts

@@ -30,6 +30,8 @@ export const useProposalNetworkParams = ({
     NetworkParams.governance_proposal_freeform_requiredParticipation,
     NetworkParams.governance_proposal_VolumeDiscountProgram_requiredMajority,
     NetworkParams.governance_proposal_VolumeDiscountProgram_requiredParticipation,
+    NetworkParams.governance_proposal_transfer_requiredParticipation,
+    NetworkParams.governance_proposal_transfer_requiredMajority,
   ]);
 
   const fallback = {
@@ -111,6 +113,14 @@ export const useProposalNetworkParams = ({
           params.governance_proposal_VolumeDiscountProgram_requiredParticipation
         ),
       };
+    case 'NewTransfer':
+    case 'CancelTransfer':
+      return {
+        requiredMajority: params.governance_proposal_transfer_requiredMajority,
+        requiredParticipation: new BigNumber(
+          params.governance_proposal_transfer_requiredParticipation
+        ),
+      };
     default:
       return fallback;
   }

apps/trading/client-pages/market/market-header-stats.tsx

@@ -43,7 +43,7 @@ export const MarketHeaderStats = ({ market }: MarketHeaderStatsProps) => {
   const asset = getAsset(market);
 
   return (
-    <div className="flex gap-8">
+    <>
       <HeaderStat heading={t('Mark Price')} testId="market-price">
         <MarketMarkPrice
           marketId={market.id}
@@ -144,7 +144,7 @@ export const MarketHeaderStats = ({ market }: MarketHeaderStatsProps) => {
         </HeaderStat>
       )}
       <MarketProposalNotification marketId={market.id} />
-    </div>
+    </>
   );
 };
 

apps/trading/client-pages/market/trade-grid.tsx

@@ -73,10 +73,19 @@ const MainGrid = memo(
                   {market &&
                   market.tradableInstrument.instrument.product.__typename ===
                     'Perpetual' ? (
-                    <Tab id="funding" name={t('Funding')}>
+                    <Tab id="funding-history" name={t('Funding history')}>
                       <TradingViews.funding.component marketId={marketId} />
                     </Tab>
                   ) : null}
+                  {market &&
+                  market.tradableInstrument.instrument.product.__typename ===
+                    'Perpetual' ? (
+                    <Tab id="funding-payments" name={t('Funding payments')}>
+                      <TradingViews.fundingPayments.component
+                        marketId={marketId}
+                      />
+                    </Tab>
+                  ) : null}
                 </Tabs>
               </TradeGridChild>
             </ResizableGridPanel>
@@ -139,9 +148,6 @@ const MainGrid = memo(
               <Tab id="fills" name={t('Fills')}>
                 <TradingViews.fills.component />
               </Tab>
-              <Tab id="funding-payments" name={t('Funding payments')}>
-                <TradingViews.fundingPayments.component />
-              </Tab>
               <Tab
                 id="accounts"
                 name={t('Collateral')}

apps/trading/components/funding-payments-container/funding-payments-container.tsx

@@ -9,7 +9,11 @@ import type { DataGridSlice } from '../../stores/datagrid-store-slice';
 import { createDataGridSlice } from '../../stores/datagrid-store-slice';
 import { useMarketClickHandler } from '../../lib/hooks/use-market-click-handler';
 
-export const FundingPaymentsContainer = () => {
+export const FundingPaymentsContainer = ({
+  marketId,
+}: {
+  marketId?: string;
+}) => {
   const onMarketClick = useMarketClickHandler(true);
   const { pubKey } = useVegaWallet();
 
@@ -33,6 +37,7 @@ export const FundingPaymentsContainer = () => {
   return (
     <FundingPaymentsManager
       partyId={pubKey}
+      marketId={marketId}
       onMarketClick={onMarketClick}
       gridProps={gridStoreCallbacks}
     />

apps/trading/components/header/header.tsx

@@ -17,11 +17,11 @@ export const Header = ({ title, children }: TradeMarketHeaderProps) => {
   );
   return (
     <header className={headerClasses}>
-      <div className="hidden lg:flex flex-col justify-center items-start pl-3 lg:pl-4 pt-2 xl:pb-2 pb-0">
+      <div className="flex-col items-start justify-center hidden pt-2 pb-0 pl-3 lg:flex lg:pl-4 xl:pb-2">
         {title}
       </div>
       <div data-testid="header-summary" className="min-w-0">
-        <div className="px-3 lg:px-4 py-2 flex flex-nowrap gap-4 items-center text-xs overflow-x-auto">
+        <div className="flex items-center px-3 py-2 overflow-x-auto text-xs lg:px-4 flex-nowrap gap-6">
           {children}
         </div>
       </div>
@@ -70,7 +70,7 @@ export const HeaderTitle = ({ children }: { children: ReactNode }) => {
   return (
     <h1
       data-testid="header-title"
-      className="flex gap-4 items-center text-lg whitespace-nowrap xl:pr-4 xl:border-r border-default"
+      className="flex items-center text-lg gap-4 whitespace-nowrap xl:pr-4 xl:border-r border-default"
     >
       {children}
     </h1>

apps/trading/components/layouts/layout-with-sidebar.tsx

@@ -40,9 +40,12 @@ export const LayoutWithSidebar = () => {
       </main>
       <aside
         // min-h-0 is needed as this element is part of a grid, we want the content to be scrollable, without it it will push the grid element taller
-        className={classNames('col-start-1 lg:col-start-2 min-h-0', {
-          hidden: !sidebarOpen,
-        })}
+        className={classNames(
+          'col-start-1 lg:col-start-2 min-h-0 lg:border-l border-default lg:bg-vega-clight-800 dark:lg:bg-vega-cdark-800',
+          {
+            hidden: !sidebarOpen,
+          }
+        )}
       >
         <SidebarContent />
       </aside>

apps/trading/components/market-header/market-header.tsx

@@ -28,12 +28,11 @@ export const MarketHeader = () => {
             <HeaderTitle>
               <span>
                 {data.tradableInstrument.instrument.code}
-                <span className="ml-2 text-xs uppercase text-muted">
-                  {' '}
+                <span className="ml-1 text-xs uppercase text-muted">
                   {data.tradableInstrument.instrument.product.__typename &&
                     ProductTypeShortName[
                       data.tradableInstrument.instrument.product.__typename
-                    ]}{' '}
+                    ]}
                 </span>
               </span>
               <VegaIcon name={VegaIconNames.CHEVRON_DOWN} size={14} />

libs/funding-payments/src/lib/FundingPayments.graphql

@@ -6,8 +6,12 @@ fragment FundingPaymentFields on FundingPayment {
   timestamp
 }
 
-query FundingPayments($partyId: ID!, $pagination: Pagination) {
-  fundingPayments(partyId: $partyId, pagination: $pagination) {
+query FundingPayments($partyId: ID!, $pagination: Pagination, $marketId: ID) {
+  fundingPayments(
+    partyId: $partyId
+    pagination: $pagination
+    marketId: $marketId
+  ) {
     edges {
       node {
         ...FundingPaymentFields

libs/funding-payments/src/lib/__generated__/FundingPayments.ts

@@ -8,6 +8,7 @@ export type FundingPaymentFieldsFragment = { __typename?: 'FundingPayment', mark
 export type FundingPaymentsQueryVariables = Types.Exact<{
   partyId: Types.Scalars['ID'];
   pagination?: Types.InputMaybe<Types.Pagination>;
+  marketId?: Types.InputMaybe<Types.Scalars['ID']>;
 }>;
 
 
@@ -23,8 +24,8 @@ export const FundingPaymentFieldsFragmentDoc = gql`
 }
     `;
 export const FundingPaymentsDocument = gql`
-    query FundingPayments($partyId: ID!, $pagination: Pagination) {
-  fundingPayments(partyId: $partyId, pagination: $pagination) {
+    query FundingPayments($partyId: ID!, $pagination: Pagination, $marketId: ID) {
+  fundingPayments(partyId: $partyId, pagination: $pagination, marketId: $marketId) {
     edges {
       node {
         ...FundingPaymentFields
@@ -55,6 +56,7 @@ export const FundingPaymentsDocument = gql`
  *   variables: {
  *      partyId: // value for 'partyId'
  *      pagination: // value for 'pagination'
+ *      marketId: // value for 'marketId'
  *   },
  * });
  */

libs/funding-payments/src/lib/funding-payments-manager.tsx

@@ -8,12 +8,14 @@ import { fundingPaymentsWithMarketProvider } from './funding-payments-data-provi
 
 interface FundingPaymentsManagerProps {
   partyId: string;
+  marketId?: string;
   onMarketClick?: (marketId: string, metaKey?: boolean) => void;
   gridProps: ReturnType<typeof useDataGridEvents>;
 }
 
 export const FundingPaymentsManager = ({
   partyId,
+  marketId,
   onMarketClick,
   gridProps,
 }: FundingPaymentsManagerProps) => {
@@ -27,7 +29,7 @@ export const FundingPaymentsManager = ({
       }
       return false;
     },
-    variables: { partyId },
+    variables: { partyId, marketId },
   });
 
   return (

libs/network-parameters/src/use-network-params.ts

@@ -128,6 +128,26 @@ export const NetworkParams = {
     'governance_proposal_VolumeDiscountProgram_requiredMajority',
   governance_proposal_VolumeDiscountProgram_requiredParticipation:
     'governance_proposal_VolumeDiscountProgram_requiredParticipation',
+  governance_proposal_transfer_maxAmount:
+    'governance_proposal_transfer_maxAmount',
+  governance_proposal_transfer_maxClose:
+    'governance_proposal_transfer_maxClose',
+  governance_proposal_transfer_maxEnact:
+    'governance_proposal_transfer_maxEnact',
+  governance_proposal_transfer_maxFraction:
+    'governance_proposal_transfer_maxFraction',
+  governance_proposal_transfer_minClose:
+    'governance_proposal_transfer_minClose',
+  governance_proposal_transfer_minEnact:
+    'governance_proposal_transfer_minEnact',
+  governance_proposal_transfer_minProposerBalance:
+    'governance_proposal_transfer_minProposerBalance',
+  governance_proposal_transfer_minVoterBalance:
+    'governance_proposal_transfer_minVoterBalance',
+  governance_proposal_transfer_requiredMajority:
+    'governance_proposal_transfer_requiredMajority',
+  governance_proposal_transfer_requiredParticipation:
+    'governance_proposal_transfer_requiredParticipation',
   validators_delegation_minAmount: 'validators_delegation_minAmount',
   spam_protection_minimumWithdrawalQuantumMultiple:
     'spam_protection_minimumWithdrawalQuantumMultiple',