chore(trading): move local_server into .env

.gitattributes

@@ -1,4 +1,3 @@
 * text eol=lf
 *.png binary
 *.ico binary
-*.woff2 binary

apps/explorer/src/app/routes/blocks/id/block.tsx

@@ -54,7 +54,7 @@ const Block = () => {
               </Button>
             </Link>
           </div>
-          {blockData && 'result' in blockData && (
+          {blockData && (
             <>
               <TableWithTbody className="mb-8">
                 <TableRow modifier="bordered">

apps/governance/.env.capsule

@@ -32,7 +32,7 @@ CYPRESS_FAIRGROUND=false
 
 # Cosmic elevator flags
 NX_SUCCESSOR_MARKETS=true
-NX_METAMASK_SNAPS=true
+NX_METAMASK_SNAPS=false
 NX_PRODUCT_PERPETUALS=true
 NX_UPDATE_MARKET_STATE=true
 NX_REFERRALS=true

apps/governance/.env.mainnet

@@ -23,7 +23,7 @@ NX_TENDERMINT_WEBSOCKET_URL=wss://be.vega.community/websocket
 
 # Cosmic elevator flags
 NX_SUCCESSOR_MARKETS=true
-NX_METAMASK_SNAPS=true
+NX_METAMASK_SNAPS=false
 NX_PRODUCT_PERPETUALS=true
 NX_UPDATE_MARKET_STATE=true
 NX_REFERRALS=true

apps/governance/.env.mainnet-mirror

@@ -22,7 +22,7 @@ NX_TENDERMINT_WEBSOCKET_URL=wss://be.mainnet-mirror.vega.rocks/websocket
 
 # Cosmic elevator flags
 NX_SUCCESSOR_MARKETS=true
-NX_METAMASK_SNAPS=true
+NX_METAMASK_SNAPS=false
 NX_PRODUCT_PERPETUALS=true
 NX_UPDATE_MARKET_STATE=true
 NX_REFERRALS=true

apps/governance/.env.validators-testnet

@@ -21,7 +21,7 @@ NX_TENDERMINT_WEBSOCKET_URL=wss://be.validators-testnet.vega.
 
 # Cosmic elevator flags
 NX_SUCCESSOR_MARKETS=true
-NX_METAMASK_SNAPS=true
+NX_METAMASK_SNAPS=false
 NX_PRODUCT_PERPETUALS=true
 NX_UPDATE_MARKET_STATE=true
 NX_REFERRALS=true

apps/governance/src/routes/proposals/components/vote-breakdown/vote-breakdown.spec.tsx

@@ -281,8 +281,8 @@ describe('VoteBreakdown', () => {
   });
 
   it('Progress bar displays status -  LP majority', () => {
-    const yesVotesLP = 0.8;
-    const noVotesLP = 0.2;
+    const yesVotesLP = 800;
+    const noVotesLP = 200;
     const expectedProgress = (yesVotesLP / (yesVotesLP + noVotesLP)) * 100; // 80%
 
     renderComponent(

apps/governance/src/routes/proposals/components/vote-breakdown/vote-breakdown.tsx

@@ -105,6 +105,8 @@ export const VoteBreakdown = ({ proposal }: VoteBreakdownProps) => {
     yesLPPercentage,
     yesTokens,
     noTokens,
+    yesEquityLikeShareWeight,
+    noEquityLikeShareWeight,
     totalEquityLikeShareWeight,
     requiredMajorityPercentage,
     requiredMajorityLPPercentage,
@@ -133,7 +135,6 @@ export const VoteBreakdown = ({ proposal }: VoteBreakdownProps) => {
         .multipliedBy(100),
       new BigNumber(100)
     );
-
   const willPass = willPassByTokenVote || willPassByLPVote;
   const updateMarketVotePassMethod = willPassByTokenVote
     ? t('byTokenVote')
@@ -201,24 +202,50 @@ export const VoteBreakdown = ({ proposal }: VoteBreakdownProps) => {
                 <div className="flex items-center gap-1">
                   <span>{t('liquidityProviderVotesFor')}:</span>
                   <Tooltip
-                    description={
-                      <span>{yesLPPercentage.toFixed(defaultDP)}%</span>
-                    }
+                    description={formatNumber(
+                      yesEquityLikeShareWeight,
+                      defaultDP
+                    )}
                   >
-                    <button>{yesLPPercentage.toFixed(1)}%</button>
+                    <button>
+                      <CompactVotes number={yesEquityLikeShareWeight} />
+                    </button>
                   </Tooltip>
+                  <span>
+                    (
+                    <Tooltip
+                      description={
+                        <span>{yesLPPercentage.toFixed(defaultDP)}%</span>
+                      }
+                    >
+                      <button>{yesLPPercentage.toFixed(0)}%</button>
+                    </Tooltip>
+                    )
+                  </span>
                 </div>
 
                 <div className="flex items-center gap-1">
                   <span>{t('liquidityProviderVotesAgainst')}:</span>
+                  <Tooltip
+                    description={formatNumber(
+                      noEquityLikeShareWeight,
+                      defaultDP
+                    )}
+                  >
+                    <button>
+                      <CompactVotes number={noEquityLikeShareWeight} />
+                    </button>
+                  </Tooltip>
                   <span>
+                    (
                     <Tooltip
                       description={
                         <span>{noLPPercentage.toFixed(defaultDP)}%</span>
                       }
                     >
-                      <button>{noLPPercentage.toFixed(1)}%</button>
+                      <button>{noLPPercentage.toFixed(0)}%</button>
                     </Tooltip>
+                    )
                   </span>
                 </div>
               </div>
@@ -255,8 +282,13 @@ export const VoteBreakdown = ({ proposal }: VoteBreakdownProps) => {
                       defaultDP
                     )}
                   >
-                    <span>{totalEquityLikeShareWeight.toFixed(1)}%</span>
+                    <button>
+                      <CompactVotes number={totalEquityLikeShareWeight} />
+                    </button>
                   </Tooltip>
+                  <span>
+                    ({totalEquityLikeShareWeight.toFixed(defaultDP)}%)
+                  </span>
                 </div>
               </div>
             </section>

apps/governance/src/routes/proposals/hooks/use-vote-information.spec.ts

@@ -54,8 +54,8 @@ describe('use-vote-information', () => {
   it('returns all required vote information', () => {
     const yesVotes = 40;
     const noVotes = 60;
-    const yesEquityLikeShareWeight = '0.30';
-    const noEquityLikeShareWeight = '0.70';
+    const yesEquityLikeShareWeight = '30';
+    const noEquityLikeShareWeight = '70';
     // Note - giving a fixedTokenValue of 1 means a ratio of 1:1 votes to tokens, making sums easier :)
     const fixedTokenValue = 1000000000000000000;
 
@@ -195,10 +195,10 @@ describe('use-vote-information', () => {
   });
 
   it('correctly shows whether an update market proposal will pass by token or LP vote - both failing', () => {
-    const yesVotes = 0.2;
-    const noVotes = 0.7;
-    const yesEquityLikeShareWeight = '0.30';
-    const noEquityLikeShareWeight = '0.60';
+    const yesVotes = 20;
+    const noVotes = 70;
+    const yesEquityLikeShareWeight = '30';
+    const noEquityLikeShareWeight = '60';
     const fixedTokenValue = 1000000000000000000;
 
     const proposal = generateProposal({

apps/governance/src/routes/proposals/hooks/use-vote-information.ts

@@ -61,7 +61,7 @@ export const useVoteInformation = ({
     const noEquityLikeShareWeight = !proposal?.votes.no
       .totalEquityLikeShareWeight
       ? new BigNumber(0)
-      : new BigNumber(proposal.votes.no.totalEquityLikeShareWeight).times(100);
+      : new BigNumber(proposal.votes.no.totalEquityLikeShareWeight);
 
     const yesTokens = new BigNumber(
       addDecimal(proposal?.votes.yes.totalTokens ?? 0, decimals)
@@ -70,7 +70,7 @@ export const useVoteInformation = ({
     const yesEquityLikeShareWeight = !proposal?.votes.yes
       .totalEquityLikeShareWeight
       ? new BigNumber(0)
-      : new BigNumber(proposal.votes.yes.totalEquityLikeShareWeight).times(100);
+      : new BigNumber(proposal.votes.yes.totalEquityLikeShareWeight);
 
     const totalTokensVoted = yesTokens.plus(noTokens);
 
@@ -81,7 +81,12 @@ export const useVoteInformation = ({
     const yesPercentage = totalTokensVoted.isZero()
       ? new BigNumber(0)
       : yesTokens.multipliedBy(100).dividedBy(totalTokensVoted);
-    const yesLPPercentage = yesEquityLikeShareWeight;
+
+    const yesLPPercentage = totalEquityLikeShareWeight.isZero()
+      ? new BigNumber(0)
+      : yesEquityLikeShareWeight
+          .multipliedBy(100)
+          .dividedBy(totalEquityLikeShareWeight);
 
     const noPercentage = totalTokensVoted.isZero()
       ? new BigNumber(0)
@@ -98,7 +103,9 @@ export const useVoteInformation = ({
     );
 
     const participationLPMet = requiredParticipationLP
-      ? totalEquityLikeShareWeight.isGreaterThan(requiredParticipationLP)
+      ? totalEquityLikeShareWeight.isGreaterThan(
+          totalSupply.multipliedBy(requiredParticipationLP)
+        )
       : false;
 
     const majorityMet = yesPercentage.isGreaterThanOrEqualTo(
@@ -113,7 +120,9 @@ export const useVoteInformation = ({
       .multipliedBy(100)
       .dividedBy(totalSupply);
 
-    const totalLPTokensPercentage = totalEquityLikeShareWeight;
+    const totalLPTokensPercentage = totalEquityLikeShareWeight
+      .multipliedBy(100)
+      .dividedBy(totalSupply);
 
     const willPassByTokenVote =
       participationMet &&

apps/governance/src/routes/proposals/protocol-upgrade/protocol-upgrade-proposal-container.tsx

@@ -95,7 +95,7 @@ export const ProtocolUpgradeProposalContainer = () => {
           time={
             pending && time ? (
               convertToCountdownString(time, '0:00:00:00')
-            ) : blockInfo && 'result' in blockInfo && blockInfo?.result ? (
+            ) : blockInfo?.result ? (
               <span title={blockInfo.result.block.header.time}>
                 {formatDateWithLocalTimezone(
                   new Date(blockInfo.result.block.header.time)

apps/governance/src/routes/proposals/test-helpers/generate-proposals.ts

@@ -116,8 +116,7 @@ export const generateYesVotes = (
   fixedTokenValue?: number,
   totalEquityLikeShareWeight?: string
 ): Votes => {
-  const votes = [];
-  for (let i = 0; i < numberOfVotes; i++) {
+  const votes = Array.from(Array(numberOfVotes)).map(() => {
     const vote: Vote = {
       __typename: 'Vote',
       value: Schema.VoteValue.VALUE_YES,
@@ -153,9 +152,8 @@ export const generateYesVotes = (
       datetime: faker.date.past().toISOString(),
     };
 
-    votes.push(vote);
-  }
-
+    return vote;
+  });
   return {
     __typename: 'ProposalVoteSide',
     totalNumber: votes.length.toString(),
@@ -174,8 +172,7 @@ export const generateNoVotes = (
   fixedTokenValue?: number,
   totalEquityLikeShareWeight?: string
 ): Votes => {
-  const votes = [];
-  for (let i = 0; i < numberOfVotes; i++) {
+  const votes = Array.from(Array(numberOfVotes)).map(() => {
     const vote: Vote = {
       __typename: 'Vote',
       value: Schema.VoteValue.VALUE_NO,
@@ -210,9 +207,8 @@ export const generateNoVotes = (
       },
       datetime: faker.date.past().toISOString(),
     };
-    votes.push(vote);
-  }
-
+    return vote;
+  });
   return {
     __typename: 'ProposalVoteSide',
     totalNumber: votes.length.toString(),

apps/trading/client-pages/market/market-header-stats.tsx

@@ -188,11 +188,12 @@ const useNow = () => {
   return now;
 };
 
-const useEvery = (marketId: string, skip: boolean) => {
+const useEvery = (marketId: string) => {
+  const { data: marketTradingMode } = useMarketTradingMode(marketId);
   const { data: marketInfo } = useDataProvider({
     dataProvider: marketInfoProvider,
     variables: { marketId },
-    skip,
+    skip: !marketTradingMode || isMarketInAuction(marketTradingMode),
   });
   let every: number | undefined = undefined;
   const sourceType =
@@ -210,10 +211,8 @@ const useEvery = (marketId: string, skip: boolean) => {
   return every;
 };
 
-const useStartTime = (marketId: string, skip: boolean) => {
+const useStartTime = (marketId: string) => {
   const { data: fundingPeriods } = useFundingPeriodsQuery({
-    pollInterval: 5000,
-    skip,
     variables: {
       marketId: marketId,
       pagination: { first: 1 },
@@ -247,10 +246,8 @@ const useFormatCountdown = (
 
 export const FundingCountdown = ({ marketId }: { marketId: string }) => {
   const now = useNow();
-  const { data: marketTradingMode } = useMarketTradingMode(marketId);
-  const skip = !marketTradingMode || isMarketInAuction(marketTradingMode);
-  const startTime = useStartTime(marketId, skip);
-  const every = useEvery(marketId, skip);
+  const startTime = useStartTime(marketId);
+  const every = useEvery(marketId);
 
   return (
     <div data-testid="funding-countdown">

apps/trading/components/fees-container/fees-container.tsx

@@ -333,7 +333,11 @@ export const CurrentVolume = ({
   return (
     <div className="flex flex-col gap-3 pt-4" data-testid="current-volume">
       <CardStat
-        value={formatNumberRounded(currentVolume)}
+        value={
+          currentVolume.isZero()
+            ? `<${formatNumberRounded(requiredForNextTier)}`
+            : formatNumberRounded(currentVolume)
+        }
         text={t('pastEpochs', 'Past {{count}} epochs', {
           count: windowLength,
         })}

apps/trading/components/rewards-container/rewards-container.spec.tsx

@@ -69,13 +69,11 @@ describe('RewardPot', () => {
         balance: '100',
         asset: rewardAsset,
       },
-      // should include this in total:
       {
         type: AccountType.ACCOUNT_TYPE_VESTED_REWARDS,
         balance: '100',
         asset: rewardAsset,
       },
-      // should include this in total:
       {
         type: AccountType.ACCOUNT_TYPE_VESTED_REWARDS,
         balance: '50',
@@ -140,20 +138,20 @@ describe('RewardPot', () => {
 
     renderComponent(props);
 
+    expect(screen.getByTestId('total-rewards')).toHaveTextContent(
+      `7.00 ${rewardAsset.symbol}`
+    );
+
     expect(screen.getByText(/Locked/).nextElementSibling).toHaveTextContent(
       '2.50'
     );
     expect(screen.getByText(/Vesting/).nextElementSibling).toHaveTextContent(
       '4.50'
     );
+
     expect(
       screen.getByText(/Available to withdraw/).nextElementSibling
     ).toHaveTextContent('1.50');
-
-    // should be sum of the above
-    expect(screen.getByTestId('total-rewards')).toHaveTextContent(
-      `8.50 ${rewardAsset.symbol}`
-    );
   });
 });
 

apps/trading/components/rewards-container/rewards-container.tsx

@@ -62,10 +62,6 @@ export const RewardsContainer = () => {
     },
     // Inclusion of activity streak in query currently fails
     errorPolicy: 'ignore',
-    // polling here so that as rewards are are moved to ACCOUNT_TYPE_VESTED_REWARDS the vesting stats information stays
-    // almost up to sync with accounts updating from subscriptions. There is a chance the data could be out
-    // of sync for 10s if you happen to be on the page at the end of an epoch
-    pollInterval: 10000,
   });
 
   if (!epochData?.epoch || !assetMap) return null;
@@ -299,9 +295,7 @@ export const RewardPot = ({
     : [0];
   const totalVesting = BigNumber.sum.apply(null, vestingBalances);
 
-  const totalRewards = totalLocked
-    .plus(totalVesting)
-    .plus(totalVestedRewardsByRewardAsset);
+  const totalRewards = totalLocked.plus(totalVesting);
 
   let rewardAsset = undefined;
 

apps/trading/e2e/poetry.lock

@@ -1,4 +1,4 @@
-# This file is automatically @generated by Poetry 1.7.1 and should not be changed by hand.
+# This file is automatically @generated by Poetry 1.6.1 and should not be changed by hand.
 
 [[package]]
 name = "certifi"
@@ -1161,7 +1161,7 @@ profile = ["pytest-profiling", "snakeviz"]
 type = "git"
 url = "https://github.com/vegaprotocol/vega-market-sim.git/"
 reference = "fix/genesis_panic"
-resolved_reference = "de30d2d4c7a1b81a830527ca76473e23ef59de12"
+resolved_reference = "7ab04931924380db8000544b7f3d65fcb39b5467"
 
 [[package]]
 name = "websocket-client"

apps/trading/e2e/tests/deal_ticket/test_basic_submit.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from datetime import datetime, timedelta
 from conftest import init_vega
 from fixtures.market import setup_continuous_market
@@ -24,7 +24,7 @@ def continuous_market(vega):
     return setup_continuous_market(vega)
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_limit_buy_order_GTT(continuous_market, vega: VegaServiceNull, page: Page):
+def test_limit_buy_order_GTT(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
     page.get_by_test_id(tif).select_option("Good 'til Time (GTT)")
     page.get_by_test_id(order_size).fill("10")
@@ -52,7 +52,7 @@ def test_limit_buy_order_GTT(continuous_market, vega: VegaServiceNull, page: Pag
     )
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_limit_buy_order(continuous_market, vega: VegaServiceNull, page: Page):
+def test_limit_buy_order(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
     
     page.get_by_test_id(order_size).fill("10")
@@ -69,7 +69,7 @@ def test_limit_buy_order(continuous_market, vega: VegaServiceNull, page: Page):
     )
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_limit_sell_order(continuous_market, vega: VegaServiceNull, page: Page):
+def test_limit_sell_order(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
     page.get_by_test_id(order_size).fill("10")
     page.get_by_test_id(order_price).fill("100")
@@ -93,7 +93,7 @@ def test_limit_sell_order(continuous_market, vega: VegaServiceNull, page: Page):
     )
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_market_sell_order(continuous_market, vega: VegaServiceNull, page: Page):
+def test_market_sell_order(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
     page.get_by_test_id(market_order).click()
     page.get_by_test_id(order_size).fill("10")
@@ -117,7 +117,7 @@ def test_market_sell_order(continuous_market, vega: VegaServiceNull, page: Page)
     )
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_market_buy_order(continuous_market, vega: VegaServiceNull, page: Page):
+def test_market_buy_order(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
     page.get_by_test_id(market_order).click()
     page.get_by_test_id(order_size).fill("10")

apps/trading/e2e/tests/deal_ticket/test_fees_margin_estimations.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 from actions.utils import wait_for_toast_confirmation
 
@@ -13,7 +13,7 @@ market_trading_mode = "market-trading-mode"
 
 @pytest.mark.skip("tbd")
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_margin_and_fees_estimations(continuous_market, vega: VegaServiceNull, page: Page):
+def test_margin_and_fees_estimations(continuous_market, vega: VegaService, page: Page):
     # setup continuous trading market with one user buy trade
     market_id = continuous_market
     page.goto(f"/#/markets/{market_id}")

apps/trading/e2e/tests/deal_ticket/test_stop_order.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 from datetime import datetime, timedelta
 from conftest import init_vega
@@ -38,7 +38,7 @@ timeInForce_col = '[col-id="submission.timeInForce"]'
 updatedAt_col = '[col-id="updatedAt"]'
 close_toast = "toast-close"
 
-def create_position(vega: VegaServiceNull, market_id):
+def create_position(vega: VegaService, market_id):
     submit_order(vega, "Key 1", market_id, "SIDE_SELL", 100, 110)
     submit_order(vega, "Key 1", market_id, "SIDE_BUY", 100, 110)
     vega.forward("10s")
@@ -69,7 +69,7 @@ def test_stop_order_form_error_validation(continuous_market, page: Page):
 
 @pytest.mark.skip("core issue")
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_submit_stop_order_rejected(continuous_market, vega: VegaServiceNull, page: Page):
+def test_submit_stop_order_rejected(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
     page.get_by_test_id(stop_orders_tab).click()
     page.get_by_test_id(stop_order_btn).click()
@@ -108,7 +108,7 @@ def test_submit_stop_order_rejected(continuous_market, vega: VegaServiceNull, pa
 @pytest.mark.skip("core issue")
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_submit_stop_market_order_triggered(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     # 7002-SORD-071
     # 7002-SORD-074
@@ -166,7 +166,7 @@ def test_submit_stop_market_order_triggered(
 @pytest.mark.skip("core issue")
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_submit_stop_limit_order_pending(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     # 7002-SORD-071
     # 7002-SORD-074
@@ -227,7 +227,7 @@ def test_submit_stop_limit_order_pending(
 @pytest.mark.skip("core issue")
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_submit_stop_limit_order_cancel(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     page.goto(f"/#/markets/{continuous_market}")
     page.get_by_test_id(stop_orders_tab).click()
@@ -348,7 +348,7 @@ class TestStopOcoValidation:
     @pytest.mark.skip("core issue")
     @pytest.mark.usefixtures("auth", "risk_accepted")
     def test_maximum_number_of_active_stop_orders(
-        self, continuous_market, vega: VegaServiceNull, page: Page
+        self, continuous_market, vega: VegaService, page: Page
     ):
         page.goto(f"/#/markets/{continuous_market}")
         page.get_by_test_id(stop_orders_tab).click()

apps/trading/e2e/tests/deal_ticket/test_stop_order_oco.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 from actions.utils import wait_for_toast_confirmation
 
@@ -42,7 +42,7 @@ trigger_price_oco = "triggerPrice-oco"
 order_size_oco = "order-size-oco"
 order_limit_price_oco = "order-price-oco"
 
-def create_position(vega: VegaServiceNull, market_id):
+def create_position(vega: VegaService, market_id):
     submit_order(vega, "Key 1", market_id, "SIDE_SELL", 100, 110)
     submit_order(vega, "Key 1", market_id, "SIDE_BUY", 100, 110)
     vega.wait_fn(1)
@@ -51,7 +51,7 @@ def create_position(vega: VegaServiceNull, market_id):
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_submit_stop_order_market_oco_rejected(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     page.goto(f"/#/markets/{continuous_market}")
     page.get_by_test_id(stop_orders_tab).click()
@@ -128,7 +128,7 @@ def test_submit_stop_order_market_oco_rejected(
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_submit_stop_oco_market_order_triggered(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     create_position(vega, continuous_market)
     page.goto(f"/#/markets/{continuous_market}")
@@ -205,7 +205,7 @@ def test_submit_stop_oco_market_order_triggered(
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_submit_stop_oco_market_order_pending(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):  
     create_position(vega, continuous_market)
     page.goto(f"/#/markets/{continuous_market}")
@@ -237,7 +237,7 @@ def test_submit_stop_oco_market_order_pending(
 
 @pytest.mark.usefixtures("page", "continuous_market", "auth", "risk_accepted")
 def test_submit_stop_oco_limit_order_pending(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     create_position(vega, continuous_market)
     page.goto(f"/#/markets/{continuous_market}")
@@ -288,7 +288,7 @@ def test_submit_stop_oco_limit_order_pending(
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_submit_stop_oco_limit_order_cancel(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     create_position(vega, continuous_market)
     page.goto(f"/#/markets/{continuous_market}")

apps/trading/e2e/tests/deal_ticket/test_trading_deal_ticket_submit_account.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.utils import change_keys
 from conftest import init_vega
 from fixtures.market import setup_continuous_market
@@ -33,7 +33,7 @@ def test_should_display_info_and_button_for_deposit(continuous_market, page: Pag
     expect(page.get_by_test_id("sidebar-content")).to_contain_text("DepositFrom")
     
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_should_show_an_error_if_your_balance_is_zero(continuous_market, vega: VegaServiceNull, page: Page):
+def test_should_show_an_error_if_your_balance_is_zero(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
     vega.create_key("key_empty")
     change_keys(page, vega, "key_empty")

apps/trading/e2e/tests/fees/test_fees.py

@@ -1,7 +1,7 @@
 import pytest
 
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 from wallet_config import MM_WALLET
 from conftest import init_vega, init_page, auth_setup
@@ -143,7 +143,7 @@ def auth(vega_instance, page):
     return auth_setup(vega_instance, page)
 
 
-def setup_market_with_volume_discount_program(vega: VegaServiceNull, tier: int):
+def setup_market_with_volume_discount_program(vega: VegaService, tier: int):
     market = setup_continuous_market(vega, custom_quantum=100000)
     vega.update_volume_discount_program(
         proposal_key=MM_WALLET.name,
@@ -169,7 +169,7 @@ def setup_market_with_volume_discount_program(vega: VegaServiceNull, tier: int):
     return market
 
 
-def setup_market_with_referral_discount_program(vega: VegaServiceNull, tier: int):
+def setup_market_with_referral_discount_program(vega: VegaService, tier: int):
     market = setup_continuous_market(vega, custom_quantum=100000)
     vega.update_referral_program(
         proposal_key=MM_WALLET.name,
@@ -208,7 +208,7 @@ def setup_market_with_referral_discount_program(vega: VegaServiceNull, tier: int
     return market
 
 
-def setup_combined_market(vega: VegaServiceNull):
+def setup_combined_market(vega: VegaService):
     market = setup_continuous_market(vega, custom_quantum=100000)
     vega.update_volume_discount_program(
         proposal_key=MM_WALLET.name,
@@ -641,7 +641,7 @@ def test_fills_maker_fee_tooltip_discount_program(
     row = page.get_by_test_id(TAB_FILLS).locator(ROW_LOCATOR).first
     row.locator(COL_FEE).hover()
     expect(page.get_by_test_id(FEE_BREAKDOWN_TOOLTIP)).to_have_text(
-        f"If the market was activeFee revenue to be received by the maker, takers' fee discounts already applied.During continuous trading the maker pays no infrastructure and liquidity fees.Infrastructure fee0.00 tDAILiquidity fee0.00 tDAIMaker fee-{fee} tDAITotal fees-{fee} tDAI"
+        f"If the market was activeThe maker will receive the maker fee.If the market is active the maker will pay zero infrastructure and liquidity fees.Infrastructure fee0.00 tDAILiquidity fee0.00 tDAIMaker fee-{fee} tDAITotal fees-{fee} tDAI"
     )
 
 
@@ -678,5 +678,5 @@ def test_fills_taker_fee_tooltip_discount_program(
     row = page.get_by_test_id(TAB_FILLS).locator(ROW_LOCATOR).first
     row.locator(COL_FEE).hover()
     expect(page.get_by_test_id(FEE_BREAKDOWN_TOOLTIP)).to_have_text(
-        f"If the market was activeFees to be paid by the taker; discounts are already applied.Infrastructure fee{infra_fee} tDAILiquidity fee0.00 tDAIMaker fee{maker_fee} tDAITotal fees{total_fee} tDAI"
+        f"If the market was activeFees to be paid by the taker.Infrastructure fee{infra_fee} tDAILiquidity fee0.00 tDAIMaker fee{maker_fee} tDAITotal fees{total_fee} tDAI"
     )

apps/trading/e2e/tests/get_started/test_get_started.py

@@ -1,7 +1,7 @@
 import pytest
 from playwright.sync_api import expect, Page
 import json
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from fixtures.market import setup_simple_market
 from conftest import init_vega
 from actions.vega import submit_order
@@ -16,11 +16,11 @@ def vega():
         yield vega
 
 @pytest.fixture(scope="class")
-def simple_market(vega: VegaServiceNull):
+def simple_market(vega: VegaService):
     return setup_simple_market(vega)
 
 class TestGetStarted:
-    def test_get_started_interactive(self, vega: VegaServiceNull, page: Page):
+    def test_get_started_interactive(self, vega: VegaService, page: Page):
         page.goto("/")
         # 0007-FUGS-001
         expect(page.get_by_test_id("order-connect-wallet")).to_be_visible
@@ -166,8 +166,7 @@ class TestGetStarted:
         page.wait_for_selector('[data-testid="sidebar-content"]', state="visible")
         expect(page.get_by_test_id("get-started-banner")).not_to_be_visible()
 
-    @pytest.mark.skip("tbd-market-sim")
-    def test_redirect_default_market(self, continuous_market, vega: VegaServiceNull, page: Page):
+    def test_redirect_default_market(self, continuous_market, vega: VegaService, page: Page):
         page.goto("/")
         # 0007-FUGS-012
         expect(page).to_have_url(
@@ -178,7 +177,7 @@ class TestGetStarted:
         expect(page.get_by_test_id("welcome-dialog")).not_to_be_visible()
 
 class TestBrowseAll: 
-    def test_get_started_browse_all(self, simple_market, vega: VegaServiceNull, page: Page):
+    def test_get_started_browse_all(self, simple_market, vega: VegaService, page: Page):
         page.goto("/")
         print(simple_market)
         page.get_by_test_id("browse-markets-button").click()

apps/trading/e2e/tests/iceberg_orders/test_iceberg_orders.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import expect, Page
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 from conftest import init_vega
 from fixtures.market import setup_continuous_market
@@ -22,7 +22,7 @@ class TestIcebergOrdersValidations:
         return setup_continuous_market(vega)
 
     @pytest.mark.usefixtures("auth", "risk_accepted")
-    def test_iceberg_submit(self, continuous_market, vega: VegaServiceNull, page: Page):
+    def test_iceberg_submit(self, continuous_market, vega: VegaService, page: Page):
         page.goto(f"/#/markets/{continuous_market}")
         page.get_by_test_id("iceberg").click()
         page.get_by_test_id("order-peak-size").type("2")
@@ -47,7 +47,7 @@ class TestIcebergOrdersValidations:
         ).to_have_text("Limit (Iceberg)")
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_iceberg_open_order(continuous_market, vega: VegaServiceNull, page: Page):
+def test_iceberg_open_order(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
 
     submit_order(vega, "Key 1", continuous_market, "SIDE_SELL", 102, 101, 2, 1)

apps/trading/e2e/tests/liquidity_provision/test_liquidity_provision.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from conftest import init_vega
 from fixtures.market import setup_continuous_market
 from actions.utils import next_epoch, truncate_middle, change_keys
@@ -18,7 +18,7 @@ def continuous_market(vega):
 
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_liquidity_provision_amendment(continuous_market, vega: VegaServiceNull, page: Page):
+def test_liquidity_provision_amendment(continuous_market, vega: VegaService, page: Page):
     # TODO Refactor asserting the grid
     page.goto(f"/#/liquidity/{continuous_market}")
     change_keys(page, vega, "market_maker")
@@ -77,7 +77,7 @@ def test_liquidity_provision_amendment(continuous_market, vega: VegaServiceNull,
 
 @pytest.mark.skip("Waiting for the ability to cancel LP")
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_liquidity_provision_inactive(continuous_market, vega: VegaServiceNull, page: Page):
+def test_liquidity_provision_inactive(continuous_market, vega: VegaService, page: Page):
     # TODO Refactor asserting the grid
     page.goto(f"/#/liquidity/{continuous_market}")
     change_keys(page, vega, "market_maker")

apps/trading/e2e/tests/market/test_closed_markets.py

@@ -1,7 +1,7 @@
 import pytest
 import re
 import vega_sim.api.governance as governance
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from playwright.sync_api import Page, expect
 from fixtures.market import setup_continuous_market
 from conftest import init_vega
@@ -14,7 +14,7 @@ def vega():
 
 
 @pytest.fixture(scope="class")
-def create_settled_market(vega: VegaServiceNull):
+def create_settled_market(vega: VegaService):
     market_id = setup_continuous_market(vega)
     vega.submit_termination_and_settlement_data(
         settlement_key="FJMKnwfZdd48C8NqvYrG",
@@ -115,7 +115,7 @@ class TestSettledMarket:
 
 
 @pytest.mark.usefixtures("risk_accepted", "auth")
-def test_terminated_market_no_settlement_date(page: Page, vega: VegaServiceNull):
+def test_terminated_market_no_settlement_date(page: Page, vega: VegaService):
     setup_continuous_market(vega)
     print("I have started test_terminated_market_no_settlement_date")
     governance.submit_oracle_data(

apps/trading/e2e/tests/market/test_market.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 from actions.utils import change_keys
 from wallet_config import MM_WALLET, MM_WALLET2
@@ -30,9 +30,9 @@ initial_volume: float = 1
 initial_spread: float = 0.1
 market_name = "BTC:DAI_2023"
 
-@pytest.mark.skip("tbd")
+
 @pytest.mark.usefixtures("risk_accepted", "auth")
-def test_price_monitoring(simple_market, vega: VegaServiceNull, page: Page):
+def test_price_monitoring(simple_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/all")
     expect(page.locator(table_row_selector).locator(trading_mode_col)).to_have_text(
         "Opening auction"
@@ -202,17 +202,17 @@ COL_ID_FEE = ".ag-center-cols-container [col-id='fee'] .ag-cell-value"
 
 
 @pytest.mark.usefixtures("risk_accepted", "auth")
-def test_auction_uncross_fees(continuous_market, vega: VegaServiceNull, page: Page):
+def test_auction_uncross_fees(continuous_market, vega: VegaService, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
     page.get_by_test_id("Fills").click()
     expect(page.locator(COL_ID_FEE)).to_have_text("0.00 tDAI")
     page.locator(COL_ID_FEE).hover()
     expect(page.get_by_test_id("fee-breakdown-tooltip")).to_have_text(
-        "If the market was suspendedDuring auction, half the infrastructure and liquidity fees will be paid.Infrastructure fee0.00 tDAILiquidity fee0.00 tDAIMaker fee0.00 tDAITotal fees0.00 tDAI"
+        "If the market was suspendedIf the market is in monitoring auction, half of the infrastructure and liquidity fees will be paid.Infrastructure fee0.00 tDAILiquidity fee0.00 tDAIMaker fee0.00 tDAITotal fees0.00 tDAI"
     )
     change_keys(page, vega, "market_maker")
     expect(page.locator(COL_ID_FEE)).to_have_text("0.00 tDAI")
     page.locator(COL_ID_FEE).hover()
     expect(page.get_by_test_id("fee-breakdown-tooltip")).to_have_text(
-        "If the market was suspendedDuring auction, half the infrastructure and liquidity fees will be paid.Infrastructure fee0.00 tDAILiquidity fee0.00 tDAIMaker fee0.00 tDAITotal fees0.00 tDAI"
+        "If the market was suspendedIf the market is in monitoring auction, half of the infrastructure and liquidity fees will be paid.Infrastructure fee0.00 tDAILiquidity fee0.00 tDAIMaker fee0.00 tDAITotal fees0.00 tDAI"
     )

apps/trading/e2e/tests/market/test_market_info.py

@@ -1,7 +1,7 @@
 import re
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from fixtures.market import setup_continuous_market
 from conftest import init_page, init_vega, risk_accepted_setup
 
@@ -42,7 +42,7 @@ def validate_info_section(page: Page, fields: [[str, str]]):
             page.get_by_test_id("key-value-table-row").nth(rowNumber).locator("dd")
         ).to_contain_text(value)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_current_fees(page: Page):
     # 6002-MDET-101
     page.get_by_test_id(market_title_test_id).get_by_text("Current fees").click()
@@ -54,7 +54,7 @@ def test_market_info_current_fees(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_market_price(page: Page):
     # 6002-MDET-102
     page.get_by_test_id(market_title_test_id).get_by_text("Market price").click()
@@ -66,7 +66,7 @@ def test_market_info_market_price(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_market_volume(page: Page):
     # 6002-MDET-103
     page.get_by_test_id(market_title_test_id).get_by_text("Market volume").click()
@@ -80,15 +80,15 @@ def test_market_info_market_volume(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_insurance_pool(page: Page):
     # 6002-MDET-104
     page.get_by_test_id(market_title_test_id).get_by_text("Insurance pool").click()
     fields = [["Balance", "0.00 tDAI"]]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
-def test_market_info_key_details(page: Page, vega: VegaServiceNull):
+
+def test_market_info_key_details(page: Page, vega: VegaService):
     # 6002-MDET-201
     page.get_by_test_id(market_title_test_id).get_by_text("Key details").click()
     market_id = vega.find_market_id("BTC:DAI_2023")
@@ -106,7 +106,7 @@ def test_market_info_key_details(page: Page, vega: VegaServiceNull):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_instrument(page: Page):
     # 6002-MDET-202
     page.get_by_test_id(market_title_test_id).get_by_text("Instrument").click()
@@ -121,7 +121,7 @@ def test_market_info_instrument(page: Page):
 
 # @pytest.mark.skip("oracle test to be fixed")
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_oracle(page: Page):
     # 6002-MDET-203
     page.get_by_test_id(market_title_test_id).get_by_text("Oracle").click()
@@ -135,8 +135,8 @@ def test_market_info_oracle(page: Page):
     #     "href", re.compile(rf'(\/oracles\/{vega.find_market_id("BTC:DAI_2023")})')
     # )
 
-@pytest.mark.skip("tbd-market-sim")
-def test_market_info_settlement_asset(page: Page, vega: VegaServiceNull):
+
+def test_market_info_settlement_asset(page: Page, vega: VegaService):
     # 6002-MDET-206
     page.get_by_test_id(market_title_test_id).get_by_text("Settlement asset").click()
     tdai_id = vega.find_asset_id("tDAI")
@@ -155,7 +155,7 @@ def test_market_info_settlement_asset(page: Page, vega: VegaServiceNull):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_metadata(page: Page):
     # 6002-MDET-207
     page.get_by_test_id(market_title_test_id).get_by_text("Metadata").click()
@@ -164,7 +164,7 @@ def test_market_info_metadata(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_risk_model(page: Page):
     # 6002-MDET-208
     page.get_by_test_id(market_title_test_id).get_by_text("Risk model").click()
@@ -175,7 +175,7 @@ def test_market_info_risk_model(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_margin_scaling_factors(page: Page):
     # 6002-MDET-209
     page.get_by_test_id(market_title_test_id).get_by_text(
@@ -190,7 +190,7 @@ def test_market_info_margin_scaling_factors(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_risk_factors(page: Page):
     # 6002-MDET-210
     page.get_by_test_id(market_title_test_id).get_by_text("Risk factors").click()
@@ -204,7 +204,7 @@ def test_market_info_risk_factors(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_price_monitoring_bounds(page: Page):
     # 6002-MDET-211
     page.get_by_test_id(market_title_test_id).get_by_text(
@@ -220,7 +220,7 @@ def test_market_info_price_monitoring_bounds(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_liquidity_monitoring_parameters(page: Page):
     # 6002-MDET-212
     page.get_by_test_id(market_title_test_id).get_by_text(
@@ -233,7 +233,7 @@ def test_market_info_liquidity_monitoring_parameters(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 # Liquidity resolves to 3 results
 def test_market_info_liquidit(page: Page):
     # 6002-MDET-213
@@ -246,7 +246,7 @@ def test_market_info_liquidit(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
+
 def test_market_info_liquidity_price_range(page: Page):
     # 6002-MDET-214
     page.get_by_test_id(market_title_test_id).get_by_text(
@@ -259,8 +259,8 @@ def test_market_info_liquidity_price_range(page: Page):
     ]
     validate_info_section(page, fields)
 
-@pytest.mark.skip("tbd-market-sim")
-def test_market_info_proposal(page: Page, vega: VegaServiceNull):
+
+def test_market_info_proposal(page: Page, vega: VegaService):
     # 6002-MDET-301
     page.get_by_test_id(market_title_test_id).get_by_text("Proposal").click()
     first_link = (
@@ -280,9 +280,8 @@ def test_market_info_proposal(page: Page, vega: VegaServiceNull):
         "href", re.compile(r"(\/proposals\/propose\/update-market)")
     )
 
-    
-@pytest.mark.skip("tbd-market-sim")
-def test_market_info_succession_line(page: Page, vega: VegaServiceNull):
+
+def test_market_info_succession_line(page: Page, vega: VegaService):
     page.get_by_test_id(market_title_test_id).get_by_text("Succession line").click()
     market_id = vega.find_market_id("BTC:DAI_2023")
     succession_line = page.get_by_test_id("succession-line-item")

apps/trading/e2e/tests/market/test_markets_proposed.py

@@ -2,7 +2,7 @@ import pytest
 import vega_sim.api.governance as governance
 import re
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from conftest import init_vega
 from fixtures.market import setup_simple_market
 from wallet_config import MM_WALLET
@@ -18,7 +18,7 @@ def vega(request):
 
 
 @pytest.fixture(scope="module")
-def proposed_market(vega: VegaServiceNull):
+def proposed_market(vega: VegaService):
     # setup market without liquidity provided
     market_id = setup_simple_market(vega, approve_proposal=False)
     # approve market

apps/trading/e2e/tests/market/test_monitoring_auction_price_volatility_market.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 from fixtures.market import setup_simple_market
 from conftest import init_vega
@@ -20,7 +20,7 @@ def simple_market(vega):
 
 
 @pytest.fixture(scope="module")
-def setup_market_monitoring_auction(vega: VegaServiceNull, simple_market):
+def setup_market_monitoring_auction(vega: VegaService, simple_market):
     vega.submit_liquidity(
         key_name=MM_WALLET.name,
         market_id=simple_market,
@@ -82,7 +82,7 @@ def setup_market_monitoring_auction(vega: VegaServiceNull, simple_market):
 
 @pytest.mark.usefixtures("risk_accepted", "auth", "setup_market_monitoring_auction")
 def test_market_monitoring_auction_price_volatility_limit_order(
-    page: Page, simple_market, vega: VegaServiceNull
+    page: Page, simple_market, vega: VegaService
 ):
     page.goto(f"/#/markets/{simple_market}")
     page.get_by_test_id("order-size").clear()

apps/trading/e2e/tests/market_lifecycle/test_market_lifecycle.py

@@ -2,8 +2,7 @@ import pytest
 import re
 import vega_sim.api.governance as governance
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
-from vega_sim.service import PeggedOrder
+from vega_sim.service import VegaService, PeggedOrder
 import vega_sim.api.governance as governance
 from actions.vega import submit_order
 from actions.utils import next_epoch
@@ -11,7 +10,7 @@ from wallet_config import MM_WALLET, MM_WALLET2, GOVERNANCE_WALLET
 
 
 @pytest.mark.usefixtures("risk_accepted")
-def test_market_lifecycle(proposed_market, vega: VegaServiceNull, page: Page):
+def test_market_lifecycle(proposed_market, vega: VegaService, page: Page):
     # 7002-SORD-001
     # 7002-SORD-002
     trading_mode = page.get_by_test_id("market-trading-mode").get_by_test_id(

apps/trading/e2e/tests/order/test_order_details.py

@@ -1,7 +1,7 @@
 import pytest
 import re
 from playwright.sync_api import expect, Page
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 
 order_details = [
@@ -52,7 +52,7 @@ def verify_order_value(
 @pytest.mark.skip("tbd")
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_order_details_are_correctly_displayed(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     page.goto(f"/#/markets/{continuous_market}")
     submit_order(vega, "Key 1", vega.all_markets()[0].id, "SIDE_SELL", 102, 101, 2, 1)

apps/trading/e2e/tests/order/test_order_match.py

@@ -2,7 +2,7 @@ import pytest
 import re
 import logging
 from playwright.sync_api import expect, Page
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from playwright.sync_api import expect
 from actions.vega import submit_order
 
@@ -38,7 +38,7 @@ def verify_data_grid(page: Page, data_test_id, expected_pattern):
                 raise AssertionError(f"Pattern does not match: {expected} != {actual}")
 
 
-def submit_order(vega: VegaServiceNull, wallet_name, market_id, side, volume, price):
+def submit_order(vega: VegaService, wallet_name, market_id, side, volume, price):
     vega.submit_order(
         trading_key=wallet_name,
         market_id=market_id,
@@ -52,7 +52,7 @@ def submit_order(vega: VegaServiceNull, wallet_name, market_id, side, volume, pr
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_limit_order_trade_open_order(
-    opening_auction_market, vega: VegaServiceNull, page: Page
+    opening_auction_market, vega: VegaService, page: Page
 ):
     market_id = opening_auction_market
     submit_order(vega, "Key 1", market_id, "SIDE_BUY", 1, 110)

apps/trading/e2e/tests/order/test_order_status.py

@@ -1,7 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.service import PeggedOrder
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService, PeggedOrder
 from conftest import auth_setup, init_page, init_vega, risk_accepted_setup
 from fixtures.market import setup_continuous_market, setup_simple_market
 from actions.utils import wait_for_toast_confirmation
@@ -16,7 +15,7 @@ def vega(request):
 
 
 @pytest.fixture(scope="module", autouse=True)
-def markets(vega: VegaServiceNull):
+def markets(vega: VegaService):
     market_1 = setup_continuous_market(
         vega,
         custom_market_name="market-1",
@@ -358,7 +357,7 @@ def test_order_status_pegged_mid(page: Page):
     )
 
 
-def test_order_amend_order(vega: VegaServiceNull, page: Page):
+def test_order_amend_order(vega: VegaService, page: Page):
     #  7002-SORD-053
     #  7003-MORD-012
     #  7003-MORD-014
@@ -378,7 +377,7 @@ def test_order_amend_order(vega: VegaServiceNull, page: Page):
     )
 
 
-def test_order_cancel_single_order(vega: VegaServiceNull, page: Page):
+def test_order_cancel_single_order(vega: VegaService, page: Page):
     #  7003-MORD-009
     #  7003-MORD-010
     #  7003-MORD-011
@@ -395,7 +394,7 @@ def test_order_cancel_single_order(vega: VegaServiceNull, page: Page):
     )
 
 
-def test_order_cancel_all_orders(vega: VegaServiceNull, page: Page):
+def test_order_cancel_all_orders(vega: VegaService, page: Page):
     #  7003-MORD-009
     #  7003-MORD-010
     #  7003-MORD-011

apps/trading/e2e/tests/perpetual_market/test_perpetuals.py

@@ -1,7 +1,7 @@
 import pytest
 import re
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from vega_sim.service import MarketStateUpdateType
 from datetime import datetime, timedelta
 from conftest import init_vega
@@ -21,7 +21,7 @@ class TestPerpetuals:
             yield vega
 
     @pytest.fixture(scope="class")
-    def perps_market(self, vega: VegaServiceNull):
+    def perps_market(self, vega: VegaService):
         perps_market = setup_perps_market(vega)
         submit_multiple_orders(
             vega, MM_WALLET.name, perps_market, "SIDE_SELL", [[1, 110], [1, 105]]
@@ -96,7 +96,7 @@ class TestPerpetuals:
 
 
 @pytest.mark.usefixtures("risk_accepted", "auth")
-def test_perps_market_termination_proposed(page: Page, vega: VegaServiceNull):
+def test_perps_market_termination_proposed(page: Page, vega: VegaService):
     perpetual_market = setup_perps_market(vega)
     page.goto(f"/#/markets/{perpetual_market}")
     vega.update_market_state(
@@ -124,7 +124,7 @@ def test_perps_market_termination_proposed(page: Page, vega: VegaServiceNull):
 
 
 @pytest.mark.usefixtures("risk_accepted", "auth")
-def test_perps_market_terminated(page: Page, vega: VegaServiceNull):
+def test_perps_market_terminated(page: Page, vega: VegaService):
     perpetual_market = setup_perps_market(vega)
     vega.update_market_state(
         proposal_key=MM_WALLET.name,
@@ -141,8 +141,8 @@ def test_perps_market_terminated(page: Page, vega: VegaServiceNull):
     page.goto(f"/#/markets/{perpetual_market}")
     # TODO change back to have text once bug #5465 is fixed
     expect(page.get_by_test_id("market-price")).to_have_text("Mark Price100.00")
-    expect(page.get_by_test_id("market-change")).to_contain_text("Change (24h)")
-    expect(page.get_by_test_id("market-volume")).to_contain_text("Volume (24h)")
+    expect(page.get_by_test_id("market-change")).to_contain_text("Change (24h)-")
+    expect(page.get_by_test_id("market-volume")).to_contain_text("Volume (24h)-")
     expect(page.get_by_test_id("market-trading-mode")).to_have_text(
         "Trading modeNo trading"
     )

apps/trading/e2e/tests/pnl/test_pnl.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.vega import submit_order
 from actions.utils import change_keys
 
@@ -13,7 +13,7 @@ def check_pnl_color_value(element, expected_color, expected_value):
 
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_pnl(continuous_market, vega: VegaServiceNull, page: Page):
+def test_pnl(continuous_market, vega: VegaService, page: Page):
     page.set_viewport_size({"width": 1748, "height": 977})
     submit_order(vega, "Key 1", continuous_market, "SIDE_BUY", 1, 104.50000)
     vega.wait_fn(1)

apps/trading/e2e/tests/positions/test_collateral.py

@@ -1,6 +1,6 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from conftest import init_vega
 from fixtures.market import setup_continuous_market
 
@@ -16,7 +16,7 @@ def vega(request):
 
 
 @pytest.fixture(scope="module")
-def continuous_market(vega: VegaServiceNull):
+def continuous_market(vega: VegaService):
     return setup_continuous_market(vega)
 
 

apps/trading/e2e/tests/positions/test_positions.py

@@ -1,13 +1,13 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from fixtures.market import (
     setup_continuous_market,
 )
 
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_closed_market_position(vega: VegaServiceNull, page: Page):
+def test_closed_market_position(vega: VegaService, page: Page):
     market_id = setup_continuous_market(vega)
 
     vega.submit_termination_and_settlement_data(

apps/trading/e2e/tests/referrals/test_referrals.py

@@ -1,6 +1,6 @@
 import pytest
-from playwright.sync_api import Page
-from vega_sim.null_service import VegaServiceNull
+from playwright.sync_api import Page, expect
+from vega_sim.service import VegaService
 from conftest import init_vega
 from fixtures.market import setup_continuous_market, setup_simple_market
 from actions.utils import change_keys, create_and_faucet_wallet, forward_time, selector_contains_text
@@ -72,7 +72,7 @@ def create_staking_tier(minimum_staked_tokens, referral_reward_multiplier):
     }
 
 
-def setup_market_and_referral_scheme(vega: VegaServiceNull, continuous_market: str, page: Page):
+def setup_market_and_referral_scheme(vega: VegaService, continuous_market: str, page: Page):
     page.goto(f"/#/markets/{continuous_market}")
 
     create_and_faucet_wallet(vega=vega, wallet=PARTY_A)
@@ -118,7 +118,7 @@ def setup_market_and_referral_scheme(vega: VegaServiceNull, continuous_market: s
 
 
 @pytest.mark.usefixtures("page", "auth", "risk_accepted")
-def test_can_traverse_up_and_down_through_tiers(continuous_market, vega: VegaServiceNull, page: Page):
+def test_can_traverse_up_and_down_through_tiers(continuous_market, vega: VegaService, page: Page):
     setup_market_and_referral_scheme(vega, continuous_market, page)
     change_keys(page, vega, PARTY_B.name)
     submit_order(vega, PARTY_B.name, continuous_market, "SIDE_BUY", 1, 115)
@@ -162,7 +162,7 @@ def test_can_traverse_up_and_down_through_tiers(continuous_market, vega: VegaSer
 
 
 @pytest.mark.usefixtures("page", "auth", "risk_accepted")
-def test_does_not_move_up_tiers_when_not_enough_epochs(continuous_market, vega: VegaServiceNull, page: Page):
+def test_does_not_move_up_tiers_when_not_enough_epochs(continuous_market, vega: VegaService, page: Page):
     setup_market_and_referral_scheme(vega, continuous_market, page)
     change_keys(page, vega, PARTY_B.name)
     submit_order(vega, PARTY_B.name, continuous_market, "SIDE_BUY", 2, 115)

apps/trading/e2e/tests/successor_market/test_succession_line.py

@@ -1,12 +1,12 @@
 import pytest
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from fixtures.market import setup_continuous_market, setup_simple_successor_market
 
 
 @pytest.fixture
 @pytest.mark.usefixtures()
-def successor_market(vega: VegaServiceNull):
+def successor_market(vega: VegaService):
     parent_market_id = setup_continuous_market(vega)
     tdai_id = vega.find_asset_id(symbol="tDAI")
     successor_market_id = setup_simple_successor_market(
@@ -22,7 +22,7 @@ def successor_market(vega: VegaServiceNull):
     vega.wait_for_total_catchup()
     return successor_market_id
 
-@pytest.mark.skip("tbd")
+
 @pytest.mark.usefixtures("risk_accepted")
 def test_succession_line(page: Page, successor_market):
     page.goto(f"/#/markets/{successor_market}")

apps/trading/e2e/tests/trade_history/test_trade_history.py

@@ -5,7 +5,7 @@ from playwright.sync_api import expect
 from actions.vega import submit_order
 from conftest import init_vega
 from playwright.sync_api import Page
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.null_service import VegaService
 
 logger = logging.getLogger()
 
@@ -47,7 +47,7 @@ def verify_data_grid(page: Page, data_test_id, expected_pattern):
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_limit_order_new_trade_top_of_list(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     submit_order(vega, "Key 1", continuous_market, "SIDE_BUY", 1, 110)
     vega.wait_fn(1)

apps/trading/e2e/tests/trade_match/test_trade_match.py

@@ -1,13 +1,13 @@
 import pytest
 from playwright.sync_api import expect, Page
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 
 from actions.vega import submit_multiple_orders
 
 
 @pytest.mark.skip("tbd")
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_trade_match_table(opening_auction_market: str, vega: VegaServiceNull, page: Page):
+def test_trade_match_table(opening_auction_market: str, vega: VegaService, page: Page):
     row_locator = ".ag-center-cols-container .ag-row"
     page.goto(f"/#/markets/{opening_auction_market}")
 

apps/trading/e2e/tests/trading_chart/test_trading_chart.py

@@ -2,7 +2,7 @@
 # import re
 # from collections import namedtuple
 # from playwright.sync_api import Page
-from vega_sim.null_service import VegaServiceNull
+# from vega_sim.service import VegaService
 # from actions.vega import submit_order
 
 # import logging
@@ -14,7 +14,7 @@ from vega_sim.null_service import VegaServiceNull
 # @pytest.mark.skip("temporary skip")
 # @pytest.mark.parametrize(, [120], indirect=True)
 # @pytest.mark.usefixtures("continuous_market","risk_accepted", "auth")
-# def test_trading_chart(continuous_market, vega: VegaServiceNull, page: Page):
+# def test_trading_chart(continuous_market, vega: VegaService, page: Page):
 #     page.goto(f"/#/markets/{continuous_market}")
 #     vega.forward("24h")
 #     vega.wait_for_total_catchup()

apps/trading/e2e/tests/transfer/test_transfer_key_to_key.py

@@ -1,7 +1,7 @@
 import pytest
 import re
 from playwright.sync_api import Page, expect
-from vega_sim.null_service import VegaServiceNull
+from vega_sim.service import VegaService
 from actions.utils import (
     wait_for_toast_confirmation,
     create_and_faucet_wallet,
@@ -18,7 +18,7 @@ PARTY_C = WalletConfig("party_c", "party_c")
 
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
-def test_transfer_submit(continuous_market, vega: VegaServiceNull, page: Page):
+def test_transfer_submit(continuous_market, vega: VegaService, page: Page):
     # 1003-TRAN-001
     # 1003-TRAN-006
     # 1003-TRAN-007
@@ -64,7 +64,7 @@ def test_transfer_submit(continuous_market, vega: VegaServiceNull, page: Page):
 
 @pytest.mark.usefixtures("auth", "risk_accepted")
 def test_transfer_vesting_below_minimum(
-    continuous_market, vega: VegaServiceNull, page: Page
+    continuous_market, vega: VegaService, page: Page
 ):
     vega.update_network_parameter(
         "market_maker",

apps/trading/e2e/tests/wallet/test_wallet.py

@@ -2,6 +2,7 @@ import pytest
 import re
 import json
 from playwright.sync_api import Page, expect, Route
+from vega_sim.service import VegaService
 from conftest import init_vega
 from fixtures.market import setup_continuous_market
 

apps/trading/pages/_document.page.tsx

@@ -13,7 +13,7 @@ export default function Document() {
         {/* preload fonts */}
         <link
           rel="preload"
-          href="/AlphaLyrae.woff2"
+          href="/AlphaLyrae-Medium.woff2"
           as="font"
           type="font/woff2"
         />

apps/trading/pages/styles.css

@@ -4,7 +4,8 @@
 /** Load AlphaLyrae font */
 @font-face {
   font-family: AlphaLyrae;
-  src: url('/AlphaLyrae.woff2') format('woff2');
+  src: url('/AlphaLyrae-Medium.woff2') format('woff2'),
+    url('/AlphaLyrae-Medium.woff') format('woff');
 }
 
 @tailwind base;

libs/data-provider/src/generic-data-provider.ts

@@ -7,7 +7,6 @@ import type {
   FetchResult,
   ErrorPolicy,
   ApolloQueryResult,
-  QueryOptions,
 } from '@apollo/client';
 import type { GraphQLErrors } from '@apollo/client/errors';
 import type { Subscription } from 'zen-observable-ts';
@@ -159,7 +158,6 @@ interface DataProviderParams<
   };
   fetchPolicy?: FetchPolicy;
   resetDelay?: number;
-  pollInterval?: number;
   additionalContext?: Record<string, unknown>;
   errorPolicyGuard?: (graphqlErrors: GraphQLErrors) => boolean;
   getQueryVariables?: (variables: Variables) => QueryVariables;
@@ -200,7 +198,6 @@ function makeDataProviderInternal<
   errorPolicyGuard,
   getQueryVariables,
   getSubscriptionVariables,
-  pollInterval,
 }: DataProviderParams<
   QueryData,
   Data,
@@ -225,7 +222,6 @@ function makeDataProviderInternal<
   let client: ApolloClient<object>;
   let subscription: Subscription[] | undefined;
   let pageInfo: PageInfo | null = null;
-  let watchQuerySubscription: Subscription | null = null;
 
   // notify single callback about current state, delta is passes optionally only if notify was invoked onNext
   const notify = (
@@ -247,100 +243,34 @@ function makeDataProviderInternal<
     callbacks.forEach((callback) => notify(callback, updateData));
   };
 
-  const getQueryOptions = (
-    pagination?: Pagination,
-    policy?: ErrorPolicy
-  ): QueryOptions<OperationVariables, QueryData> => ({
-    query,
-    variables: {
-      ...(getQueryVariables ? getQueryVariables(variables) : variables),
-      ...(pagination && {
-        // let the variables pagination be prior to provider param
-        pagination: {
-          ...pagination,
-          ...(variables?.['pagination'] ?? null),
-        },
-      }),
-    },
-    fetchPolicy: fetchPolicy || 'no-cache',
-    context: additionalContext,
-    errorPolicy: policy || 'none',
-    pollInterval,
-  });
-
-  const onNext = (res: ApolloQueryResult<QueryData>) => {
-    data = getData(res.data, variables);
-    if (data && pagination) {
-      if (!(data instanceof Array)) {
-        throw new Error(
-          'data needs to be instance of Edge[] when using pagination'
-        );
-      }
-      pageInfo = pagination.getPageInfo(res.data);
-    }
-    // if there was some updates received from subscription during initial query loading apply them on just received data
-    if (update && data && updateQueue && updateQueue.length > 0) {
-      while (updateQueue.length) {
-        const delta = updateQueue.shift();
-        if (delta) {
-          setData(update(data, delta, reload, variables));
-        }
-      }
-    }
-    loaded = true;
-  };
-
-  const onError = (e: Error) => {
-    if (isNotFoundGraphQLError(e, ['party'])) {
-      data = getData(null, variables);
-      loaded = true;
-      return;
-    }
-    // if error will occur data provider stops subscription
-    error = e;
-    subscriptionUnsubscribe();
-  };
-
-  const onComplete = (isUpdate?: boolean) => {
-    loading = false;
-    notifyAll({ isUpdate });
-  };
-
-  const callWatchQuery = (pagination?: Pagination, policy?: ErrorPolicy) => {
-    let onNextCalled = false;
-    try {
-      watchQuerySubscription = client
-        .watchQuery(getQueryOptions(pagination, policy))
-        .subscribe(
-          (res) => {
-            onNext(res);
-            onComplete(onNextCalled);
-            onNextCalled = true;
-          },
-          (error) => {
-            onError(error as Error);
-            onComplete();
-          }
-        );
-    } catch (e) {
-      onError(e as Error);
-      onComplete();
-    }
-  };
-
-  const callQuery = (
+  const call = (
     pagination?: Pagination,
     policy?: ErrorPolicy
   ): Promise<ApolloQueryResult<QueryData>> =>
     client
-      .query<QueryData>(getQueryOptions(pagination, policy))
+      .query<QueryData>({
+        query,
+        variables: {
+          ...(getQueryVariables ? getQueryVariables(variables) : variables),
+          ...(pagination && {
+            // let the variables pagination be prior to provider param
+            pagination: {
+              ...pagination,
+              ...(variables?.['pagination'] ?? null),
+            },
+          }),
+        },
+        fetchPolicy: fetchPolicy || 'no-cache',
+        context: additionalContext,
+        errorPolicy: policy || 'none',
+      })
       .catch((err) => {
         if (
           err.graphQLErrors &&
           errorPolicyGuard &&
           errorPolicyGuard(err.graphQLErrors)
         ) {
-          return callQuery(pagination, 'ignore');
+          return call(pagination, 'ignore');
         } else {
           throw err;
         }
@@ -364,7 +294,7 @@ function makeDataProviderInternal<
       }
     }
 
-    const res = await callQuery(paginationVariables);
+    const res = await call(paginationVariables);
 
     const insertionData = getData(res.data, variables);
     const insertionPageInfo = pagination.getPageInfo(res.data);
@@ -399,7 +329,7 @@ function makeDataProviderInternal<
             variables,
             fetchPolicy,
           })
-          .subscribe(subscriptionOnNext, subscriptionOnError)
+          .subscribe(onNext, onError)
       );
   };
 
@@ -417,16 +347,39 @@ function makeDataProviderInternal<
     const paginationVariables = pagination
       ? { first: pagination.first }
       : undefined;
-    if (pollInterval) {
-      callWatchQuery();
-      return;
-    }
     try {
-      onNext(await callQuery(paginationVariables));
+      const res = await call(paginationVariables);
+      data = getData(res.data, variables);
+      if (data && pagination) {
+        if (!(data instanceof Array)) {
+          throw new Error(
+            'data needs to be instance of Edge[] when using pagination'
+          );
+        }
+        pageInfo = pagination.getPageInfo(res.data);
+      }
+      // if there was some updates received from subscription during initial query loading apply them on just received data
+      if (update && data && updateQueue && updateQueue.length > 0) {
+        while (updateQueue.length) {
+          const delta = updateQueue.shift();
+          if (delta) {
+            setData(update(data, delta, reload, variables));
+          }
+        }
+      }
+      loaded = true;
     } catch (e) {
-      onError(e as Error);
+      if (isNotFoundGraphQLError(e as Error, ['party'])) {
+        data = getData(null, variables);
+        loaded = true;
+        return;
+      }
+      // if error will occur data provider stops subscription
+      error = e as Error;
+      subscriptionUnsubscribe();
     } finally {
-      onComplete(isUpdate);
+      loading = false;
+      notifyAll({ isUpdate });
     }
   };
 
@@ -446,7 +399,7 @@ function makeDataProviderInternal<
     }
   };
 
-  const subscriptionOnNext = ({
+  const onNext = ({
     data: subscriptionData,
   }: FetchResult<SubscriptionData>) => {
     if (!subscriptionData || !getDelta || !update) {
@@ -465,7 +418,7 @@ function makeDataProviderInternal<
     }
   };
 
-  const subscriptionOnError = (e: Error) => {
+  const onError = (e: Error) => {
     error = e;
     subscriptionUnsubscribe();
     notifyAll();
@@ -489,9 +442,6 @@ function makeDataProviderInternal<
   };
 
   const reset = () => {
-    if (watchQuerySubscription) {
-      watchQuerySubscription.unsubscribe();
-    }
     subscriptionUnsubscribe();
     initialized = false;
     data = null;

libs/fills/src/lib/fills-table.tsx

@@ -87,9 +87,9 @@ export const FillsTable = forwardRef<AgGridReact, Props>(
           colId: 'fee',
           field: 'market',
           valueFormatter: formatFee(partyId),
-          tooltipComponent: FeesBreakdownTooltip,
           type: 'rightAligned',
           tooltipField: 'market',
+          tooltipComponent: FeesBreakdownTooltip,
           tooltipComponentParams: { partyId },
         },
         {
@@ -97,13 +97,13 @@ export const FillsTable = forwardRef<AgGridReact, Props>(
           colId: 'fee-discount',
           field: 'market',
           valueFormatter: formatFeeDiscount(partyId),
+          type: 'rightAligned',
+          // return null to disable tooltip if fee discount is 0 or empty
           tooltipValueGetter: ({ valueFormatted, value }) => {
             return valueFormatted && /[1-9]/.test(valueFormatted)
               ? valueFormatted
               : null;
           },
-          type: 'rightAligned',
-          // return null to disable tooltip if fee discount is 0 or empty
           cellRenderer: ({
             value,
             valueFormatted,
@@ -146,7 +146,7 @@ export const FillsTable = forwardRef<AgGridReact, Props>(
         overlayNoRowsTemplate={t('No fills')}
         getRowId={({ data }) => data?.id}
         tooltipShowDelay={0}
-        tooltipHideDelay={10000}
+        tooltipHideDelay={2000}
         components={{ MarketNameCell }}
         {...props}
       />
@@ -292,27 +292,21 @@ const FeesBreakdownTooltip = ({
       )}
       {role === MAKER && (
         <>
+          <p className="mb-1">{t('The maker will receive the maker fee.')}</p>
           <p className="mb-1">
             {t(
-              `Fee revenue to be received by the maker, takers' fee discounts already applied.`
-            )}
-          </p>
-          <p className="mb-1">
-            {t(
-              'During continuous trading the maker pays no infrastructure and liquidity fees.'
+              'If the market is active the maker will pay zero infrastructure and liquidity fees.'
             )}
           </p>
         </>
       )}
       {role === TAKER && (
-        <p className="mb-1">
-          {t('Fees to be paid by the taker; discounts are already applied.')}
-        </p>
+        <p className="mb-1">{t('Fees to be paid by the taker.')}</p>
       )}
       {(role === '-' || marketState === Schema.MarketState.STATE_SUSPENDED) && (
         <p className="mb-1">
           {t(
-            'During auction, half the infrastructure and liquidity fees will be paid.'
+            'If the market is in monitoring auction, half of the infrastructure and liquidity fees will be paid.'
           )}
         </p>
       )}

libs/i18n/src/locales/en/fills.json

@@ -5,9 +5,9 @@
   "Date": "Date",
   "Fee": "Fee",
   "Fee Discount": "Fee Discount",
-  "Fees to be paid by the taker; discounts are already applied.": "Fees to be paid by the taker; discounts are already applied.",
-  "During continuous trading the maker pays no infrastructure and liquidity fees.": "During continuous trading the maker pays no infrastructure and liquidity fees.",
-  "During auction, half the infrastructure and liquidity fees will be paid.": "During auction, half the infrastructure and liquidity fees will be paid.",
+  "Fees to be paid by the taker.": "Fees to be paid by the taker.",
+  "If the market is active the maker will pay zero infrastructure and liquidity fees.": "If the market is active the maker will pay zero infrastructure and liquidity fees.",
+  "If the market is in monitoring auction, half of the infrastructure and liquidity fees will be paid.": "If the market is in monitoring auction, half of the infrastructure and liquidity fees will be paid.",
   "Infrastructure Fee": "Infrastructure Fee",
   "Market": "Market",
   "No fills": "No fills",

libs/i18n/src/locales/en/governance.json

@@ -298,8 +298,8 @@
   "liquidityOnsenIntro": "Earn rewards for providing liquidity on the",
   "liquidityOnsenLinkText": "SushiSwap Onsen Menu",
   "liquidityProviderVote": "Liquidity provider vote",
-  "liquidityProviderVotesAgainst": "LP share against",
-  "liquidityProviderVotesFor": "LP share for",
+  "liquidityProviderVotesAgainst": "LP votes against",
+  "liquidityProviderVotesFor": "LP votes for",
   "liquidityRewardsTitle": "Active liquidity rewards",
   "liquidityRewardsTitlePrevious": "Previous liquidity rewards",
   "liquidityStakedBalance": "SLP token balance",
@@ -759,7 +759,7 @@
   "Total stake": "Total stake",
   "Total supply": "Total supply",
   "totalDistributed": "Total distributed",
-  "totalLiquidityProviderTokensVoted": "Total LP share voted",
+  "totalLiquidityProviderTokensVoted": "Total LP tokens voted",
   "totalPenalties": "Total penalties",
   "TotalPenaltiesDescription": "Total of penalties taking into account performance (considering proportion of blocks proposed against the number of blocks the validator was expected to propose) and any overstaking.",
   "totalStake": "Total stake",

libs/markets/src/lib/components/market-info/market-info-data-provider.ts

@@ -34,7 +34,6 @@ export const marketInfoProvider = makeDataProvider<
   query: MarketInfoDocument,
   getData,
   errorPolicyGuard: marketDataErrorPolicyGuard,
-  pollInterval: 5000,
 });
 
 export const marketInfoWithDataProvider = makeDerivedDataProvider<

libs/proposals/src/lib/protocol-upgrade-proposals/use-block-rising.ts

@@ -68,13 +68,10 @@ export const useBlockRising = (skip = false) => {
         }
       );
 
-      const heights = compact([...results.map((r) => r?.blockHeight)]);
-
-      // Handles TendermintErrorResponses
-      if (blockInfo && 'result' in blockInfo) {
-        heights.push(blockInfo.result.block.header.height);
-      }
-
+      const heights = compact([
+        ...results.map((r) => r?.blockHeight),
+        blockInfo?.result.block.header.height,
+      ]);
       const current = max(heights);
       if (current && Number(current) > prev) {
         setBlock(Number(current));

libs/react-helpers/src/hooks/use-fetch.ts

@@ -76,26 +76,16 @@ export const useFetch = <T>(
             ...options,
             body: body ? body : options?.body,
           });
-
-          data = (await response.json()) as T;
-
-          if (!response.ok && !data) {
+          if (!response.ok) {
             throw new Error(response.statusText);
           }
 
+          data = (await response.json()) as T;
           // @ts-ignore - 'error' in data
-          if (data && data.error) {
-            // Explicit check for TendermintErrorResponse style error
-            // @ts-ignore - 'error' in data
-            if (data.error.data) {
-              // @ts-ignore - 'error' in data
-
-              throw new Error(data.error.data);
-            }
+          if (data && 'error' in data) {
             // @ts-ignore - data.error
             throw new Error(data.error);
           }
-
           if (cancelRequest.current) return;
 
           dispatch({ type: ActionType.FETCHED, payload: data });

libs/tendermint/src/lib/use-block-info.ts

@@ -1,11 +1,6 @@
 import { useEnvironment } from '@vegaprotocol/environment';
 import { useFetch } from '@vegaprotocol/react-helpers';
-import type {
-  TendermintBlockResponse,
-  TendermintErrorResponse,
-} from '../types';
-
-type TendermintResponse = TendermintBlockResponse | TendermintErrorResponse;
+import { type TendermintBlockResponse } from '../types';
 
 export const useBlockInfo = (blockHeight?: number, canFetch = true) => {
   const { TENDERMINT_URL } = useEnvironment();
@@ -15,7 +10,7 @@ export const useBlockInfo = (blockHeight?: number, canFetch = true) => {
     TENDERMINT_URL && blockHeight && !isNaN(blockHeight) && canFetch
   );
 
-  const { state, refetch } = useFetch<TendermintResponse>(
+  const { state, refetch } = useFetch<TendermintBlockResponse>(
     url,
     { cache: 'force-cache' },
     canFetchData

libs/tendermint/src/types.ts

@@ -7,16 +7,6 @@ export type TendermintBlockResponse = {
   };
 };
 
-export type TendermintErrorResponse = {
-  jsonrpc: string;
-  id: number;
-  error: {
-    code: number;
-    message: string;
-    data: string;
-  };
-};
-
 type Id = {
   hash: string;
   parts: {
@@ -44,7 +34,7 @@ type Header = {
   proposer_address: string;
 };
 
-export type Block = {
+type Block = {
   header: Header;
   data: {
     txs: string[];

tools/ci/define-dist-variables.py

@@ -16,7 +16,7 @@ bucket_name = ''
 if 'release/' in args.github_ref:
   if 'mainnet-mirror' in args.github_ref:
     env_name = 'mainnet-mirror'
-  elif 'validators-testnet' in args.github_ref or 'validator-testnet' in args.github_ref:
+  if 'validators-testnet' in args.github_ref:
     env_name = 'validators-testnet'
   else:
     # remove prefixing release/ and take the first string limited by - which is supposed to be name of the environment for releasing (format: release/testnet-trading)